Here a mockup how it could look like on nodebb.org forum:
There still is not working.
Okay, fixed that too.
These look awesome! I did something like that for BuddyPress (remove the need for Gravatar) by drawing GitHub-style "identicons" (see here) for users without a profile photo. My project used the GD PHP library so it won't be useful here but it's great to see you're going to be removing (many) calls to the (external) Gravatar service.
Many users were concerned over privacy implications of sites using Gravatar (such as letting Gravatar know what sites they were on based on image load).
We could solve this by saving the images locally, but we may as well remove it altogether.
As the Italian American said.
Wait... wait, green?
@julian you occupy too much space, unfortunately.
@xen So, somehow the other images are getting pushed down by
1px, which is causing the whole card to have
1px more height.
The thing is, I have no idea WTF is causing that. Fucking CSS.
@pitaj It's the line-height.
From my icon? Argh.....!
.user-icon is the offending class and
line-height is the offending property.
Interesting! Is this on master already?
Another bug is the sidebar on mobile login.
Seems like no default is set for a guest user.
Also in the chat dropdown.
left: 22px from
#menu .chat-list li a .user-icon+i, .header .chat-list li a .user-icon+i
...I think thats it.
I must say, its nice to see that NodeBB won't depend so much on outside resources by default.
You may have noticed I now have a user icon instead of an avatar... we're testing something new because we're looking to remove gravatar from core
New users will still show their old avatars (gravatars or not), so hopefully this isn't a breaking change. Please report any oddities here (such as user icons missing).
Will you keep gravatar as a plugin?
@exodo that sounds like an "of course" or "we'll keep it in core as an option" thing to me