User Icons Testing

xen

Clicking the avatar notifications not working.

julian

Fixed, thanks!

xen

There still is not working.

julian

Okay, fixed that too.

Henry Wright

These look awesome! I did something like that for BuddyPress (remove the need for Gravatar) by drawing GitHub-style "identicons" (see here) for users without a profile photo. My project used the GD PHP library so it won't be useful here but it's great to see you're going to be removing (many) calls to the (external) Gravatar service.

julian

Many users were concerned over privacy implications of sites using Gravatar (such as letting Gravatar know what sites they were on based on image load).

We could solve this by saving the images locally, but we may as well remove it altogether.

a_5mith

As the Italian American said.

Ayy. (A)

trevor

Wait... wait, green?

xen

@julian you occupy too much space, unfortunately.

PitaJ

@xen So, somehow the other images are getting pushed down by 1px, which is causing the whole card to have 1px more height.

The thing is, I have no idea WTF is causing that. Fucking CSS.

<baris>

@pitaj It's the line-height.

julian

From my icon? Argh.....!

Henry Wright

Yup, .user-icon is the offending class and line-height is the offending property.

Marc Boisvert-Dupras

Interesting! Is this on master already?

? Offline

Another bug is the sidebar on mobile login.
Seems like no default is set for a guest user.

reid

Also in the chat dropdown.

trevor

Simple fix.

0_1445824186724_Screen Shot 2015-10-25 at 9.49.08 PM.png

Remove the left: 22px from
#menu .chat-list li a .user-icon+i, .header .chat-list li a .user-icon+i

...I think thats it.

Robert

I must say, its nice to see that NodeBB won't depend so much on outside resources by default.

julian

@trevor Thanks! No clue why I added it, must've been superfluous... nice catch by yourself and @reid.

Edit: Bugs mentioned above (except for recent cards incompatibility) have been resolved.

exodo

@julian said:

You may have noticed I now have a user icon instead of an avatar... we're testing something new because we're looking to remove gravatar from core

New users will still show their old avatars (gravatars or not), so hopefully this isn't a breaking change. Please report any oddities here (such as user icons missing).

Will you keep gravatar as a plugin?