User Icons Testing

[drew]

Ah, a hard reload solved it.

[xen]

X - it means I am.

[julian]

@drew said:

Ah, a hard reload solved it.

Silly browser cache,

[xen]

Clicking the avatar notifications not working.

[julian]

Fixed, thanks!

[xen]

There still is not working.

[julian]

Okay, fixed that too.

[henrywright]

These look awesome! I did something like that for BuddyPress (remove the need for Gravatar) by drawing GitHub-style "identicons" (see here) for users without a profile photo. My project used the GD PHP library so it won't be useful here but it's great to see you're going to be removing (many) calls to the (external) Gravatar service.

[julian]

Many users were concerned over privacy implications of sites using Gravatar (such as letting Gravatar know what sites they were on based on image load).

We could solve this by saving the images locally, but we may as well remove it altogether.

[a_5mith]

As the Italian American said.

Ayy. (A)

[trevor]

Wait... wait, green?

[xen]

@julian you occupy too much space, unfortunately.

[PitaJ]

@xen So, somehow the other images are getting pushed down by 1px, which is causing the whole card to have 1px more height.

The thing is, I have no idea WTF is causing that. Fucking CSS.

[baris]

@pitaj It's the line-height.

[julian]

From my icon? Argh.....!

[henrywright]

Yup, .user-icon is the offending class and line-height is the offending property.

[Marc Boisvert-Dupras]

Interesting! Is this on master already?

[A Former User]

Another bug is the sidebar on mobile login.
Seems like no default is set for a guest user.

[reid]

Also in the chat dropdown.

[trevor]

Simple fix.

Remove the left: 22px from
#menu .chat-list li a .user-icon+i, .header .chat-list li a .user-icon+i

...I think thats it.