Hover Cards - nodebb-plugin-cards

phenomlab

@baris said in Hover Cards - nodebb-plugin-cards:

What does it show in the browser console tab when you click the error? Does it show the new code?

No, it shows the old code, which is odd because in the build directory, I see the correct version

In the console, I see

<baris>

Could be browser cache then, try clearing or disabling cache.

phenomlab

@baris Tried from Incognito - exactly the same

PitaJ

If it shows the correct version on disk, but not in your browser, then it must be some cache along the way. Restart NodeBB, try a different browser entirely, etc

phenomlab

@pitaj said in Hover Cards - nodebb-plugin-cards:

If it shows the correct version on disk, but not in your browser, then it must be some cache along the way. Restart NodeBB, try a different browser entirely, etc

I'd usually agree, but it's the same issue on different browsers (with multiple NodeBB restarts), and even different machines

phenomlab

@pitaj @baris I do see this in the console

Error minifying node_modules/nodebb-plugin-cards2/public/js/main.js
SyntaxError: Unexpected token: punc ())
    at JS_Parse_Error.get (eval at <anonymous> (/home/phenomlab/nodebb/node_modules/uglify-es/tools/node.js:21:1), <anonymous>:75:23)
    at minifyAndSave (/home/phenomlab/nodebb/src/meta/minifier.js:242:90)
    at /home/phenomlab/nodebb/src/meta/minifier.js:213:3
    at /home/phenomlab/nodebb/node_modules/async/dist/async.js:248:13
    at wrapper (/home/phenomlab/nodebb/node_modules/async/dist/async.js:268:20)
    at iterateeCallback (/home/phenomlab/nodebb/node_modules/async/dist/async.js:421:28)
    at /home/phenomlab/nodebb/node_modules/async/dist/async.js:321:20
    at /home/phenomlab/nodebb/node_modules/async/dist/async.js:245:17
    at /home/phenomlab/nodebb/src/meta/minifier.js:202:4
    at /home/phenomlab/nodebb/node_modules/graceful-fs/graceful-fs.js:123:16

<baris>

I fixed a typo in the PR https://github.com/Schamper/nodebb-plugin-cards/pull/11/commits/31df0c9b782bcb313e31d27c7a72ca253aa3e96d
Apply that rebuild & restart, try again.

phenomlab

@baris thanks. I'll check this tomorrow and report back.

phenomlab

@baris said in Hover Cards - nodebb-plugin-cards:

I fixed a typo in the PR https://github.com/Schamper/nodebb-plugin-cards/pull/11/commits/31df0c9b782bcb313e31d27c7a72ca253aa3e96d
Apply that rebuild & restart, try again.

@baris This works as intended. Thanks

enot

@phenomlab now to get it merged

<baris>

This is now merged

enot

@baris very cool, thanks for the heads up

DownPW

@baris

I have this error when I clic on follow button :

ERROR
Invalid event: user.follow

<baris>

https://github.com/Schamper/nodebb-plugin-cards/pull/13/files

DownPW

Thanks @baris for the fix.

Can you put on update/upgrade with ACP?

I have fix manually.

Thanks in advance.

DownPW

seems to not work on 2.2.4.
I am alone ? @baris

just css pb on fab

phenomlab

@baris slightly old topic here, but is there any way this can be adapted for v3.x and Harmony? Harmony doesn't seem to have it's own by default like Persona

julian

For what it's worth, I'd rather we don't have cards in core. Plugin, though?

It goes against my personal best practices for user interface design in the sense that the cards appear on hover, which is far too easy to trigger accidentally, even with a delay... and if you introduce a delay, you don't want one that's too long, otherwise you inconvenience the end user (rock & hard place, anyone?)

I also prefer that hover actions have minimal effects (like highlighting table rows, etc.), precisely because it is not always an active user action. Large effects like opening a user card could potentially block content, and that's concerning for me.

... but not everybody shares my rather opinionated views on UX

phenomlab

@julian said in Hover Cards - nodebb-plugin-cards:

but not everybody shares my rather opinionated views on UX

Well, I personally find it hard to disagree with these points, as I've encountered all of these scenarios myself However, it would be nice if the existing plugin could be forked and made to work with Harmony.

DownPW

@phenomlab @julian @baris

I asked the question to @Schamper for compatibility with nodeBB 3.x and here is his answer :

https://github.com/Schamper/nodebb-plugin-cards/issues/16#issuecomment-1578221016