Hover Cards - nodebb-plugin-cards

<baris>

fix: remove utils.invalid checks, fixes by barisusakli · Pull Request #11 · Schamper/nodebb-plugin-cards

https://community.nodebb.org/topic/15676/hover-cards-nodebb-plugin-cards

GitHub (github.com)

phenomlab

@baris Thanks

phenomlab

@baris Actually, on checking this and making the required modifications, it still shows the same error ? Have replaced the main.js file with the revised one in nodebb-modules then rebuilt and restarted, but the error still exists.

<baris>

What does it show in the browser console tab when you click the error? Does it show the new code?

phenomlab

@baris said in Hover Cards - nodebb-plugin-cards:

What does it show in the browser console tab when you click the error? Does it show the new code?

No, it shows the old code, which is odd because in the build directory, I see the correct version

In the console, I see

<baris>

Could be browser cache then, try clearing or disabling cache.

phenomlab

@baris Tried from Incognito - exactly the same

PitaJ

If it shows the correct version on disk, but not in your browser, then it must be some cache along the way. Restart NodeBB, try a different browser entirely, etc

phenomlab

@pitaj said in Hover Cards - nodebb-plugin-cards:

If it shows the correct version on disk, but not in your browser, then it must be some cache along the way. Restart NodeBB, try a different browser entirely, etc

I'd usually agree, but it's the same issue on different browsers (with multiple NodeBB restarts), and even different machines

phenomlab

@pitaj @baris I do see this in the console

Error minifying node_modules/nodebb-plugin-cards2/public/js/main.js
SyntaxError: Unexpected token: punc ())
    at JS_Parse_Error.get (eval at <anonymous> (/home/phenomlab/nodebb/node_modules/uglify-es/tools/node.js:21:1), <anonymous>:75:23)
    at minifyAndSave (/home/phenomlab/nodebb/src/meta/minifier.js:242:90)
    at /home/phenomlab/nodebb/src/meta/minifier.js:213:3
    at /home/phenomlab/nodebb/node_modules/async/dist/async.js:248:13
    at wrapper (/home/phenomlab/nodebb/node_modules/async/dist/async.js:268:20)
    at iterateeCallback (/home/phenomlab/nodebb/node_modules/async/dist/async.js:421:28)
    at /home/phenomlab/nodebb/node_modules/async/dist/async.js:321:20
    at /home/phenomlab/nodebb/node_modules/async/dist/async.js:245:17
    at /home/phenomlab/nodebb/src/meta/minifier.js:202:4
    at /home/phenomlab/nodebb/node_modules/graceful-fs/graceful-fs.js:123:16

<baris>

I fixed a typo in the PR https://github.com/Schamper/nodebb-plugin-cards/pull/11/commits/31df0c9b782bcb313e31d27c7a72ca253aa3e96d
Apply that rebuild & restart, try again.

phenomlab

@baris thanks. I'll check this tomorrow and report back.

phenomlab

@baris said in Hover Cards - nodebb-plugin-cards:

I fixed a typo in the PR https://github.com/Schamper/nodebb-plugin-cards/pull/11/commits/31df0c9b782bcb313e31d27c7a72ca253aa3e96d
Apply that rebuild & restart, try again.

@baris This works as intended. Thanks

enot

@phenomlab now to get it merged

<baris>

This is now merged

enot

@baris very cool, thanks for the heads up

DownPW

@baris

I have this error when I clic on follow button :

ERROR
Invalid event: user.follow

<baris>

update removed socket method and use api module by barisusakli · Pull Request #13 · Schamper/nodebb-plugin-cards

also use alerts module, app.alertSucces/Error etc are deprecated

GitHub (github.com)

DownPW

Thanks @baris for the fix.

Can you put on update/upgrade with ACP?

I have fix manually.

Thanks in advance.

DownPW

seems to not work on 2.2.4.
I am alone ? @baris

just css pb on fab