Updating to 1.3.0 - Issues
-
Any know issues with 1.3.0 from 1.2.x, is it safe to update!
Tell me about your issues
-
@Jenkler said in Updating to 1.3.0 - Issues:
sues with 1.3.0 from 1.2.x, is it safe to upd
Nothing to mention from my part
Up and running ^^ -
NodeBB-plugin-custom-pages breaks on 1.3.0
-
@PitaJ Crap, then I can't update yet. Do you know if someone is working on it? Does https://github.com/NodeBB/nodebb-plugin-custom-homepage break also?
Link to info: https://community.nodebb.org/topic/1701/nodebb-plugin-custom-pages-custom-static-pages-for-nodebb/90
@psychobunny Is this something you have time to fix?
@julian I think we spoke earlier about making this into core code. But I could be wrong
-
Replicasets seemed to break here but fixed with the adding the replicaset name to config. Commented on it here.
use replicaset if configured by Icehunter · Pull Request #3091 · NodeBB/NodeBB
I use a replicaset. Here's a patch to use as well. config.json: { "url": "http://localhost:4567", "secret": "fae93eb7-f17b-429d-a614-4783d8466517", "database": "mongo", "mongo": { ...
GitHub (github.com)
I was wondering if I should file it as a bug.
-
yea.. im getting:
{"errno":-39,"code":"ENOTEMPTY","syscall":"rmdir","path":"/home/forum/NodeBB/public/templates","level":"error","timestamp":"2016-11-19T05:00:09.533Z"} [cluster] Child Process (1272) has exited (code: 0, signal: null)Not quite sure what plugin is doing this...
-
Yay.. found it.. its nodebb-plugin-rss
{"level":"error","message":"TypeError: data.title.trim is not a function\n at Object.Topics.post (/home/forum/NodeBB/src/topics/create.js:92:39)\n at /home/forum/NodeBB/node_modules/nodebb-plugin-rss/index.js:229:11\n .... -
-
I can fix it, but I would use a different approach then what the plugin currently uses.
-
@yariplus said in Updating to 1.3.0 - Issues:
I can fix it, but I would use a different approach then what the plugin currently uses.
What's your solution?
Haven't taken a look at the plugin yet to see what's wrong... in fact, when I did try it out, it seemed to work fine on latest master :shipit: -
@julian said in Updating to 1.3.0 - Issues:
@yariplus said in Updating to 1.3.0 - Issues:
I can fix it, but I would use a different approach then what the plugin currently uses.
What's your solution?
Haven't taken a look at the plugin yet to see what's wrong... in fact, when I did try it out, it seemed to work fine on latest master :shipit:I changed it so that it writes templates to it's own directory, and compiles them from there. Removes the hotswap stuff, and doesn't depend on nodebb's own templates directory being available.
GitHub - yariplus/nodebb-plugin-custom-pages
Contribute to yariplus/nodebb-plugin-custom-pages development by creating an account on GitHub.
GitHub (github.com)
-
@yariplus I just tested it. Your version is showing 3.2 current version is 3.3.
It' currently does not work, error message - you seem to have stumbled upon a page that does not exist. Return to the home page.
3.3 is custom page, route is setup like:
mywebsite/newrouteYours is setup like:
mywebsite/custom-pages/newroute -
@evoixmr said in Updating to 1.3.0 - Issues:
@yariplus I just tested it. Your version is showing 3.2 current version is 3.3.
Blame @psychobunny
It' currently does not work, error message - you seem to have stumbled upon a page that does not exist. Return to the home page.
3.3 is custom page, route is setup like:
mywebsite/newrouteYours is setup like:
mywebsite/custom-pages/newrouteThe routes are exactly the same, I only changed the location of the templates. Did you install using npm? It probably ignored the empty directory. The directory
templates/custom-pagesshould exist in the plugin folder. -
is there a
templates/custom-pagesdirectory in the plugin folder?
-- a workaround is to 
