Updating to 1.3.0 - Issues
-
I can fix it, but I would use a different approach then what the plugin currently uses.
-
@yariplus said in Updating to 1.3.0 - Issues:
I can fix it, but I would use a different approach then what the plugin currently uses.
What's your solution? Haven't taken a look at the plugin yet to see what's wrong... in fact, when I did try it out, it seemed to work fine on latest master :shipit:
-
@julian said in Updating to 1.3.0 - Issues:
@yariplus said in Updating to 1.3.0 - Issues:
I can fix it, but I would use a different approach then what the plugin currently uses.
What's your solution? Haven't taken a look at the plugin yet to see what's wrong... in fact, when I did try it out, it seemed to work fine on latest master :shipit:
I changed it so that it writes templates to it's own directory, and compiles them from there. Removes the hotswap stuff, and doesn't depend on nodebb's own templates directory being available.
-
@yariplus I just tested it. Your version is showing 3.2 current version is 3.3.
It' currently does not work, error message - you seem to have stumbled upon a page that does not exist. Return to the home page.
3.3 is custom page, route is setup like:
mywebsite/newrouteYours is setup like:
mywebsite/custom-pages/newroute -
@evoixmr said in Updating to 1.3.0 - Issues:
@yariplus I just tested it. Your version is showing 3.2 current version is 3.3.
Blame @psychobunny
It' currently does not work, error message - you seem to have stumbled upon a page that does not exist. Return to the home page.
3.3 is custom page, route is setup like:
mywebsite/newrouteYours is setup like:
mywebsite/custom-pages/newrouteThe routes are exactly the same, I only changed the location of the templates. Did you install using npm? It probably ignored the empty directory. The directory
templates/custom-pages
should exist in the plugin folder. -
is there a
templates/custom-pages
directory in the plugin folder? -
create the directory and restart nodebb, it should make the templates.
-
@yariplus The hotswap stuff was added so the routes can be available without a NodeBB restart... I'm not entirely sure removing it was the right course of action
Also, if you guys are using latest, you probably need to
./nodebb build
... -
@Jenkler said in Updating to 1.3.0 - Issues:
Any know issues with 1.3.0 from 1.2.x, is it safe to update!
Tell me about your issues
Everything goes well
-
Yeah, idk. My version was just an experiment really. Are you on the master branch? The regular version seems to work on master.