Swedish Members

@yariplus ok thanks. as long as it is safe

When doing this, how to fix? @julian, can you update this for 1.11.x ??? ( 4 vulns involved breaking changes)
plz advize!

git clone https://github.com/NodeBB/NodeBB.git ; cd NodeBB
git checkout v1.11.x
npm install --production

npm audit fix
up to date in 9.946s
fixed 0 of 5 vulnerabilities in 4314 scanned packages
  1 vulnerability required manual review and could not be updated
  1 package update for 4 vulns involved breaking changes
  (use `npm audit fix --force` to install breaking changes; or refer to `npm audit` for steps to fix these manually)


                       === npm audit security report ===                        
                                                                                
# Run  npm install less@3.9.0  to resolve 4 vulnerabilities
SEMVER WARNING: Recommended action is a potentially breaking change
                                                                                
  Moderate        Prototype pollution                                           
                                                                                
  Package         hoek                                                          
                                                                                
  Dependency of   less                                                          
                                                                                
  Path            less > request > hawk > boom > hoek                           
                                                                                
  More info       https://nodesecurity.io/advisories/566                        
                                                                                


                                                                                
  Moderate        Prototype pollution                                           
                                                                                
  Package         hoek                                                          
                                                                                
  Dependency of   less                                                          
                                                                                
  Path            less > request > hawk > cryptiles > boom > hoek               
                                                                                
  More info       https://nodesecurity.io/advisories/566                        
                                                                                


                                                                                
  Moderate        Prototype pollution                                           
                                                                                
  Package         hoek                                                          
                                                                                
  Dependency of   less                                                          
                                                                                
  Path            less > request > hawk > hoek                                  
                                                                                
  More info       https://nodesecurity.io/advisories/566                        
                                                                                


                                                                                
  Moderate        Prototype pollution                                           
                                                                                
  Package         hoek                                                          
                                                                                
  Dependency of   less                                                          
                                                                                
  Path            less > request > hawk > sntp > hoek                           
                                                                                
  More info       https://nodesecurity.io/advisories/566                        
                                                                                

                                 Manual Review                                  
             Some vulnerabilities require your attention to resolve             
                                                                                
          Visit https://go.npm.me/audit-guide for additional guidance           
                                                                                
                                                                                
  Low             Regular Expression Denial of Service                          
                                                                                
  Package         debug                                                         
                                                                                
  Patched in      >= 2.6.9 < 3.0.0 || >= 3.1.0                                  
                                                                                
  Dependency of   socket.io-adapter-mongo                                       
                                                                                
  Path            socket.io-adapter-mongo > debug                               
                                                                                
  More info       https://nodesecurity.io/advisories/534                        
                                                                                
found 5 vulnerabilities (1 low, 4 moderate) in 4314 scanned packages
  4 vulnerabilities require semver-major dependency updates.
  1 vulnerability requires manual review. See the full report for details.

Yeah yeah I forgot and his

I need to watch out for my trigger fingers

@PitaJ said in Pull request in my repo! Advise me :

@Jenkler the actual PR does not have require.main.require so it will break your plugin.

Yeah, found out that when it was to late But now it should be okay Thanks!

lol, does it look OK now?

@baris said in Pull request in my repo! Advise me :

const meta = require.main.require('./src/meta');

https://github.com/Jenkler/nodebb-plugin-postlink/commit/c2f87f76259b03e31161bea21d9ae06df0f78b4e

0 Jenkler committed to Jenkler/nodebb-plugin-postlink

Fixed correct require for meta

Ohh, crap. I missed the "require.main.require" part Then its better to to patch this

Ok. but why does it work with only ./meta ? What is the issue with using ./meta? Seams to find it anyway