Updating to 1.3.0 - Issues

PitaJ

NodeBB-plugin-custom-pages breaks on 1.3.0

Mikael Jenkler

@PitaJ Crap, then I can't update yet. Do you know if someone is working on it? Does https://github.com/NodeBB/nodebb-plugin-custom-homepage break also?

Link to info: https://community.nodebb.org/topic/1701/nodebb-plugin-custom-pages-custom-static-pages-for-nodebb/90

@psychobunny Is this something you have time to fix?

@julian I think we spoke earlier about making this into core code. But I could be wrong

hmj

Replicasets seemed to break here but fixed with the adding the replicaset name to config. Commented on it here.

https://github.com/NodeBB/NodeBB/pull/3091

I was wondering if I should file it as a bug.

julian

No need, since it has been merged in now Thanks!

Leonardo Galani

yea.. im getting:

 {"errno":-39,"code":"ENOTEMPTY","syscall":"rmdir","path":"/home/forum/NodeBB/public/templates","level":"error","timestamp":"2016-11-19T05:00:09.533Z"}
 [cluster] Child Process (1272) has exited (code: 0, signal: null)

Not quite sure what plugin is doing this...

Leonardo Galani

Yay.. found it.. its nodebb-plugin-rss

{"level":"error","message":"TypeError: data.title.trim is not a function\n    at Object.Topics.post (/home/forum/NodeBB/src/topics/create.js:92:39)\n    at     /home/forum/NodeBB/node_modules/nodebb-plugin-rss/index.js:229:11\n  
....

Mikael Jenkler

We need to find a solution for custom pages! @yariplus <-- Do you have the knowhow?

julian

Yes, I'm aware custom pages is broken on 1.3.0 -- a workaround is to rm -rf public/templates and then start NodeBB up again.

yariplus

I can fix it, but I would use a different approach then what the plugin currently uses.

Mikael Jenkler

@julian But then I need to recreate the pages again right? Would be nice to have a solid solution integrated into core!

Mikael Jenkler

@yariplus That sounds interesting

julian

@yariplus said in Updating to 1.3.0 - Issues:

I can fix it, but I would use a different approach then what the plugin currently uses.

What's your solution? Haven't taken a look at the plugin yet to see what's wrong... in fact, when I did try it out, it seemed to work fine on latest master :shipit:

yariplus

@julian said in Updating to 1.3.0 - Issues:

@yariplus said in Updating to 1.3.0 - Issues:

I can fix it, but I would use a different approach then what the plugin currently uses.

What's your solution? Haven't taken a look at the plugin yet to see what's wrong... in fact, when I did try it out, it seemed to work fine on latest master :shipit:

I changed it so that it writes templates to it's own directory, and compiles them from there. Removes the hotswap stuff, and doesn't depend on nodebb's own templates directory being available.

GitHub - yariplus/nodebb-plugin-custom-pages

Contribute to yariplus/nodebb-plugin-custom-pages development by creating an account on GitHub.

GitHub (github.com)

evoixmr

@yariplus I just tested it. Your version is showing 3.2 current version is 3.3.

It' currently does not work, error message - you seem to have stumbled upon a page that does not exist. Return to the home page.

3.3 is custom page, route is setup like:
mywebsite/newroute

Yours is setup like:
mywebsite/custom-pages/newroute

yariplus

@evoixmr said in Updating to 1.3.0 - Issues:

@yariplus I just tested it. Your version is showing 3.2 current version is 3.3.

Blame @psychobunny

It' currently does not work, error message - you seem to have stumbled upon a page that does not exist. Return to the home page.

3.3 is custom page, route is setup like:
mywebsite/newroute

Yours is setup like:
mywebsite/custom-pages/newroute

The routes are exactly the same, I only changed the location of the templates. Did you install using npm? It probably ignored the empty directory. The directory templates/custom-pages should exist in the plugin folder.

evoixmr

@yariplus yes I installed by: npm install https://github.com/yariplus/nodebb-plugin-custom-pages.git

Do I need to empty the draft zone before I install? the only thing I can think of is I did not stop nodebb before installing.

yariplus

is there a templates/custom-pages directory in the plugin folder?

evoixmr

@yariplus no the directory was not created.

yariplus

create the directory and restart nodebb, it should make the templates.

julian

@yariplus The hotswap stuff was added so the routes can be available without a NodeBB restart... I'm not entirely sure removing it was the right course of action

Also, if you guys are using latest, you probably need to ./nodebb build...