List of plugins that are incompatible when upgrading to version 1.19.2

PitaJ

So emoji in posts work, just not replacement of ASCII sequences? Can you try toggling it off, saving, and back on in the settings?

phenomlab

@PitaJ Tried already - multiple times.

PitaJ

@phenomlab can you confirm that everything but ASCII sequences replacement works:

autocomplete
dialog
replacement of system emoji

phenomlab

@PitaJ Confirmed. Only part not working is this

Replace common ASCII characters like :), -_-, etc

DownPW

@PitaJ Confirmed too

crazycells

We got emoji errors too. After rebuilding the plugin and then the forum, emojis came back, but ASCII characters are still not working... I carried the log errors here:

error after upgrading NodeBB 1.19.2 · Issue #51 · NodeBB/nodebb-plugin-emoji

after upgrading to NodeBB 1.19.2 we got 100s of this error in the log: 2022-02-11T02:49:28.984Z [4567/24661] - �[31merror�[39m: [emoji] Failed to retrieve data for parse ENOENT: no such file or directory, open '/home/fsuzer/nodebb/node_m...

GitHub (github.com)

<baris>

The emoji error should be fixed in [email protected]

phenomlab

@baris Not working for me. Latest version installed.

<baris>

What's not working? No emoji's at all or just :) not turning into emojis? seems to work here with just ascii characters.

phenomlab

@baris Just ASCII characters not turning into emojis, like :) for example which should be

FrankM

@baris said in List of plugins that are incompatible when upgrading to version 1.19.2:

The emoji error should be fixed in [email protected]

In the package the plugin is stored with version 3.5.9. Manually installing 3.5.12 did not solve the problem for me ( not turning into emojis)

phenomlab

@baris Any update for this issue please ?

Thanks

<baris>

No updates, we are using 3.5.12 on this forum and ascii characters are turning into emoji

phenomlab

@baris said in List of plugins that are incompatible when upgrading to version 1.19.2:

we are using 3.5.12 on this forum and ascii characters are turning into emoji

Hmm. Could be another plugin causing this issue, but seeing as there are several others with the same problem.....

PitaJ

@phenomlab can you try disabling other plugins and see if you can find one that causes the issue? It may also be that you need to place emoji higher on the plugin priority.

<baris>

Yeah this was a combination of a change in the emoji plugin and plugin load order causing some issues. I t should be fixed in the latest emoji plugin (3.5.14) https://github.com/NodeBB/nodebb-plugin-emoji/issues/52

phenomlab

@baris Thanks. Confirmed working after upgrade, rebuild emoji assets, then rebuild and restart

FrankM

Tested in two forums and works as expected. @baris Thanks!

julian

@volanar What is the issue with canned-responses and gdpr? Those plugins don't really do much, and 1.19.2 didn't introduce any breaking changes

crazycells

@julian said in List of plugins that are incompatible when upgrading to version 1.19.2:

@volanar What is the issue with canned-responses and gdpr? Those plugins don't really do much, and 1.19.2 didn't introduce any breaking changes

maybe he is talking about the log warnings...
we do not have a real problem with canned-responses , but we are getting this warning in the logs:

2022-02-16T19:40:42.377Z [4569/53875] - [32minfo[39m: [build] admin control panel styles  build completed in 13.753sec
2022-02-16T19:40:44.027Z [4569/53875] - [32minfo[39m: [build]                  languages  build completed in 15.401sec
[benchpress] warning: output bloat due to ambiguous inner BEGIN
     --> admin/plugins/canned-responses.tpl:44:17
      |
   44 | 						<!-- BEGIN responses -->
      | 						           ^^^^^^^^^ `responses` could refer to the top-level value `responses` or the `.responses` property of the current element, so compiler must emit code for both cases
      | note: Migrate to modern syntax to avoid the ambiguity. This will become an error in the future.

2022-02-16T19:40:44.996Z [4569/53875] - [32minfo[39m: [build]          requirejs modules  build completed in 16.41sec
2022-02-16T19:40:45.295Z [4569/53875] - [32minfo[39m: [build]                  templates  build completed in 16.669sec