0.9 Upgrade command failed

exodo

git fetch; git pull, npm i; ./nodebb upgrade; git checkout v0.8.x; git pull; npm install; ./nodebb stop; ./nodebb upgrade; ./nodebb start; ./nodebb log

Make sure that things are okay then...

git fetch; git pull, npm i; ./nodebb upgrade; git checkout v0.9.x; git pull; npm install; ./nodebb stop; ./nodebb upgrade; ./nodebb start; ./nodebb log

So easy lol

Bri

@julian said:

@Kowlin Possibly... I made the mistake of using peer dependencies awhile back, and it's been nothing short of a headache. The idea in and of itself is fantastic, but the implementation was not suitable for a project like ours.

So are we doing away with peer dependencies?

julian

Depends, why do you need them in your plugin?

Bri

No I don't need them, but curious since they're causing trouble

julian

The way npm handles peer dependencies left much to be desired, especially in a development landscape like ours where versions go up regularly and different rates compared to plugins.

Specifically, if a module A required a peer dependency B with a fairly strict version (e.g. ~0.15.0), then if that dependency got updated to v0.16.0 or above, then any future attempts to install module A would throw a peer dependency error and abort the npm installation, leaving NodeBB in a state that would not run. That's not so good for non-developers