[nodebb-plugin-shoutbox] Shoutbox plugin

[julian]

@Mr_Waffle said:

Thanks guys, I'll keep expanding this over time.

That's what I like to hear

[Schamper]

Just updated with 0.0.2. It fixed a few bugs, and added a few new things.

• Fixed double registering of shoutbox.receive
• You can now delete shouts
• Add some checks on the socket handlers to prevent server crashes (this is also a NodeBB issue)
• Added simple config in admin page
• Fixed /shoutbox page

[BarveyHirdman]

Is there anything to do apart from npm install?

I enabled the plugin, restarted NodeBB, cleared cache, but can't send messages.
Also if I start NodeBB in development mode I get a warning: warn: [socket.io] Unrecognized message: api:modules.shoutbox.get
(I'm using the edge version of NodeBB, freshly pulled.)

[Schamper]

Ye they changed the sockets around a bit on the latest version, will get around to making my plugin compatible asap.

[Schamper]

@BarveyHirdman I updated it and pushed a new version to npm, should work fine now.

0.0.3 changelog:

• Fix shout deletion on newly created shouts
• Completely refactored client shoutbox.js, much easier for me to expand, and for other people to understand!
• Now compatible with their new socketAL implementation

[BarveyHirdman]

@Mr_Waffle works like a charm

[trevor]

Thanks for posting changelogs, that helps a lot. ^_^'

[psychobunny]

lol wow, you know I was just asking the team earlier today on how to implement websockets in one of the plugins I was working on. Clearly you're one step ahead of me @Mr_Waffle

[Schamper]

@psychobunny Yeah it took me a while to find a nice way without adding anything to the core code, but I think my method is pretty nice Would be even better if there was a plugin socket.io module, where all the plugins would hook into

[psychobunny]

the way you did it is interesting. I was asking julian earlier to implement a hook in websockets so we could add new socket calls (similar to the one in webserver for routes). maybe we don't need it then... @julian thoughts?

[baris]

I just wrote this and used the same method as @mr_waffle. This seems fine to me and it also makes me think if we could use the same system in our other plugins. For example getting the express app object and adding routes to it inside the plugin instead of putting a hook for create_routes.

[psychobunny]

we need to ditch the

$(document).bind('DOMNodeInserted', function(event) {

and replace that with an ajaxify.onchange event for 0.3.1

Just a heads up, for the three people who are using that technique atm

p.s. I have no idea how badly that performs but I would imagine it sucks.

[Schamper]

@psychobunny Yup, requested that in the hook request thread as well

[StuartH]

@mr_waffle I have the shoutbox installed but it says I must be logged in to post but I am logged in!! I logged out then in, cleared cache, on nodebb 2.1, I can break anything

[Schamper]

@StuartH Are you on edge?

[StuartH]

Only when my wife is near
no on nodebb 2.1

[Schamper]

@StuartH said:

Only when my wife is near
no on nodebb 2.1

Only edge is supported right now. I suppose you can do `npm install [email protected] to still get basic shoutbox functionality on your version.

[julian]

Hey @Mr_Waffle -- he's actually reasonably close to the edge builds. Let me grab the commit hash: 2654a8e

1 day old

[Schamper]

@julian said:

Hey @Mr_Waffle -- he's actually reasonably close to the edge builds. Let me grab the commit hash: 2654a8e

1 day old

Hm weird, that should work then... I'll put it on my list for things to check

[xCausxn]

Not working with lavender theme just letting people know