[nodebb-plugin-shoutbox] Shoutbox plugin

<baris>

I just wrote this and used the same method as @mr_waffle. This seems fine to me and it also makes me think if we could use the same system in our other plugins. For example getting the express app object and adding routes to it inside the plugin instead of putting a hook for create_routes.

psychobunny

we need to ditch the

$(document).bind('DOMNodeInserted', function(event) {

and replace that with an ajaxify.onchange event for 0.3.1

Just a heads up, for the three people who are using that technique atm

p.s. I have no idea how badly that performs but I would imagine it sucks.

Schamper

@psychobunny Yup, requested that in the hook request thread as well

StuartH

@mr_waffle I have the shoutbox installed but it says I must be logged in to post but I am logged in!! I logged out then in, cleared cache, on nodebb 2.1, I can break anything

Schamper

@StuartH Are you on edge?

StuartH

Only when my wife is near
no on nodebb 2.1

Schamper

@StuartH said:

Only when my wife is near
no on nodebb 2.1

Only edge is supported right now. I suppose you can do `npm install [email protected] to still get basic shoutbox functionality on your version.

julian

Hey @Mr_Waffle -- he's actually reasonably close to the edge builds. Let me grab the commit hash: 2654a8e

1 day old

Schamper

@julian said:

Hey @Mr_Waffle -- he's actually reasonably close to the edge builds. Let me grab the commit hash: 2654a8e

1 day old

Hm weird, that should work then... I'll put it on my list for things to check

xCausxn

Not working with lavender theme just letting people know

psychobunny

let me know what I got to do to fix that @Mr_Waffle

Schamper

works fine
Working fine for me.

bentael

@psychobunny said:

we need to ditch the
$(document).bind('DOMNodeInserted', function(event) {
p.s. I have no idea how badly that performs but I would imagine it sucks.

it does suck - but you should see this, i've used it before, works like a charm (minus IE8)
http://jsfiddle.net/PkYb9/2/

EDIT: time for a jsfiddle/jsbin embed plugin

psychobunny

haha well since you just said my codez suck your opinion is irrelevant

kidding

anyways ajaxify.onchange is the best solution to detect what page we're on, needs to be implemented, I'll make an issue

Schamper

0.0.4 has been published.
Global changelog:

Fixed user box, now actually shows the online users
Make usernames bold
Added setting in AdminCP for the placement of the shoutbox
Added action in AdminCP to prune shouts marked as deleted
Added action in AdminCP to delete all the shouts from the database
Archive button is now implemented (So you can look back at your highly intellectual shouts, like mine!)
Overall refactoring to make everything better
Admins can now delete everyone's shouts
Probably some other stuff I forgot

bentael

@Mr_Waffle +1

xCausxn

+1 good work mate

xCausxn

@Mr_Waffle Any way to put the shoutbox in the sidebar?

Schamper

@xCausxn Not yet. @psychobunny was talking about a 'widget' feature he's planning where plugins can be designated to from the AdminCP, so you'll have to wait for that. To keep max compatibility I'm only supporting top and bottom of the page now.

Schamper

@StuartH said:

@mr_waffle I have the shoutbox installed but it says I must be logged in to post but I am logged in!! I logged out then in, cleared cache, on nodebb 2.1, I can break anything

I think I know what the issue is with this. When it's taking too long to execute some piece of code (don't know which) that's responsible for logging you in, you'll appear as not being logged in (also in the header). The shoutbox then checks if you're logged in, and hoozah, you're not -> message is displayed. A page refresh often fixes this.