3.0.0 Bug Report Thread

DownPW

I had talked about bugs that was not taken into account. In fact, I use images for categories and I don't use icons on ACP :

--> Here is the result :

Since I don't use an icon, the text is shifted to the right and not centered. And since I use an image, it can interfere with the readability of the text.

The ideal would be to simply use the color of the background and text when there is no icon used while centering the text

-- The other thing I notice is when a label/thumbnail (img, gif) is used for a topic, it's display appears very large and isn't the same size as topics that don't have one.

That's a pretty rough result I think.

-- And the last things I see, that there are no icons for subcategories on the home page as on 2.X

2.X :

VS 3.X :

--> It may be a deliberate choice that is personally unfortunate. If that's the case, I know we can't please everyone, but maybe there's a code to keep them coming back? Or maybe add an option to display them or not ?

<baris>

@DownPW the issue with the category label is fixed in https://github.com/NodeBB/NodeBB/commit/28ed6c923c8839171fa25749a9f39680586b70d6, you can git pull on the develop branch to get the fix.

The topic thumbs are the same width as avatars on latest harmony too but you will have to switch to the vlad branch or just wait until we merge those changes into main. You can see it on this forum if you scroll down on https://community.nodebb.org/category/3/nodebb-development

No category icons is just a design decision for harmony.

DownPW

Thanks about the bugs resolved.

There is a code for category icons to be back ?

<baris>

To bring back icons for sub categories you need to add {buildCategoryIcon(@value, "24px", "rounded-circle")} at https://github.com/NodeBB/nodebb-theme-harmony/blob/main/templates/partials/categories/item.tpl#L23

DownPW

@baris add or replace ?

<div class="category-children row row-cols-2 g-2">
				{{{ each ./children }}}
				{{{ if !./isSection }}}
				<span class="category-children-item small">
					{{{ if ./link }}}{buildCategoryIcon(@value, "24px", "rounded-circle")}
					<a href="{./link}">{./name}</a>
					{{{ else }}}
					<a href="{config.relative_path}/category/{./slug}">{./name}</a>
					{{{ end }}}
				</span>
				{{{ end }}}
				{{{ end }}}
			</div>

<baris>

Add it before the {{{ if ./link }}} line

DownPW

Ok thanks my friend, I test it

<baris>

Pushed the latest version of harmony to this forum. Let us know if you notice any issues.

DownPW

Hello @baris

I just upgraded this morning and I see that. When a topic has a label it's no longer displayed on the left but on the right.
Instead we have the avatar of the creator of the topic.

The topic selector is now below the topic icon

--> I don't know if it's normal...

DownPW

@baris

-- Other bugs with Recent Card Widget and Font Awesome Pro loaded on custom header ACP, if you use a Pro version of Font Awesome that you use via the ACP/Custom Header like this :

<!-- Font Awesome 6 Pro -->
<link href="/assets/customfonts/FontAwesome-Pro-6.3/css/all.css" rel="stylesheet" />

--> The arrows in the Recend Card are not displayed correctly :

FrankM

@baris If I added this correctly, it doesn't work in my forum.

DownPW

-- There is something that bothers me a little in the topics @baris , in particular on the scroller container and the screen width used for reading.

In fact, very little space (screen width) is used for reading.
It would be a good idea to widen this space and shift the slider to gain a little bit.

We finally lose a considerable amount of reading space

phenomlab

@DownPW This should fix that

@media (min-width: 1200px) {
.page-topic .topic .posts {
    max-width: 1200px;
    width: 1200px;
  }
}

And

@media (min-width: 1400px) {
.container, .container-lg, .container-md, .container-sm, .container-xl, .container-xxl {
    max-width: 1320px;
  }
}

<baris>

@DownPW most of those are normal design changes to harmony, not sure about the fontawesome pro icons, but you can probably fix the position of the arrows via css.

@FrankM you screenshot looks to me. What's wrong?

@DownPW

In fact, very little space (screen width) is used for reading.

Actually reading text is easier when it is narrow, think about books/newspapers. If you want you can change it with css @phenomlab provided.

DownPW

Yep ok I'm sure for font awesome pro, if I don't use it, Recent card is ok

FrankM

@baris said in 3.0.0 Bug Report Thread:

To bring back icons for sub categories you need to add {buildCategoryIcon(@value, "24px", "rounded-circle")} at https://github.com/NodeBB/nodebb-theme-harmony/blob/main/templates/partials/categories/item.tpl#L23

I think i got the icons back in this view!?

julian

@FrankM If you updated the theme, then that change you made manually will have to be re-done.

<baris>

For anyone following, all the changes in the vlad branch are now merged into the main branch of harmony.

FrankM

@julian said in 3.0.0 Bug Report Thread:

@FrankM If you updated the theme, then that change you made manually will have to be re-done.

After upgrade my forum to rc2 i got this.

I thought the forum icons were supposed to be displayed there? Or am I understanding something wrong?

Sorry, english is not my main language

Thanks for rc2

DownPW

@baris

Maybe explain cli commands to update rc1 (devellop) to RC2 (main) correctly ?

Oups talk to fast

https://community.nodebb.org/topic/17105/nodebb-v3-0-0-rc-2-the-second-release-candidate