NodeBB v3.0.0-rc.2 — the second release candidate
-
Hi all!
If you've been browsing this forum in the past two weeks, you'll have noticed a couple of design changes.
Thanks for @baris and @vladstudio for working quite hard over the past few weeks to put the final polish on the Harmony theme
N.B. While this technically goes against the spirit of the "release candidate" being reserved for bug fixes, we were a little behind with the timeline and wanted to get these changes in for the upcoming v3.0.0.
Upgrade steps
If you wish to update to RC2, please run the following commands after having backed up your database:
./nodebb stop # or equivalent command to stop your NodeBB git fetch git checkout develop git reset --hard v3.0.0-rc.2 ./nodebb upgrade ./nodebb start # or equiv.
Bugs
If you encounter any bugs, please continue to report them to us by posting on the issue tracker, on the v3.0.0 bug report thread, or by replying to this topic.
-
@julian doesn't seem to work
I get the below
sudonix.dev@vps:~/nodebb$ git reset --hard origin/v3.0.0-rc.2 fatal: ambiguous argument 'origin/v3.0.0-rc.2': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]'
-
Nice. Seems nodebb 3.0 is near
Sadly I dont see any change on ios devices and ultra big layout from the betas keeps happening -
-
-
@sweetp said in NodeBB v3.0.0-rc.2 — the second release candidate:
.line-clamp-2
needs to be update with:
max-height: 2.5em
actually, they all need to be updated to multiples of 1.25 em, rather than multiples of 1.5em
@sweetp I had to make a change to this since it broke the max-height calculation on chat dropdowns. https://github.com/NodeBB/NodeBB/commit/fa633ec7ca287f4150f14c87209c7cb5cfb78f69
In some places we need 1.5 which is the
$line-height-base
and in some places we need 1.25 which isline-height-sm
. I added a new class line-clamp-sm-[1-6]. So instead of hardcoding themax-height
to1.25em * $lines
it will be calculated by using$line-height * $lines
.I pushed this change to this forum so let me know if you notice any issues.
-
@baris said in NodeBB v3.0.0-rc.2 — the second release candidate:
I pushed this change to this forum so let me know if you notice any issues.
It looks fine on my end,
I updated my test forum, and all looks well there too.
Ill push it to my production forum now