3.0.0 Bug Report Thread

FrankM

@baris If I added this correctly, it doesn't work in my forum.

DownPW

-- There is something that bothers me a little in the topics @baris , in particular on the scroller container and the screen width used for reading.

In fact, very little space (screen width) is used for reading.
It would be a good idea to widen this space and shift the slider to gain a little bit.

We finally lose a considerable amount of reading space

phenomlab

@DownPW This should fix that

@media (min-width: 1200px) {
.page-topic .topic .posts {
    max-width: 1200px;
    width: 1200px;
  }
}

And

@media (min-width: 1400px) {
.container, .container-lg, .container-md, .container-sm, .container-xl, .container-xxl {
    max-width: 1320px;
  }
}

<baris>

@DownPW most of those are normal design changes to harmony, not sure about the fontawesome pro icons, but you can probably fix the position of the arrows via css.

@FrankM you screenshot looks to me. What's wrong?

@DownPW

In fact, very little space (screen width) is used for reading.

Actually reading text is easier when it is narrow, think about books/newspapers. If you want you can change it with css @phenomlab provided.

DownPW

Yep ok I'm sure for font awesome pro, if I don't use it, Recent card is ok

FrankM

@baris said in 3.0.0 Bug Report Thread:

To bring back icons for sub categories you need to add {buildCategoryIcon(@value, "24px", "rounded-circle")} at https://github.com/NodeBB/nodebb-theme-harmony/blob/main/templates/partials/categories/item.tpl#L23

I think i got the icons back in this view!?

julian

@FrankM If you updated the theme, then that change you made manually will have to be re-done.

<baris>

For anyone following, all the changes in the vlad branch are now merged into the main branch of harmony.

FrankM

@julian said in 3.0.0 Bug Report Thread:

@FrankM If you updated the theme, then that change you made manually will have to be re-done.

After upgrade my forum to rc2 i got this.

I thought the forum icons were supposed to be displayed there? Or am I understanding something wrong?

Sorry, english is not my main language

Thanks for rc2

DownPW

@baris

Maybe explain cli commands to update rc1 (devellop) to RC2 (main) correctly ?

Oups talk to fast

NodeBB v3.0.0-rc.2 — the second release candidate

Hi all! If you've been browsing this forum in the past two weeks, you'll have noticed a couple of design changes. Thanks for @baris and @vladstudio for worki...

NodeBB Community (community.nodebb.org)

<baris>

@FrankM The default harmony design doesn't display the icons on the /categories page. If you want to bring them back you need to modify that template and add them.

Instructions here https://community.nodebb.org/post/92186

FrankM

Thanks. I will look into it

DownPW

Hello @baris

I see this in log with the last commits (upgrade today)

2023-04-15T11:48:47.857Z [4567/1334] - info: 📡 NodeBB is now listening on: 0.0.0.0:4567
2023-04-15T11:48:47.857Z [4567/1334] - info: 🔗 Canonical URL: http://192.168.1.54:4567
DEPRECATION WARNING on line 68, column 52 of ../../node_modules/bootswatch/dist/flatly/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
   ╷
68 │ $nav-link-padding-y:                .5rem !default !default;
   │                                                    ^^^^^^^^
   ╵

DEPRECATION WARNING on line 70, column 56 of ../../node_modules/bootswatch/dist/flatly/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
   ╷
70 │ $nav-link-disabled-color:           $gray-600 !default !default;
   │                                                        ^^^^^^^^
   ╵

DEPRECATION WARNING on line 79, column 60 of ../../node_modules/bootswatch/dist/litera/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
   ╷
79 │ $input-group-addon-bg:                  $gray-200 !default !default;
   │                                                            ^^^^^^^^
   ╵

WARNING: The keyword 'none' must be used as a single argument.
    ../../node_modules/bootstrap/scss/mixins/_box-shadow.scss 10:9   box-shadow()
    ../../node_modules/bootstrap/scss/forms/_form-control.scss 40:7  @import
    bootstrap/scss/_forms.scss 3:9                                   @import
    - 18:9                                                           root stylesheet

WARNING: The keyword 'none' must be used as a single argument.
    ../../node_modules/bootstrap/scss/mixins/_box-shadow.scss 10:9  box-shadow()
    ../../node_modules/bootstrap/scss/forms/_form-select.scss 31:7  @import
    bootstrap/scss/_forms.scss 4:9                                  @import
    - 18:9                                                          root stylesheet

DEPRECATION WARNING on line 62, column 208 of ../../node_modules/bootswatch/dist/solar/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
   ╷
62 │ $font-family-sans-serif:      "Source Sans Pro", -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol" !default !default;
   │                                                                                                                                                                                                                ^^^^^^^^
   ╵

DEPRECATION WARNING on line 116, column 63 of ../../node_modules/bootswatch/dist/solar/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
    ╷
116 │ $navbar-light-color:                rgba($black, .4) !default !default;
    │                                                               ^^^^^^^^
    ╵

DEPRECATION WARNING on line 117, column 63 of ../../node_modules/bootswatch/dist/solar/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
    ╷
117 │ $navbar-light-active-color:         rgba($black, .7) !default !default;
    │                                                               ^^^^^^^^
    ╵

phenomlab

@DownPW same here.

<baris>

It's reported here https://github.com/thomaspark/bootswatch/issues/1248

brazzerstop

After last upgrade (git pull) I see the blue page with 503 error ( excessive load warning) a very long time 2-3 mins when use ./nodebb restart and logs in ACP show this:

2023-04-16T15:28:14.633Z [4567/24243] - [32minfo[39m: 📡 NodeBB is now listening on: 0.0.0.0:4567
2023-04-16T15:28:14.634Z [4567/24243] - [32minfo[39m: 🔗 Canonical URL: https://site.com
WARNING: The keyword 'none' must be used as a single argument.
    node_modules/bootstrap/scss/mixins/_box-shadow.scss 10:9   box-shadow()
    node_modules/bootstrap/scss/forms/_form-control.scss 40:7  @import
    bootstrap/scss/_forms.scss 3:9                             @import
    - 18:9                                                     root stylesheet

WARNING: The keyword 'none' must be used as a single argument.
    node_modules/bootstrap/scss/mixins/_box-shadow.scss 10:9  box-shadow()
    node_modules/bootstrap/scss/forms/_form-select.scss 31:7  @import
    bootstrap/scss/_forms.scss 4:9                            @import
    - 18:9                                                    root stylesheet

julian

Sounds like your users are using custom skins and NodeBB is compiling the CSS on demand the first time it is run.

The error may be related, please report it on our GitHub repo

<baris>

Harmony builds all skins on restart, if you are using a single core server that will cause those 503 errors at startup. The warnings are related to latest version of node-saas and needs to be fixed in bootstrap/bootswatch

brazzerstop

I'm was remove last changes in library.js file and now don't have a Bootstrap warning and 503 error, 3-5 second after restart and forum is worked.

I mean this codes:
https://github.com/NodeBB/nodebb-theme-harmony/commit/6a8aa395d0a7e95726b3ced1ed48a0b1baa27650

<baris>

@brazzerstop https://github.com/NodeBB/NodeBB/commit/05c96033ab61ec7e2dc8d115b1504d26ecbbfd4b I made a change so the minifier doesn't run on the nodebb process, that might help with the startup responsiveness.