@pitaj said in Yet another error upon upgrade.:
npm install --global [email protected]
That worked. Thanks as always
Unsolved List of plugins that are incompatible when upgrading to version 1.19.2
-
@phenomlab can you confirm that everything but ASCII sequences replacement works:
- autocomplete
- dialog
- replacement of system emoji
- autocomplete
-
@PitaJ Confirmed. Only part not working is this
Replace common ASCII characters like :), -_-, etc
-
@PitaJ Confirmed too
-
We got emoji errors too. After rebuilding the plugin and then the forum, emojis came back, but ASCII characters are still not working... I carried the log errors here:
https://github.com/NodeBB/nodebb-plugin-emoji/issues/51
closed error after upgrading NodeBB 1.19.2 #51
-
The emoji error should be fixed in
[email protected] -
@baris Not working for me. Latest version installed.
-
What's not working? No emoji's at all or just
:)not turning into emojis?
seems to work here with just ascii characters. -
@baris Just ASCII characters not turning into emojis, like
:)for example which should be -
@baris said in List of plugins that are incompatible when upgrading to version 1.19.2:
The emoji error should be fixed in
[email protected]In the package the plugin is stored with version 3.5.9. Manually installing 3.5.12 did not solve the problem for me (
not turning into emojis) -
@baris Any update for this issue please ?
Thanks
-
No updates, we are using 3.5.12 on this forum and ascii characters are turning into emoji
-
@baris said in List of plugins that are incompatible when upgrading to version 1.19.2:
we are using 3.5.12 on this forum and ascii characters are turning into emoji
Hmm. Could be another plugin causing this issue, but seeing as there are several others with the same problem.....
-
@phenomlab can you try disabling other plugins and see if you can find one that causes the issue? It may also be that you need to place emoji higher on the plugin priority.
-
Yeah this was a combination of a change in the emoji plugin and plugin load order causing some issues. I t should be fixed in the latest emoji plugin (3.5.14) https://github.com/NodeBB/nodebb-plugin-emoji/issues/52
closed ASCII characters not turning into emojis #52
-
@baris Thanks. Confirmed working after upgrade, rebuild emoji assets, then rebuild and restart
-
Tested in two forums and works as expected. @baris Thanks!
-
@volanar What is the issue with canned-responses and gdpr? Those plugins don't really do much, and 1.19.2 didn't introduce any breaking changes
-
@julian said in List of plugins that are incompatible when upgrading to version 1.19.2:
@volanar What is the issue with canned-responses and gdpr? Those plugins don't really do much, and 1.19.2 didn't introduce any breaking changes
maybe he is talking about the log warnings...
we do not have a real problem with canned-responses , but we are getting this warning in the logs:2022-02-16T19:40:42.377Z [4569/53875] - [32minfo[39m: [build] admin control panel styles build completed in 13.753sec 2022-02-16T19:40:44.027Z [4569/53875] - [32minfo[39m: [build] languages build completed in 15.401sec [benchpress] warning: output bloat due to ambiguous inner BEGIN --> admin/plugins/canned-responses.tpl:44:17 | 44 | <!-- BEGIN responses --> | ^^^^^^^^^ `responses` could refer to the top-level value `responses` or the `.responses` property of the current element, so compiler must emit code for both cases | note: Migrate to modern syntax to avoid the ambiguity. This will become an error in the future. 2022-02-16T19:40:44.996Z [4569/53875] - [32minfo[39m: [build] requirejs modules build completed in 16.41sec 2022-02-16T19:40:45.295Z [4569/53875] - [32minfo[39m: [build] templates build completed in 16.669sec -
@julian
2022-02-09T22:06:38.702Z [4567/53991] - [31merror[39m: TypeError: Cannot read properties of undefined (reading 'require_consent')
at /var/www/nodebb/node_modules/nodebb-plugin-gdpr/library.js:113:32
at /var/www/nodebb/src/promisify.js:43:50
at processTicksAndRejections (node:internal/process/task_queues:83:21) -
@crazycells yes
