Updating to 1.3.0 - Issues

yariplus

@julian said in Updating to 1.3.0 - Issues:

@yariplus said in Updating to 1.3.0 - Issues:

I can fix it, but I would use a different approach then what the plugin currently uses.

What's your solution? Haven't taken a look at the plugin yet to see what's wrong... in fact, when I did try it out, it seemed to work fine on latest master :shipit:

I changed it so that it writes templates to it's own directory, and compiles them from there. Removes the hotswap stuff, and doesn't depend on nodebb's own templates directory being available.

GitHub - yariplus/nodebb-plugin-custom-pages

Contribute to yariplus/nodebb-plugin-custom-pages development by creating an account on GitHub.

GitHub (github.com)

evoixmr

@yariplus I just tested it. Your version is showing 3.2 current version is 3.3.

It' currently does not work, error message - you seem to have stumbled upon a page that does not exist. Return to the home page.

3.3 is custom page, route is setup like:
mywebsite/newroute

Yours is setup like:
mywebsite/custom-pages/newroute

yariplus

@evoixmr said in Updating to 1.3.0 - Issues:

@yariplus I just tested it. Your version is showing 3.2 current version is 3.3.

Blame @psychobunny

It' currently does not work, error message - you seem to have stumbled upon a page that does not exist. Return to the home page.

3.3 is custom page, route is setup like:
mywebsite/newroute

Yours is setup like:
mywebsite/custom-pages/newroute

The routes are exactly the same, I only changed the location of the templates. Did you install using npm? It probably ignored the empty directory. The directory templates/custom-pages should exist in the plugin folder.

evoixmr

@yariplus yes I installed by: npm install https://github.com/yariplus/nodebb-plugin-custom-pages.git

Do I need to empty the draft zone before I install? the only thing I can think of is I did not stop nodebb before installing.

yariplus

is there a templates/custom-pages directory in the plugin folder?

evoixmr

@yariplus no the directory was not created.

yariplus

create the directory and restart nodebb, it should make the templates.

julian

@yariplus The hotswap stuff was added so the routes can be available without a NodeBB restart... I'm not entirely sure removing it was the right course of action

Also, if you guys are using latest, you probably need to ./nodebb build...

SuperMike

@Jenkler said in Updating to 1.3.0 - Issues:

Any know issues with 1.3.0 from 1.2.x, is it safe to update!

Tell me about your issues

Everything goes well

evoixmr

@yariplus I created the directtory /templates/custom-pages under but as soon as I restarted it deleted everything under templates/ and the directory was not recreated.

yariplus

@evoixmr I mean /node_modules/nodebb-plugin-custom-pages/templates/custom-pages/

evoixmr

@yariplus error message

Internal Error.

Oops! Looks like something went wrong!

/newroute

Failed to lookup view "custom-pages/newroute" in views directory "/home/nodebb/public/templates"

yariplus

Yeah, idk. My version was just an experiment really. Are you on the master branch? The regular version seems to work on master.

evoixmr

@yariplus No I'm not on master. I'll try it out on master later.

julian

Thanks @evoixmr -- I did notice myself on another install that it didn't work on v1.x.x branch, but it might work on master again, so a small blip where it stopped working

Mikael Jenkler

Is the goal here to get the regular version work on v1.x.x branch? Is that possible without a workaround?

evoixmr

@yariplus It did not work on master, same error.
Internal Error.

Oops! Looks like something went wrong!

/testroute

Failed to lookup view "custom-pages/testroute" in views directory "/home/****/nodebb/public/templates"

evoixmr

@julian you're welcome, by the way I notice that reload forum is back on master.

[email protected] is working fine on master.

julian

@evoixmr I meant the existing version of custom-pages should work on master again...

In any case, @yariplus has some interesting ideas so if it pans out, then we'll go with his version and merge it into the published version.

evoixmr

@julian the version of @psychobunny work on master. The version of @yariplus have the same error on master and v1.3.0.