Bookmarks / Favourites breaking change 1.2

NodeBB Development

Suggested Topics


  • 3 Votes
    2 Posts
    454 Views

    I've been noticing some UI issues every time a user logs in or out.
    Basically right after you log in, some of the styles do not get picked up (i.e. logo becomes larger, recent-topic cards stop displaying content). Refreshing the page fixes the issue but this is not ideal.

  • 0 Votes
    3 Posts
    1k Views

    we are looking to make it so that the Moderators can add Categories and do not want to give them full admin permissions.

  • 0 Votes
    6 Posts
    3k Views

    @julian Thanks!

  • 5 Votes
    1 Posts
    1k Views

    Related issue https://github.com/NodeBB/NodeBB/issues/4587

    As discussed in the issue, we had a bunch of hooks to modify a page on some routes like filter:recent.build. These were added as required but most pages didn't have a hook so if you needed one you would have to ask us to add it and wait for the next release. With the above change every route has a hook. The hook name is derived from the template name passed to the res.render(template, data); method. For example if your template is named myAwesomePage, you render it with res.render('myAwesomePage', data); and the hook that will be fired is filter:myAwesomePage.build

    Every hook gets 3 parameters {req: req, res: res, templateData: data}, data is the parameter you pass into the res.render method.

    We had a few inconsistencies in the parameters passed to the hook and the hook name below are the changes that needs to be fixed if you have a plugin that is listening to these hooks.

    filter:groups.build is now called filter:group/details.build as that is the correct name for that template. filter:popular.build used to pass in a extra term parameter, this moved into the templateData parameter. filter:header.build this is removed it was deprecated a while ago. Use filter:navigation.available instead. filter:search.build parameters changed, data is no longer passed in use req.query and req.params instead. results is now the templateData parameter.

    Feel free to ask any questions if anything isn't clear.

  • 1 Votes
    2 Posts
    2k Views

    I'm unsure if I'm seeing a regression or an undocumented? change here.

    I'm currently getting:

    TypeError: undefined is not a function
    at /mnt/Extra/home/dbolack/Projects/nodebb-plugin-rscloudfiles/index.js:203:4

    Which maps to:

    callback(null, { url: rsCloudFilesCDNSecure + '/' + image.name, name: image.name || '' });

    Which is equivalent to the current imgur plugins bit:

    callback(null, { url: data.link.replace('http:', 'https:'), name: image.name || '' });

    Any ideas?