I've been working on a solution to this:
https://github.com/NodeBB/NodeBB/issues/3128

It's probably our biggest user complaint right now. We've been bikeshedding back home, and I think it's ready to run it by the larger NodeBB community for some feedback.

It changes the current design of two states to three, adding a new state called "Ignoring." And so, instead of toggling with buttons, I've turned it into a dropdown, which has the added benefit of displaying the current state, not the opposite state of the thread:

In addition to not showing up in the unread feed, ignoring a thread keeps the unread styling from applying to the thread in other lists (e.g., recent, categories).

exomarty created this issue in NodeBB/NodeBB

closed Unread section #3128

We've been self hosting the open source iframely version. Very simple and doesn't seem to require much server load.

I figured out how to make this happen:

https://github.com/boomzillawtf/nodebb-plugin-upvote-notifications

What I had to do:

• Dev Dependencies:
  • bcryptjs ~2.3.0
  • nconf ~0.8.2
  • npm link nodebb as a module for my plugin
  • Put bcrypt.js from the nodebb root directory into the root directory for my plugin (for user password hashing when creating users in the tests)
• Plugin set up to optionally accept nodebb modules from the test code instead of normal module.parent.require method.

@exodo said in Ignoring individual threads:

Actually unread shows topics from categories you follow. not topics.

Umm....topics, yeah. Following or ignoring a whole category is useful, but also does not give the user enough fine control over what he wants to not see.

@exodo said in Ignoring individual threads:

Following a topic is only used for notifications i think.

That's correct and I haven't changed it.

@exodo said in Ignoring individual threads:

I think unread section is useless,

I know a lot of people who disagree. I use it pretty much exclusively.

@exodo said in Ignoring individual threads:

no one uses it the way it works now but i dont have good ideas to solve it.

We have other issues with it (mainly that you can't tell a new topic from one that you've already seen but has new activity), but I can assure you a lot of people use it.

Scrolling through large topics generates a lot of activity in my browser history. I'd really like to be able to make that not happen. Looking at the code, I found evidence that this is possibly supported:

https://github.com/NodeBB/NodeBB/blob/9361ff07729bb6524752079fb5b4feb173d7d458/public/src/ajaxify.js#L101

...but I can't find any setting in my profile or in the admin controls to change this.

The way that NodeBB's responsive design works has irritated some of our users, so we came up with a plugin to allow users to effectively disable it.

The biggest complaint was getting the small / mobile composer view when the browser's window went below ~1000px.

Re: Upvote notification tweaks

Looks like this isn't making the cut for core, but it can be done as a plugin:

https://github.com/boomzillawtf/nodebb-plugin-upvote-notifications

Has anyone run into problems with reply links going bad?

The issue is that they use the post index, which can change for at least a few reasons:

• Users sort by different criteria
• Topic is forked
• Post is moved (for some reason, this is different than forking)

Updated to v0.1.1, should work on that old FF now.

It seems that only administrators have access to the flags interface in the admin section. But <del>they</del><ins>global moderators</ins> get notifications for flagged posts.

Is there a way to let them in to the flags interface?

This was reported:
https://github.com/boomzillawtf/nodebb-plugin-youtube-embed/issues/9

I can't reproduce, but the report says they get an error when navigating to the settings in the admin area (NodeBB 1.7.5, youtube-embed v0.6.7). Does anyone have an idea about what's going on here?

Unable to load template: admin/plugins/youtube-lite
(anonymous) @ ajaxify.js:333
(anonymous) @ require.js:7
(anonymous) @ require.js:23
y @ require.js:6
emit @ require.js:23
(anonymous) @ require.js:11
y @ require.js:6
v @ require.js:11
onScriptError @ require.js:30
require.js:7 Uncaught Error: Script error for "/assets/templates/admin/plugins/youtube-lite.js"
http://requirejs.org/docs/errors.html#scripterror
    at F (require.js:7)
    at HTMLScriptElement.onScriptError (require.js:30)
F @ require.js:7
onScriptError @ require.js:30
ajaxify.js:333 Unable to load template: admin/plugins/youtube-lite
(anonymous) @ ajaxify.js:333
(anonymous) @ require.js:7
(anonymous) @ require.js:23
y @ require.js:6
emit @ require.js:23
w @ require.js:12
(anonymous) @ require.js:12
y @ require.js:6
w @ require.js:12
(anonymous) @ require.js:13
y @ require.js:6
C @ require.js:13
(anonymous) @ require.js:13
setTimeout (async)
C @ require.js:13
(anonymous) @ require.js:13
setTimeout (async)
C @ require.js:13
(anonymous) @ require.js:13
setTimeout (async)
C @ require.js:13
(anonymous) @ require.js:13
setTimeout (async)
C @ require.js:13
(anonymous) @ require.js:13
setTimeout (async)
C @ require.js:13
(anonymous) @ require.js:13
setTimeout (async)
C @ require.js:13
(anonymous) @ require.js:13
setTimeout (async)
C @ require.js:13
(anonymous) @ require.js:13
setTimeout (async)
C @ require.js:13
(anonymous) @ require.js:13
setTimeout (async)
C @ require.js:13
(anonymous) @ require.js:13
setTimeout (async)
C @ require.js:13
(anonymous) @ require.js:13
setTimeout (async)
C @ require.js:13
(anonymous) @ require.js:13
setTimeout (async)
C @ require.js:13
(anonymous) @ require.js:13
setTimeout (async)
C @ require.js:13
(anonymous) @ require.js:26
setTimeout (async)
g.nextTick @ require.js:32
a @ require.js:26
requirejs @ require.js:32
ajaxify.loadTemplate @ ajaxify.js:332
(anonymous) @ benchpress.js:163
a @ benchpress.js:162
(anonymous) @ benchpress.js:184
(anonymous) @ benchpress.js:77
e @ benchpress.js:76
l @ benchpress.js:183
e @ benchpress.js:222
d @ ajaxify.js:185
(anonymous) @ ajaxify.js:98
success @ ajaxify.js:317
l @ jquery.js:3268
fireWith @ jquery.js:3398
c @ jquery.js:9305
(anonymous) @ jquery.js:9548
XMLHttpRequest.send (async)
(anonymous) @ VM7656:1
send @ jquery.js:9600
ajax @ jquery.js:9206
ajaxify.loadData @ ajaxify.js:291
ajaxify.go @ ajaxify.js:86
n @ ajaxify.js:362
(anonymous) @ ajaxify.js:413
dispatch @ jquery.js:5183
g.handle @ jquery.js:4991
require.js:7 Uncaught Error: Script error for "/assets/templates/admin/plugins/youtube-lite.js"
http://requirejs.org/docs/errors.html#scripterror
    at F (require.js:7)
    at HTMLScriptElement.onScriptError (require.js:30)

StrangerPings created this issue in boomzillawtf/nodebb-plugin-youtube-embed

open Will not load the plugin settings in the admin. #9

@baris said in Bookmarks / Favourites breaking change 1.2:

Actually we do breaking changes in minor releases and not patch releases, so we don't really follow semver in that regard.

Ah, fair enough.

@pichalite said in Bookmarks / Favourites breaking change 1.2:

Also 1.3 is not released yet.

I know. But it seems like an awful way to run a railroad if you break people's plugins without advance notice, which I don't think is covered by a tag on a github issue.

Recently, a breaking change (1.2 -> 1.3) was introduced:

https://github.com/NodeBB/NodeBB/issues/5096

I didn't see any sort of announcement or warning about this (though admittedly I wasn't watching terribly closely). Was there a public discussion about this? I'm curious as to why you guys introduced this breaking change in a minor release.

Thanks.

barisusakli created this issue in NodeBB/NodeBB

closed refactor src/favourites.js #5096

Here's a thing. Had a nodebb process pegging the CPU and ran the perf tool against it. It collected 2,967 identical stacks:

node 29869 cpu-clock: 
            3288d1761413 LazyCompile:~ /usr/src/app/node_modules/nodebb-plugin-mentions/library.js:165 (/tmp/perf-29869.map)
            3288d1772468 LazyCompile:~ /usr/src/app/node_modules/nodebb-plugin-mentions/library.js:239 (/tmp/perf-29869.map)
            3288d1770e25 LazyCompile:~ /usr/src/app/node_modules/nodebb-plugin-mentions/library.js:209 (/tmp/perf-29869.map)
            3288d135f1f9 LazyCompile:~ /usr/src/app/src/database/mongo/sorted.js:341 (/tmp/perf-29869.map)
            3288d179b3fa LazyCompile:* /usr/src/app/src/topics/unread.js:340 (/tmp/perf-29869.map)
            3288d15bd907 LazyCompile:*readableAddChunk _stream_readable.js:124 (/tmp/perf-29869.map)
            3288d13e12ce LazyCompile:*Readable.push _stream_readable.js:100 (/tmp/perf-29869.map)
            7f52c6fdbb45 init_cacheinfo (/lib/x86_64-linux-gnu/libc-2.19.so)

So now the mentions plugin is suspect #1. cc: @julianlam

@torn2 iFramely has some problems with preview. If you put something in there and then start typing, you basically spam whatever server. Users really hated that, so at least for youtube we went with this.

Re: [nodebb-plugin-youtube-lite] Server side modifications

I forked nodebb-plugin-youtube-lite with my enhancements.

We're running our instance with --perf-basic-prof-only-functions now and are able to generate flamegraphs. Just waiting for the servercooties to strike now...

Example flamegraph:

@torn2 Not to my knowledge. It works just like using their service except it all happens on your server (or servers, if you put it on a separate machine).

We see similar issues. Sometimes we have to restart many times per day, some days it will keep going. we've been tracking it here:

• https://what.thedailywtf.com/topic/19990/the-official-server-cooties-tracking-thread

We're running stuff under docker, which makes things more complicated, but I've had luck in a local dev/test environment with using Linux perf tools and building flamegraphs. For raisins, we haven't done this yet in docker, though you can see how to make that work here.

However, if you're not running docker, it's a little bit easier. Follow the instructions here:

• https://yunong.io/2015/11/23/generating-node-js-flame-graphs/

He doesn't go into it there, but if you're on Ubuntu you'll need to install:

• linux-tools-common
• linux-cloud-tools-common

...and then kernel specific versions of those based on what you're running in order to use perf.

If you get there before we do, I'm eager to hear what anyone discovers with this.

@a_5mith are you still there? Maybe it's time to fork...