[nodebb-plugin-emoji-extended] Emoji Extended (reworked)
-
Here's an interesting bit of behavior
- Upgraded to 0.9.4.
- Removed dependency from package.json
- NPM i nodebb-plugin-emoji-extended@latest
- Installed nodebb-plugin-emoji-apple
-
@ThingBreaker
Are the emoji working within posts/previews? If not, check your config.json for theurl
property.
I'm not sure why the translations ofmodal.title
andmodal.legal
are not working, will take a look at that. -
@frissdiegurke It looks like the URL was malformed and after correcting it, emojis are back up and running.
-
@ThingBreaker And as to the translations it seems the
defaultLang
support ofv0.9.x
is failing.
Since it's a minor0.9.x
issue and I'm supporting^1.0.0
only, it's not gonna be fixed from my side. Maybe the @administrators want to merge the fix ofdefaultLang
into0.9.x
, but I wouldn't bet on this . I guess it's something one can live with until next major NodeBB release. -
Does it work with proxied nodebb? I tried to use it but the images are called with url http://localhost:4567
-
@ngadmin Please check your config.json for the
url
property. -
just did a custom set using gifs instead of svg for my forum so i share it here
-
@exodo great job
A few things I noticed (just checked the code; not tested. Might be wrong at some point):
- You did not replace/remove the mappings, so there are mappings like
:-?
that point toconfused
when there is no such image. - You should change the content of public/static/styles/[email,main].css instead of the .less files since only the css files get read. There is no less parsing at runtime.
- "inet" is a pretty bad-to-search name o_O it would be great to have a link within the attribution if there is any
- please put your own set ID here, this could cause some problems with cubicopp being installed in parallel otherwise.
- tiny typo
Since you've deactivated issues for that repo, I post the list here
Feel free to tell me about any issues you came across so we might decrease the barrier of publishing new sets. I guess I should somewhere provide a copy of cubicopp without the necessity of grunt.
- You did not replace/remove the mappings, so there are mappings like
-
@frissdiegurke said:
@exodo great job
A few things I noticed (just checked the code; not tested. Might be wrong at some point):
- You did not replace/remove the mappings, so there are mappings like
:-?
that point toconfused
when there is no such image. - You should change the content of public/static/styles/[email,main].css instead of the .less files since only the css files get read. There is no less parsing at runtime.
- "inet" is a pretty bad-to-search name o_O it would be great to have a link within the attribution if there is any
- please put your own set ID here, this could cause some problems with cubicopp being installed in parallel otherwise.
- tiny typo
Since you've deactivated issues for that repo, I post the list here
Feel free to tell me about any issues you came across so we might decrease the barrier of publishing new sets. I guess I should somewhere provide a copy of cubicopp without the necessity of grunt.
thanks i will check all that, it was a little tricky to remove all references from cubicopp but i have both working ok at same time
- You did not replace/remove the mappings, so there are mappings like
-
@exodo said:
@frissdiegurke said:
- please put your own set ID here, this could cause some problems with cubicopp being installed in parallel otherwise.
thanks i will check all that, it was a little tricky to remove all references from cubicopp but i have both working ok at same time
Strange o_O it shouldn't work in theory xD I save them in an object identified by their ID so one should overwrite the previous one and thus the overwritten one shouldn't be used during parse...
-
- If I remember correctly you can avoid all those
{"category": "aaexodo"}
entries with a subdirectory namedaaexodo
; I should probably apply this for cubicopp as well xD
- If I remember correctly you can avoid all those
-
@frissdiegurke said in [nodebb-plugin-emoji-extended] Emoji Extended (reworked):
@exodo great job
A few things I noticed (just checked the code; not tested. Might be wrong at some point):
- You did not replace/remove the mappings, so there are mappings like
:-?
that point toconfused
when there is no such image. - You should change the content of public/static/styles/[email,main].css instead of the .less files since only the css files get read. There is no less parsing at runtime.
- "inet" is a pretty bad-to-search name o_O it would be great to have a link within the attribution if there is any
- please put your own set ID here, this could cause some problems with cubicopp being installed in parallel otherwise.
- tiny typo
Since you've deactivated issues for that repo, I post the list here
Feel free to tell me about any issues you came across so we might decrease the barrier of publishing new sets. I guess I should somewhere provide a copy of cubicopp without the necessity of grunt.
updated all this but i didnt understand point 2, cubicopp code has less files too
- You did not replace/remove the mappings, so there are mappings like
-
@exodo said in [nodebb-plugin-emoji-extended] Emoji Extended (reworked):
@frissdiegurke said in [nodebb-plugin-emoji-extended] Emoji Extended (reworked):
@exodo great job
A few things I noticed (just checked the code; not tested. Might be wrong at some point):
- You did not replace/remove the mappings, so there are mappings like
:-?
that point toconfused
when there is no such image. - You should change the content of public/static/styles/[email,main].css instead of the .less files since only the css files get read. There is no less parsing at runtime.
- "inet" is a pretty bad-to-search name o_O it would be great to have a link within the attribution if there is any
- please put your own set ID here, this could cause some problems with cubicopp being installed in parallel otherwise.
- tiny typo
Since you've deactivated issues for that repo, I post the list here
Feel free to tell me about any issues you came across so we might decrease the barrier of publishing new sets. I guess I should somewhere provide a copy of cubicopp without the necessity of grunt.
updated all this but i didnt understand point 2, cubicopp code has less files too
Not within the published module, the less files get compiled into css files before publishing via grunt.
- You did not replace/remove the mappings, so there are mappings like
-
@frissdiegurke i just forked cubi plugin
-
@frissdiegurke Hmm... so it won't work if repo is cloned using
git clone
unless you compile the less files yourself. -
@pichalite said in [nodebb-plugin-emoji-extended] Emoji Extended (reworked):
@frissdiegurke Hmm... so it won't work if repo is cloned using
git clone
unless you compile the less files yourself.Yes. Repositories should be used for source code only (at least this is my understanding of best practice) Everything else belongs into package manager scope or release files.
-
@frissdiegurke said in [nodebb-plugin-emoji-extended] Emoji Extended (reworked):
@pichalite said in [nodebb-plugin-emoji-extended] Emoji Extended (reworked):
@frissdiegurke Hmm... so it won't work if repo is cloned using
git clone
unless you compile the less files yourself.Yes. Repositories should be used for source code only (at least this is my understanding of best practice) Everything else belongs into package manager scope or release files.
in my opinion source and npm should be same files but iยดm just amateur so..
don't understand why css over less anyways
i have limited time so i just publish git repos to npm through circleCI to keep them updated -
i wanted to create a new emoji set but instructions are very scarce on how to set up nodebb-grunt et al.
could you give me a quick rundown on what i need to do @frissdiegurke ? -
@leovoel For the creation of a set you don't need to use nodebb-grunt. Just for development on existing packages maintained by me.
You just need to call the register function of emoji-extended; See https://github.com/NodeBB-Community/nodebb-plugin-emoji-extended/blob/master/sets/README.md for details.If you still want to use nodebb-grunt I've talked a bit about the setup with @rbeer here.