[nodebb-plugin-emoji-extended] Emoji Extended (reworked)
-
- If I remember correctly you can avoid all those
{"category": "aaexodo"}entries with a subdirectory namedaaexodo; I should probably apply this for cubicopp as well xD
- If I remember correctly you can avoid all those
-
@frissdiegurke said in [nodebb-plugin-emoji-extended] Emoji Extended (reworked):
@exodo great job
A few things I noticed (just checked the code; not tested. Might be wrong at some point):
- You did not replace/remove the mappings, so there are mappings like
:-?that point toconfusedwhen there is no such image. - You should change the content of public/static/styles/[email,main].css instead of the .less files since only the css files get read. There is no less parsing at runtime.
- "inet" is a pretty bad-to-search name o_O it would be great to have a link within the attribution if there is any
- please put your own set ID here, this could cause some problems with cubicopp being installed in parallel otherwise.
- tiny typo
Since you've deactivated issues for that repo, I post the list here
Feel free to tell me about any issues you came across so we might decrease the barrier of publishing new sets. I guess I should somewhere provide a copy of cubicopp without the necessity of grunt.
updated all this but i didnt understand point 2, cubicopp code has less files too
- You did not replace/remove the mappings, so there are mappings like
-
@exodo said in [nodebb-plugin-emoji-extended] Emoji Extended (reworked):
@frissdiegurke said in [nodebb-plugin-emoji-extended] Emoji Extended (reworked):
@exodo great job
A few things I noticed (just checked the code; not tested. Might be wrong at some point):
- You did not replace/remove the mappings, so there are mappings like
:-?that point toconfusedwhen there is no such image. - You should change the content of public/static/styles/[email,main].css instead of the .less files since only the css files get read. There is no less parsing at runtime.
- "inet" is a pretty bad-to-search name o_O it would be great to have a link within the attribution if there is any
- please put your own set ID here, this could cause some problems with cubicopp being installed in parallel otherwise.
- tiny typo
Since you've deactivated issues for that repo, I post the list here
Feel free to tell me about any issues you came across so we might decrease the barrier of publishing new sets. I guess I should somewhere provide a copy of cubicopp without the necessity of grunt.
updated all this but i didnt understand point 2, cubicopp code has less files too
Not within the published module, the less files get compiled into css files before publishing via grunt.
- You did not replace/remove the mappings, so there are mappings like
-
@frissdiegurke i just forked cubi plugin
-
@frissdiegurke Hmm... so it won't work if repo is cloned using
git cloneunless you compile the less files yourself. -
@pichalite said in [nodebb-plugin-emoji-extended] Emoji Extended (reworked):
@frissdiegurke Hmm... so it won't work if repo is cloned using
git cloneunless you compile the less files yourself.Yes. Repositories should be used for source code only (at least this is my understanding of best practice)
Everything else belongs into package manager scope or release files. -
@frissdiegurke said in [nodebb-plugin-emoji-extended] Emoji Extended (reworked):
@pichalite said in [nodebb-plugin-emoji-extended] Emoji Extended (reworked):
@frissdiegurke Hmm... so it won't work if repo is cloned using
git cloneunless you compile the less files yourself.Yes. Repositories should be used for source code only (at least this is my understanding of best practice)
Everything else belongs into package manager scope or release files.in my opinion source and npm should be same files but iยดm just amateur so..
don't understand why css over less anyways
i have limited time so i just publish git repos to npm through circleCI to keep them updated -
@leovoel For the creation of a set you don't need to use nodebb-grunt. Just for development on existing packages maintained by me.
You just need to call the register function of emoji-extended; See https://github.com/NodeBB-Community/nodebb-plugin-emoji-extended/blob/master/sets/README.md for details.If you still want to use nodebb-grunt I've talked a bit about the setup with @rbeer here.
-
i made a set for twitter's twemoji
GitHub - leovoel/nodebb-plugin-emoji-twemoji: Twitter emoji set for NodeBB.
Twitter emoji set for NodeBB. Contribute to leovoel/nodebb-plugin-emoji-twemoji development by creating an account on GitHub.
GitHub (github.com)
working okay here on two installs, but feel free to point out any problems if you hit any
-
hi,
I want to keep the same order as http://emojione.com/. The Emoji & Also categories should be order from Top used to less used.
Could we re-order it on plugin dashboard?
-
