This is the reason...
NOW
Image Credit: @phenomlab 😉
unknownjjj.png
Absolutely brilliant @baris, the difference is clear 👍
PREVIOUSLY
Screenshot_2021-05-10 TalkCounty com(3).png
PLUGIN+THEME WEEKEND V4
-
Welcome to the fourth edition of NodeBB Plugin Weekends.
Previous Weekends: Three, Two, One
This weekend onwards, we're extending it to also include Themes! So designers won't be left out of the loop either
As per usual, the NodeBB core developers (@psychobunny, @baris, and myself (@julian)) have Saturday and Sunday to create plugins and/or themes from scratch. Any plugin/theme created by any other member of the community starting February 3rd will also be considered.
- In order for the plugin/theme to count, it must be npm published and installable by Monday Midnight (or Sunday 11:59, for you pedants).
- Bonus points for creativity
- Upgrades to existing plugins/themes also count, though they have to be fairly substantial.
Prize
$25 CAD from the NodeBB Team
Entries
- @frissdiegurke: emoji-extended, livereload, dark-rectangles
- @julian: dwnvtr
- @baris: imgur
- @xCausxn: vanquish
- @psychobunny: pewter
Voting
The winner will be decided based on whichever plugin has accumulated the most upvotes. We'll be using the honour system here, so while it is possible for you to downvote your competitors' plugins, or create fake accounts to upvote yours, we'd really appreciate it if you didn't do that.
Let the Games Begin!
Sponsorships
Interested in sponsoring a plugin weekend? Contact us
-
My entry this weekend:
nodebb-plugin-dwnvtr
Punish trolls by making their posts fade 20% for each downvote!
-
Hoho the gauntlet has been thrown. Prepare to get owned this weekend.
Lets make this more interesting - how about a side bet @julian? If I don't win plugin weekend I'll drop $50 on the winner in addition to the prize (What is the prize? Same as last time?)
-
Hahaha, you're on. We'll have to actually have a formal vote tally this time though
Prize not decided yet, although a small monetary prize like the 2nd weekend would work.
-
Without knowing this was on, I was going to build a plugin for storing uploads in S3 (or other cloud storage) rather than locally on the machine's storage. However, it looks like in order for me to do that, I'd need to change the internals of NodeBB a bit heavily..
-
Adding a hook into https://github.com/designcreateplay/NodeBB/blob/master/src/posts.js#L397 should allow upload plugins to do their thing. Let me add that.
-
Awesome, but it's anywhere that files are written by NodeBB from uploads, so there's more places:
- https://github.com/designcreateplay/NodeBB/blob/master/src/routes/user.js#L101
- https://github.com/designcreateplay/NodeBB/blob/master/src/routes/admin.js#L172
[update]
This is something that we'd be doing for Kano's nodebb, http://talk.kano.me, if it couldn't be a plugin (which is ideal) then I'd have just forked the project, which is easy enough.
-
Yeah it should ideally be a plugin. imgur uploads should be moved to a plugin too. https://github.com/designcreateplay/NodeBB/issues/563. I will add the hook and move out imgur to a plugin.
closed Saving uploaded images to disk vs Imgur #563
-
Also realized that the other places always upload to local, and they are getting the image from a form upload whereas the image uploads for posts are done with base64 image strings.
-
Nice! A new challenger appears...
-
@julian as it's 2am over here, I'm going to have to call it a night, but I'll be working on this in the next few days.
-
@miksago Looking forward to seeing what you come up with
I'm sure we can bend the rules a little bit for non-core devs -
@julian I don't think I'll be entering any more, but you are getting a nice performance PR from me (feeds optimisation)
-
@bentael will like that too, he can remove the instructions in his importer plugin to comment out the feed stuff.
-
Aah I need to come up with some ideas for the next weekends! New semester starts so I'll have a bit more time on my hands (though I also have 2 jobs to work on soon).
-
here's my submission: http://community.nodebb.org/topic/760/pewter-theme
gogo vote me so I can beat @julian
-
did I win?
Let's do a legit one sometime where the core dev's don't get to play. So that @mr_waffle can win again apparently
-
Ahahahah, yeah looks like you're the clear winner. When does voting end?
