PLUGIN+THEME WEEKEND V4

<baris>

Adding a hook into https://github.com/designcreateplay/NodeBB/blob/master/src/posts.js#L397 should allow upload plugins to do their thing. Let me add that.

miksago

Awesome, but it's anywhere that files are written by NodeBB from uploads, so there's more places:

[update]

This is something that we'd be doing for Kano's nodebb, http://talk.kano.me, if it couldn't be a plugin (which is ideal) then I'd have just forked the project, which is easy enough.

<baris>

Yeah it should ideally be a plugin. imgur uploads should be moved to a plugin too. https://github.com/designcreateplay/NodeBB/issues/563. I will add the hook and move out imgur to a plugin.

<baris>

Also realized that the other places always upload to local, and they are getting the image from a form upload whereas the image uploads for posts are done with base64 image strings.

julian

Nice! A new challenger appears...

miksago

@julian as it's 2am over here, I'm going to have to call it a night, but I'll be working on this in the next few days.

julian

@miksago Looking forward to seeing what you come up with I'm sure we can bend the rules a little bit for non-core devs

miksago

@julian I don't think I'll be entering any more, but you are getting a nice performance PR from me (feeds optimisation)

<baris>

@bentael will like that too, he can remove the instructions in his importer plugin to comment out the feed stuff.

Schamper

Aah I need to come up with some ideas for the next weekends! New semester starts so I'll have a bit more time on my hands (though I also have 2 jobs to work on soon).

psychobunny

here's my submission: http://community.nodebb.org/topic/760/pewter-theme

gogo vote me so I can beat @julian

psychobunny

did I win?

Let's do a legit one sometime where the core dev's don't get to play. So that @mr_waffle can win again apparently

julian

Ahahahah, yeah looks like you're the clear winner. When does voting end?