Group Chat Changes

Robert

@baris And the "room owner" is defined by the person who first adds people to a chat I assume?

<baris>

@Kowlin Yes the first person to start the room is the owner.

hek

I've just experienced a series of rapid restarts on 0.9.3 (cf5decf5de6f3b1e0690d2c4deab1565c21989ef) with a similar exception as mentioned above.

Jan 28 17:24:52 www msforum[17939]: 28/1 17:24 [7158] - #033[31merror#033[39m: TypeError: Cannot read property 'messageId' of undefined
Jan 28 17:24:52 www msforum[17939]: at processImmediate [as _immediateCallback] (timers.js:383:17)
Jan 28 17:24:52 www msforum[17939]: TypeError: Cannot read property 'messageId' of undefined
Jan 28 17:24:52 www msforum[17939]: at processImmediate [as _immediateCallback] (timers.js:383:17)
Jan 28 17:24:52 www msforum[17939]: 28/1 17:24 [7158] - #033[32minfo#033[39m: [app] Shutdown (SIGTERM/SIGINT) Initialised.
Jan 28 17:24:52 www msforum[17939]: 28/1 17:24 [7158] - #033[32minfo#033[39m: [app] Database connection closed.
Jan 28 17:24:52 www msforum[17939]: 28/1 17:24 [7158] - #033[32minfo#033[39m: [app] Web server closed to connections.
Jan 28 17:24:52 www msforum[17939]: 28/1 17:24 [7158] - #033[32minfo#033[39m: [app] Shutdown complete.
Jan 28 17:24:52 www msforum[17939]: [cluster] Child Process (7158) has exited (code: 1, signal: null)
Jan 28 17:24:52 www msforum[17939]: [cluster] Spinning up another process...
Jan 28 17:24:53 www msforum[17939]: 28/1 17:24 [7203] - #033[32minfo#033[39m: Time: Thu Jan 28 2016 17:24:53 GMT+0100 (CET)
Jan 28 17:24:53 www msforum[17939]: 28/1 17:24 [7203] - #033[32minfo#033[39m: Initializing NodeBB v0.9.3

Anyone else seeing this?
I had this 4-5 times during the last hour now. Everything has worked fine for over a week prior to this.

pichalite

@hek are you using persona? what version of persona are you using?

hek

Yep, persona v4.0.45

pichalite

@hek if you are on v0.9.3... group chat has nothing to do with it as it's not part of 0.9.3

hek

Yes, I know... it was this message that led me to this particular thread.
TypeError: Cannot read property 'messageId' of undefined

Unfortunately the the call-stack doesn't contain more info.. Well let's hope it stabilises itself.

faddat

Cool! I have a question about the chat, and I hope that you'll take/consider this seriously. I spend a lot of time on the web, and a lot of time looking at (specifically) Open Source web applications. When I was looking for fourm code it was quite the epic, trying damn near everything out there. I've chosen this forum code, and so I hope to support you with ideas as well as PRs. For a million and one reasons, I strongly prefer NodeBB to Discourse. It's a choice I'd gladly make over and over, and it largely has to do with the receptivity of the community that creates NodeBB to new ideas. Discourse is too busy trying to bury their Multi-Site functionality to be receptive to new ideas.

I think that the chat in NodeBB should integrate with either IRC or Matrix Chat. I know that Raocket.Chat, a meteor-based chat application has support for Matrix Chat (ether upcoming, or.... something. Here is a link to the relevant repo: https://github.com/RocketChat/Rocket.Chat.Federation

Standards are a very, very good thing. IRC is one, Matrix is another. Web app content-based walled gardens are just as annoying as any other walled garden, and we should strive to avoid them. Well, that's what I've got for now. Thanks for the awesome code, keep it up!

a_5mith

Sounds like a plugin idea to me.

julian

Definitely, there's no reason you cannot use your own chat app in place of NodeBB's

The main blocker here is that we don't fire the necessary client-side hooks when a user opens a chat (namely, app.openChat()). If we added a client-side hook there, then you could intercept it and open a new chat using whatever service you desire

There's just been no interest in that so far

? Offline

@hek said:

Yes, I know... it was this message that led me to this particular thread.
TypeError: Cannot read property 'messageId' of undefined

Unfortunately the the call-stack doesn't contain more info.. Well let's hope it stabilises itself.

Your posts led me to the same topic as well, I noticed the restarts in my log this morning - v0.9.3.

yariplus

@Ted was happening for me too, looks like it might have been fixed here
https://github.com/NodeBB/NodeBB/commit/a3dc427e671ce8af059a8ceb85fe99192f41544e

yariplus

@faddat That sounds like an awesome idea!

? Offline

@yariplus Thanks for confirming that. I'll look at making the change manually later and test on my end. Though more than anything I'm just waiting on 1.0. Started from v0.5, and there've been some major overhauls along the way. Group chats have been a widely requested feature along the way, so I'll be happy to see it come to fruition.

faddat

@julian

I'm new to javascript-- in fact to almost all programming. That said I've been doing some cool stuff with Hugo & JS. A client-side hook is something that happens in the client (web browser's javascript) -- correct?

How does one look at client-side code for nodebb?

Thanks a lot

-Jake

julian

@faddat Right now the only way is to search the code in public/src for the string $(window).trigger(

Jared14406

This post is deleted!

CarlosRodriguez

As for Room Names, are they private by default? Can be set to public so users can join from a public room list?

pichalite

@CarlosRodriguez No, all chats are private.

CarlosRodriguez

But one can join knowing the room name or must be added by the room owner?