Group Chat Changes

sanatisharif

@baris @pichalite
Thanks a lot, Now every thing is fine!

sanatisharif

Group chat is only available on master not 0.9.3 as @pichalite mentioned. I just commited some fixes to master, you also need latest persona, let me know if you are still seeing issues after updating to those. For production wait for 1.0.0 if you want group chat.

restart again with this error:

21/12 15:07 [25414] - error: TypeError: Cannot read property 'messageId' of undefined
	at /path/to/nodebb/src/messaging.js:158:53
	at fn (/path/to/nodebb/node_modules/async/lib/async.js:741:34)
	at /path/to/nodebb/node_modules/async/lib/async.js:1208:16
	at /path/to/nodebb/node_modules/async/lib/async.js:166:37
	at /path/to/nodebb/node_modules/async/lib/async.js:701:43
	at /path/to/nodebb/node_modules/async/lib/async.js:167:37
	at Immediate._onImmediate (/path/to/nodebb/node_modules/async/lib/async.js:1201:34)
	at processImmediate [as _immediateCallback] (timers.js:367:17)
TypeError: Cannot read property 'messageId' of undefined
	at /path/to/nodebb/src/messaging.js:158:53
	at fn (/path/to/nodebb/node_modules/async/lib/async.js:741:34)
	at /path/to/nodebb/node_modules/async/lib/async.js:1208:16
	at /path/to/nodebb/node_modules/async/lib/async.js:166:37
	at /path/to/nodebb/node_modules/async/lib/async.js:701:43
	at /path/to/nodebb/node_modules/async/lib/async.js:167:37
	at Immediate._onImmediate (/path/to/nodebb/node_modules/async/lib/async.js:1201:34)
	at processImmediate [as _immediateCallback] (timers.js:367:17)
21/12 15:07 [25414] - info: [app] Shutdown (SIGTERM/SIGINT) Initialised.
21/12 15:07 [25414] - error: MongoError: server 127.0.0.1:27017 sockets closed
	at Server.destroy (/path/to/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/topologies/server.js:676:47)
	at Server.close (/path/to/nodebb/node_modules/mongodb/lib/server.js:367:17)
	at Db.close (/path/to/nodebb/node_modules/mongodb/lib/db.js:333:19)
	at Object.module.close (/path/to/nodebb/src/database/mongo.js:228:6)
	at shutdown (/path/to/nodebb/app.js:305:28)
	at process.<anonymous> (/path/to/nodebb/app.js:176:3)
	at process.emit (events.js:107:17)
	at process._fatalException (node.js:236:26)

<baris>

@sanatisharif What git hash are you on? git rev-parse HEAD

sanatisharif

@baris said:

git rev-parse HEAD

a6f484acf8afecb945721c749fc23ec8fbe28c64

<baris>

I can't find that hash in the nodebb repo

sanatisharif

@baris

output of git status command:

output of git remote show origin command:

output of git rev-parse HEAD command:

Pixel

@Kowlin For example it's easier to create a private chat with a group of 15 people and downvote whoever says something that we don't like. Or they can also spoil a topic... There are people with too much imagination, believe me xD

sanatisharif

I think nodebb team make chat group like Telegram group chat, and this is good!

bitspook

@baris said:

Just merged the group-chat branch into master, it will be available in our next release which will most likely be 1.0.0.

+1 +1 +1 +1 +1 +1

sanatisharif

@baris
I run this commands:

git commit -a // for commit language file change!
git pull origin master
./nodebb upgrade

after these, output of git rev-parse HEAD is:
0c0e0138ed6828e4f4488a3f58f9b4a13045c8c1

Quantum

Thanks for all the effort you guys put into NodeBB, looking forward to this update.

Pixel

@JaredBusch said:

@Kowlin said:

@exodo any reason you want a option to disable it?

Maybe not a disable, but instead make a max participant value. If the forum admin sets it to 2, then it would be no different than now.

I really want the feature. I cannot count the number of times I have had a chat going and then had to either backfire things to another person, or take it to another medium (Skype/hangouts) in order to get a group chat going.

This would be still better, if it's set to 2 is a chat. If you have some kind of trouble you can try adjusting the value to 6, 5, 4, 3... or eventually 1.

pichalite

I agree with @exodo group chat will most likely kill forum activity.

<baris>

I'm fine with adding a group chat user limit option. Set it to 2 and we can even hide the input to add more users so we end up with the old 1 to 1 chat. You can already disable chat entirely from the ACP so if you are worried about chat reducing forum activity you can do that as well.

a_5mith

@baris said:

I'm fine with adding a group chat user limit option. Set it to 2 and we can even hide the input to add more users so we end up with the old 1 to 1 chat. You can already disable chat entirely from the ACP so if you are worried about chat reducing forum activity you can do that as well.

Set it to 1 and Psychobunny can have conversations with himself.

Robert

@a_5mith Its not like he does already

Edit: set it to 10, and @julian will have lovely conversations with his exotic fruits.

exodo

@baris said:

I'm fine with adding a group chat user limit option. Set it to 2 and we can even hide the input to add more users so we end up with the old 1 to 1 chat. You can already disable chat entirely from the ACP so if you are worried about chat reducing forum activity you can do that as well.

That seems perfect

julian

@exodo Glad to hear it... now can you tell me why someone on your forum tweeted about me and called me a "gran puta"?

a_5mith

@julian said:

@exodo Glad to hear it... now can you tell me why someone on your forum tweeted about me and called me a "gran puta"?

Shiiet. Internet can be serious business sometimes. Hope you gave him some traditional insults back.

exodo

@julian said:

@exodo Glad to hear it... now can you tell me why someone on your forum tweeted about me and called me a "gran puta"?

Lol. Not sure. There,s stupids around the world. We got 5k users and I dont even use twitter.
Guess nodebb is getting famous