Group Chat Changes

sanatisharif

@baris
I run this commands:

git commit -a // for commit language file change!
git pull origin master
./nodebb upgrade

after these, output of git rev-parse HEAD is:
0c0e0138ed6828e4f4488a3f58f9b4a13045c8c1

Quantum

Thanks for all the effort you guys put into NodeBB, looking forward to this update.

Pixel

@JaredBusch said:

@Kowlin said:

@exodo any reason you want a option to disable it?

Maybe not a disable, but instead make a max participant value. If the forum admin sets it to 2, then it would be no different than now.

I really want the feature. I cannot count the number of times I have had a chat going and then had to either backfire things to another person, or take it to another medium (Skype/hangouts) in order to get a group chat going.

This would be still better, if it's set to 2 is a chat. If you have some kind of trouble you can try adjusting the value to 6, 5, 4, 3... or eventually 1.

pichalite

I agree with @exodo group chat will most likely kill forum activity.

<baris>

I'm fine with adding a group chat user limit option. Set it to 2 and we can even hide the input to add more users so we end up with the old 1 to 1 chat. You can already disable chat entirely from the ACP so if you are worried about chat reducing forum activity you can do that as well.

a_5mith

@baris said:

I'm fine with adding a group chat user limit option. Set it to 2 and we can even hide the input to add more users so we end up with the old 1 to 1 chat. You can already disable chat entirely from the ACP so if you are worried about chat reducing forum activity you can do that as well.

Set it to 1 and Psychobunny can have conversations with himself.

Robert

@a_5mith Its not like he does already

Edit: set it to 10, and @julian will have lovely conversations with his exotic fruits.

exodo

@baris said:

I'm fine with adding a group chat user limit option. Set it to 2 and we can even hide the input to add more users so we end up with the old 1 to 1 chat. You can already disable chat entirely from the ACP so if you are worried about chat reducing forum activity you can do that as well.

That seems perfect

julian

@exodo Glad to hear it... now can you tell me why someone on your forum tweeted about me and called me a "gran puta"?

a_5mith

@julian said:

@exodo Glad to hear it... now can you tell me why someone on your forum tweeted about me and called me a "gran puta"?

Shiiet. Internet can be serious business sometimes. Hope you gave him some traditional insults back.

exodo

@julian said:

@exodo Glad to hear it... now can you tell me why someone on your forum tweeted about me and called me a "gran puta"?

Lol. Not sure. There,s stupids around the world. We got 5k users and I dont even use twitter.
Guess nodebb is getting famous

<baris>

https://github.com/NodeBB/NodeBB/issues/3996
https://github.com/NodeBB/NodeBB/issues/3997

Robert

@baris And the "room owner" is defined by the person who first adds people to a chat I assume?

<baris>

@Kowlin Yes the first person to start the room is the owner.

hek

I've just experienced a series of rapid restarts on 0.9.3 (cf5decf5de6f3b1e0690d2c4deab1565c21989ef) with a similar exception as mentioned above.

Jan 28 17:24:52 www msforum[17939]: 28/1 17:24 [7158] - #033[31merror#033[39m: TypeError: Cannot read property 'messageId' of undefined
Jan 28 17:24:52 www msforum[17939]: at processImmediate [as _immediateCallback] (timers.js:383:17)
Jan 28 17:24:52 www msforum[17939]: TypeError: Cannot read property 'messageId' of undefined
Jan 28 17:24:52 www msforum[17939]: at processImmediate [as _immediateCallback] (timers.js:383:17)
Jan 28 17:24:52 www msforum[17939]: 28/1 17:24 [7158] - #033[32minfo#033[39m: [app] Shutdown (SIGTERM/SIGINT) Initialised.
Jan 28 17:24:52 www msforum[17939]: 28/1 17:24 [7158] - #033[32minfo#033[39m: [app] Database connection closed.
Jan 28 17:24:52 www msforum[17939]: 28/1 17:24 [7158] - #033[32minfo#033[39m: [app] Web server closed to connections.
Jan 28 17:24:52 www msforum[17939]: 28/1 17:24 [7158] - #033[32minfo#033[39m: [app] Shutdown complete.
Jan 28 17:24:52 www msforum[17939]: [cluster] Child Process (7158) has exited (code: 1, signal: null)
Jan 28 17:24:52 www msforum[17939]: [cluster] Spinning up another process...
Jan 28 17:24:53 www msforum[17939]: 28/1 17:24 [7203] - #033[32minfo#033[39m: Time: Thu Jan 28 2016 17:24:53 GMT+0100 (CET)
Jan 28 17:24:53 www msforum[17939]: 28/1 17:24 [7203] - #033[32minfo#033[39m: Initializing NodeBB v0.9.3

Anyone else seeing this?
I had this 4-5 times during the last hour now. Everything has worked fine for over a week prior to this.

pichalite

@hek are you using persona? what version of persona are you using?

hek

Yep, persona v4.0.45

pichalite

@hek if you are on v0.9.3... group chat has nothing to do with it as it's not part of 0.9.3

hek

Yes, I know... it was this message that led me to this particular thread.
TypeError: Cannot read property 'messageId' of undefined

Unfortunately the the call-stack doesn't contain more info.. Well let's hope it stabilises itself.

faddat

Cool! I have a question about the chat, and I hope that you'll take/consider this seriously. I spend a lot of time on the web, and a lot of time looking at (specifically) Open Source web applications. When I was looking for fourm code it was quite the epic, trying damn near everything out there. I've chosen this forum code, and so I hope to support you with ideas as well as PRs. For a million and one reasons, I strongly prefer NodeBB to Discourse. It's a choice I'd gladly make over and over, and it largely has to do with the receptivity of the community that creates NodeBB to new ideas. Discourse is too busy trying to bury their Multi-Site functionality to be receptive to new ideas.

I think that the chat in NodeBB should integrate with either IRC or Matrix Chat. I know that Raocket.Chat, a meteor-based chat application has support for Matrix Chat (ether upcoming, or.... something. Here is a link to the relevant repo: https://github.com/RocketChat/Rocket.Chat.Federation

Standards are a very, very good thing. IRC is one, Matrix is another. Web app content-based walled gardens are just as annoying as any other walled garden, and we should strive to avoid them. Well, that's what I've got for now. Thanks for the awesome code, keep it up!