[nodebb-plugin-ns-embed] NS Embed

FrankM

After upgrade to 1.13.0 my twitter code don't work!?

watch

(?:<a.*?)?(?:https?:\/\/)?(?:twitter\.com)\/([^\/\"\s]*)\/status\/([^\/\"\s]*)(\/photo\/\d|)(?:.*?\/a>)?

replace

<div class='embed-wrapper'>
<blockquote class="twitter-tweet"><a href="https://twitter.com/$1/status/$2?ref_src=twsrc%5Etfw"></a></blockquote> <script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script> 	
</div>

Someone an idea for me?

PitaJ

Several plugins are incompatible with 1.13.0

<baris>

Could be related to https://github.com/NodeBB/NodeBB/issues/7872

julian

Hm... <script> could be useful in widgets. @FrankM is that code in a widget? It should not be allowed in post text since it contains an external script.

FrankM

Found this rule in this forum. Before v1.13.0 this code works. I think problem is the XSS protection.

But i am no coder, so i will wait for an solution.

Maciej Bąk 0

Hmm I am using 1.13.0 also, and tried today many different plugins about embeding and no one works.. so can be this XSS protection

julian

@Nicolas What HTML elements does this plugin use? You probably need to hook into the sanitizer to allow those tags and/or attributes.

Nicolas

Hello @julian
The plugin provides dynamic replacements. You can specify any replacement rule (Regular Expression), something like these: https://github.com/NicolasSiver/nodebb-plugin-ns-embed/blob/master/docs/community-rules.md

Forum owners decide what they want to insert as a result of replacement.

y h

This post is deleted!

Nicolas

Version 4.0.0

The new version is available.

Added support for post preview of the embedded content
Changed dependencies to comply with the most security updates
Changed compatibility with NodeBB v1.13.x

FrankM

@Nicolas Thanks!

Unfortunately I can't get the Twitter Embed working

Per0x

This post is deleted!

Nicolas

@FrankM Twitter embed is using script injection. The latest update to the plugin adheres to the security changes in NodeBB. I think should be a separate plugin for Twitter embeds with the efficient lazy loading for necessary scripts, etc. This plugin works the best with the embeds which are based on iframe.

FrankM

@Nicolas Thanks for info.

This plugin works fine for twitter https://community.nodebb.org/topic/1443/twitter-embed-plugin/12

crazycells

@Nicolas said in [nodebb-plugin-ns-embed] NS Embed:

Version 4.0.0

The new version is available.

Added support for post preview of the embedded content

Changed dependencies to comply with the most security updates

Changed compatibility with NodeBB v1.13.x

Thanks for the update!

zaasmi

@Nicolas said in [nodebb-plugin-ns-embed] NS Embed:

@FrankM Twitter embed is using script injection. The latest update to the plugin adheres to the security changes in NodeBB. I think should be a separate plugin for Twitter embeds with the efficient lazy loading for necessary scripts, etc. This plugin works the best with the embeds which are based on iframe.

We are using it as custom http:// redirect it to https:// ?
Please guide!
demo

zaasmi

@Nicolas it was a cloudflare Automatic HTTPS Rewrites error now this status!

omega

Updated a nodeBB to 1.13, all seems relatively fine, though, I was not paying attention and I updated to v1.13.4-3. - that's ok for now, seems to work.

However the ns-embd plugin is not embedding tweets, just leaving a blank blockquote. Youtube videos embed perfectly fine, so I suspect the watch + replace needs tweaking?

Watch

(?:<a.*?)?(?:https?:\/\/)?(?:twitter\.com)\/([^\/\"\s]*)\/status\/([^\/\"\s]*)(\/photo\/\d|)(?:.*?\/a>)?

Replace

<blockquote class="twitter-tweet"><a href="https://twitter.com/$1/status/$2?ref_src=twsrc^tfw"></a></blockquote> <script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>

crazycells

@omega we had the same problem with facebook and twitter links in 1.13.3

I opened this issue several weeks ago, but they did not check yet...

Rate limit · GitHub

(github.com)

omega

@crazycells Ok cool tx!