permalink url option

Andrea Cardinale

I think a plugin is not enough and would create compatibility issues especially with other plugins.
Should be changed / added something in NodeBB.

yariplus

I'm not very familiar with wordpress, but searching around, it looks like their Permalink system is indeed a plugin, (what they call a "module") and it's not even turned on by default.

It would be a nice plugin I think.

Pakorn

so sad that it will take a long time for nodeBB to implement post-id instead of post-title.
I will have to move to other platform even though i like nodeBB a lot but cannot really accept when slug looks like garbage in Thai.

PitaJ

Slug looks like garbage in Thai? What exactly is the problem with it?

Pakorn

@pitaj said:

Slug looks like garbage in Thai? What exactly is the problem with it?

Thai has characters above and under unlike english or chinese in which Thai use that place for vow

On nodeBB, if the word has letter above or under normal letter, it will replace letter with "-"

PitaJ

@Pakorn can you give me an example of what a correct and incorrect slug would look like? I can fix this.

Pakorn

@pitaj for example "สวัสดี" it will change to "สว-สด-"
another example "ทุกอย่าง" will change to "ท-กอย-าง"

julian

@pitaj

It's utils.invalidUnicodeChars incorrectly capturing the above/below symbols as invalid, so they are removed and turned into -:

In console:

XRegExp.replace('สวัสดี', XRegExp('[^\\p{L}\\s\\d\\-_]', 'g'), '-')

// "สว-สด-"

yariplus

Isn't that intentional though, because browsers convert uppercase characters in the same manner?

edit: nevermind it works differently then I thought.

julian

@yariplus It's not a matter of it being lowercased, I think, but that it's considered an "invalid" character, possibly because it is a modifier for the character before it.

@pitaj @Pakorn These guys seem to have no problems with slugs, perhaps you can ask them? http://nodejs.vn/topic/261/cần-làm-wapchat-cơ-bản-bằng-ngôn-ngữ-nodejs-và-angularjs/3

ps21947

Changing XRegExp to [^\p{L}\p{thai}\s\d\-_] will solve this problem. I'm testing it right now to see if there any side effect.

update: I'm already testing there are a lot of problem when this code go live but it can be fix. It's work just fine a least for now.