Submitting a Pull Request to NodeBB? Contributor License Agreement

Scuzz

@psychobunny Would I need to sign this if i have submitted code which is probably not in use any more?

frissdiegurke

subscribed.

psychobunny

@psychobunny Would I need to sign this if i have submitted code which is probably not in use any more?

On our Github contributors page I don't see your username specifically, but if you have submitted code you would have to sign the agreement otherwise we will unfortunately have to remove/rewrite. That's totally up to you and we appreciate all the contributions - not just code, but your community involvement as well.

Thanks

And thanks @frissdiegurke

Scuzz

@psychobunny yeah i'm on there https://github.com/NodeBB/NodeBB/commits?author=JoshRickers
I'll sign.

julian

Thanks @Scuzz

psychobunny

Oh cool. (I was looking for Scuzz)

Thanks

Ted

I tried but answers me "We're sorry, but something went wrong."

psychobunny

Yikes, okay, thanks though. Has anybody else gotten this problem? We're considering moving over to Google Docs instead, if problems persist

jarey

Just filled it out just in case i do a pull request.

Huggy

@psychobunny
Tired to sign twice!

julian

CLAHub :rage2:

hek

Exactly the same problems for the MySensors project. When new users try to sign our CLA they have gotten the same error lately. Very frustrating.

Bri

Hm I just tried to sign and it's still Erroring out. Moving to Google docs?

EDIT: Uh, just read their blog, and the last update was 2 years ago. I don't think this is getting fixed any time soon.

Edit: actually I saw the author replying to someone about a month ago, seems like the issue hasn't been tracked down

julian

Yeah... we will most likely port the existing signatures to Google Docs...

Bri

Before the 28th, hopefully! Is that a hard deadline for something?

yariplus

That's so weird. I've never had a problem like that with CLAhub. I signed the NodeBB cla as soon as you posted it, no problem.

I guess I should consider moving my own agreements if it's such as widespread problem...

Baerrus

Guys, could you take a look at pull requests pls?

Fix pagination errors on categories and topics pages. by baerrus · Pull Request #2926 · NodeBB/NodeBB

Correct numbering page links Correct next/prev links Fix topics problem where if PostNumber +1 == TopicPosts, it would not create the second page

GitHub (github.com)

Btw, I did sign CLA before. Though CLAhub lately just errors out

ahwayakchih

@Baerrus same here, i tried to sign CLA, but it keeps erroring out :(.

nhl.pl

NodeBB Individual Contributor Assignment Agreement
https://github.com/NodeBB/NodeBB/pull/2908#issuecomment-86931697
https://docs.google.com/forms/d/1KrniXs3pwK8dMeAZnnQz2D07ne7LjJTYIYwJrpDqgnE/viewform

ahwayakchih

Thanks! I just signed it.