Submitting a Pull Request to NodeBB? Contributor License Agreement
-
Submitting a Pull Request to NodeBB?
First of all, thank you! Please consider this style guide when submitting your changes. Also, please join our community to meet other NodeBB developers and designers
Contributor License Agreement
Thank you for considering contributing to NodeBB. Before we can accept any pull requests, please take a moment to read and sign our license agreement. In summary, signing this document means that 1) you own the code that you are contributing and 2) you give permission to NodeBB Inc. to license the code to others. This agreement applies to any repository under the NodeBB organization.
If you are writing contributions as part of employment from another company / individual, then your employer will need to sign a separate agreement. Please contact us so that we can send this additional agreement to your employer.
Why do I have to sign this?
Long story short, the GPLv3 can be a bit scary for companies wanting to deeply integrate NodeBB with their own software, so the ability to create a secondary commercial license for them is important. It also opens a potential revenue stream for us, but really, we just want to see some big players use NodeBB - it would be a great endorsement for the product that we are all building.
"I've already contributed but I don't want to sign this"
As unfortunate as that is, we definitely will understand if for whatever reason you decide against signing this. We are setting a hard deadline of February 28th for existing contributors to accept this agreement - if not, due to legal constraints we will unfortunately have to either remove your contribution or rewrite it completely.
Contributor License Agreement
Thanks again!
-
Thanks
And thanks to everybody else in advanced. -
@psychobunny Would I need to sign this if i have submitted code which is probably not in use any more?
-
subscribed.
-
@Scuzz said:
@psychobunny Would I need to sign this if i have submitted code which is probably not in use any more?
On our Github contributors page I don't see your username specifically, but if you have submitted code you would have to sign the agreement otherwise we will unfortunately have to remove/rewrite. That's totally up to you and we appreciate all the contributions - not just code, but your community involvement as well.
Thanks
And thanks @frissdiegurke
-
@psychobunny yeah i'm on there https://github.com/NodeBB/NodeBB/commits?author=JoshRickers
I'll sign. -
Oh cool. (I was looking for Scuzz)
Thanks
-
I tried but answers me "We're sorry, but something went wrong."
-
Yikes, okay, thanks though. Has anybody else gotten this problem? We're considering moving over to Google Docs instead, if problems persist
-
Just filled it out just in case i do a pull request.
-
@psychobunny
Tired to sign twice!
-
Exactly the same problems for the MySensors project. When new users try to sign our CLA they have gotten the same error lately. Very frustrating.
-
Hm I just tried to sign and it's still Erroring out. Moving to Google docs?
EDIT: Uh, just read their blog, and the last update was 2 years ago. I don't think this is getting fixed any time soon.
Edit: actually I saw the author replying to someone about a month ago, seems like the issue hasn't been tracked down
-
Before the 28th, hopefully!
Is that a hard deadline for something? -
That's so weird. I've never had a problem like that with CLAhub. I signed the NodeBB cla as soon as you posted it, no problem.
I guess I should consider moving my own agreements if it's such as widespread problem...
-
Guys, could you take a look at pull requests pls?
Fix pagination errors on categories and topics pages. by baerrus · Pull Request #2926 · NodeBB/NodeBB
Correct numbering page links Correct next/prev links Fix topics problem where if PostNumber +1 == TopicPosts, it would not create the second page
GitHub (github.com)
Btw, I did sign CLA before. Though CLAhub lately just errors out
