3.6.0 Upgrade Support

yasas

Hi @baris
Thanks for the response.

Install my current version on a new VM, restore the dump and connect the DB and public uploads, and then upgrade that to v3.6.3
* Install v3.6.3 in one go on a new VM, restore the dump and connect the DB and public uploads

Do you mean that instead of installing v3.6.3 straightaway and restoring the DB dump (dumped from v2.8.1 earlier), it would be wiser to install v2.8.1 on a new VM, restore the db dump, and then upgrade to V3.6.3?

PitaJ

@yasas you should be able to install v3.6.3 right away and then just run ./nodebb upgrade first thing.

<baris>

Yeah no need to install your current version, the upgrade process will take care of running the scripts.

yasas

@baris @PitaJ Got it.

So basically the idea is to install v3.6.3 right away, point to the db (with the restored dump) during config, run ./nodebb upgrade and all done yeah?

<baris>

Yeah you can just copy your old config.json in and run ./nodebb upgrade as well

yasas

@baris Perfect. Thanks very much for clarifying!

Sebastián Cisneros

@baris I had 3.6.5 installed, no problem. All other updates from that version up, break my website. updating to 3.6.6 works. 3.6.7 breaks my install.
upgrade does not report any problem
Build does not report any problem,
nodebb dev gets stucked

2024-05-28T13:55:23.815Z [4567/4384] - verbose: [plugins/fireHook] filter:sanitize.config
2024-05-28T13:55:23.816Z [4567/4384] - info: [plugins] Plugins OK
2024-05-28T13:55:23.816Z [4567/4384] - verbose: [plugins/fireHook] static:assets.prepare
2024-05-28T13:55:23.817Z [4567/4384] - verbose: [plugins/fireHook] static:app.preload
2024-05-28T13:55:23.817Z [4567/4384] - verbose: [plugins/fireHook] filter:router.add
2024-05-28T13:55:23.819Z [4567/4384] - verbose: [plugins/fireHook] static:app.load
2024-05-28T13:55:23.823Z [4567/4384] - verbose: [plugins/fireHook] filter:settings.get
2024-05-28T13:55:23.828Z [4567/4384] - verbose: [plugins/fireHook] filter:settings.get
-- stops here, no error, nothing, but does not work----

the nodebb updates comparison here
https://github.com/NodeBB/NodeBB/compare/v3.6.5...v3.6.7
I've noticed that if I undo the updates on src/plugins/hooks.js the nodebb starts to work again.
Any idea what can I do on my custom theme/plugins to fix it?

Comparing v3.6.5...v3.6.7 · NodeBB/NodeBB

Node.js based forum software built for the modern web - Comparing v3.6.5...v3.6.7 · NodeBB/NodeBB

GitHub (github.com)

<baris>

Sounds like you have plugin or theme that has a static hook that is using a callback and not calling it properly. Check your custom plugins/themes and make sure their static hooks use this pattern. That hook is for static:app.load

Sebastián Cisneros

@baris thanks for the help. I'm going through all the static: hooks used in custom theme and plugins, and noticed some difference on how some of them are coded. Maybe this is the problem? some have like a next() or callback() function at the end. Can this be the issue? I see that the example you show to me doesn't have the callback / next function at the end.

example one (not calling callback)

{ "hook": "static:app.load", "method": "init" },
plugin.init = async function (data) {
	const controllers = require('./controllers');
	SocketPlugins.composer = socketMethods;

	data.router.get('/admin/plugins/composer-default', data.middleware.admin.buildHeader, controllers.renderAdminPage);
	data.router.get('/api/admin/plugins/composer-default', controllers.renderAdminPage);
};

example two (calling callback)

{ "hook": "static:app.load", "method": "init" },
exports.init = ({ router, middleware }, callback) => {
  router.get('/admin/plugins/cdn', middleware.admin.buildHeader, renderAdmin);
  router.get('/api/admin/plugins/cdn', renderAdmin);

  router.get('/api/admin/plugins/cdn/save', (req, res, next) => {
    setObject('plugin_cdn:settings', JSON.parse(req.query.settings), (err) => {
      if (err) {
        next(err);
        return;
      }

      res.sendStatus(200);
    });
  });

  callback();
};

<baris>

Does nodebb start when you disable second plugin?

Sebastián Cisneros

I got a lot of custom plugins with that old callback function. I think that is the issue. One example is from

nodebb-plugin-cdn
I have a custom version of it (dont ask why....)

I can see that the latest update
https://github.com/NodeBB/nodebb-plugin-cdn/commit/186a98f1df60309ae4dcc4338bf6c0c15a025de3
in the exports.preLoad , they had the callback before, and in the current lastest version, that is not there anymore.

update for 2.x · NodeBB/nodebb-plugin-cdn@186a98f

Contribute to NodeBB/nodebb-plugin-cdn development by creating an account on GitHub.

GitHub (github.com)

Sebastián Cisneros

After recoding all the static callback issues, website is working again. Thanks for the help.