Total vote count on topic list

<baris>

@phenomlab I fixed the script in the above post, also made some changes to the plugin so it doesn't run the calculation on every page load. https://github.com/oplik0/nodebb-plugin-total-vote-count/pull/21

It will only calculate the total vote count if it is missing so any loads after that will use the cached value. Hopefully that improves performance.

phenomlab

@baris Great! I'll have a another go with this.

phenomlab

@baris said in Total vote count on topic list:

I fixed the script in the above pos

Still doesn't work for me

throw new Error(`[[error:invalid-score, ${item[1]}]]`);
^

Error: [[error:invalid-score, NaN]]
    at /home/sudonix.org/nodebb/src/database/mongo/sorted/add.js:84:11
    at Array.forEach (<anonymous>)
    at module.sortedSetAddBulk (/home/sudonix.org/nodebb/src/database/mongo/sorted/add.js:82:8)
    at Object.wrapperCallback [as sortedSetAddBulk] (/home/sudonix.org/nodebb/src/promisify.js:46:11)
    at batch.processSortedSet.batch (/home/sudonix.org/nodebb/vote.js:44:26)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async module.processSortedSet (/home/sudonix.org/nodebb/src/database/mongo/sorted.js:602:5)
    at async exports.processSortedSet (/home/sudonix.org/nodebb/src/batch.js:30:10)
    at async fixVotes (/home/sudonix.org/nodebb/vote.js:34:9)
    at async /home/sudonix.org/nodebb/vote.js:26:2

<baris>

@phenomlab maybe try with below

/* eslint-disable no-await-in-loop */
/* globals require, console, process */

'use strict';
 
const nconf = require('nconf');
 
nconf.file({
	file: 'config.json',
});
 
nconf.defaults({
	base_dir: __dirname,
	views_dir: './build/public/templates',
	upload_path: 'public/uploads',
});
 
const db = require('./src/database');
 
db.init(async (err) => {
	if (err) {
		console.log(`NodeBB could not connect to your database. Error: ${err.message}`);
		process.exit();
	}
 
	await fixVotes();
	console.log('done');
	process.exit();
});
 
 
async function fixVotes() {
	const batch = require('./src/batch');
	await batch.processSortedSet('topics:tid', async (tids) => {
		let topicData = await db.getObjectsFields(
			tids.map(tid => `topic:${tid}`),
			['tid', 'cid', 'timestamp', 'upvotes', 'downvotes']
		);
		topicData = topicData.filter(t => t && t.cid);
		topicData.forEach((t) => {
			t.votes = parseInt(t.upvotes || 0, 10) - parseInt(t.downvotes || 0, 10);
		});
 
		await db.sortedSetAddBulk(
			topicData.map(t => ([`cid:${t.cid}:tids:votes`, t.votes, t.tid]))
		);
		await db.sortedSetAddBulk(
			topicData.map(t => ([`topic:votes`, t.votes, t.tid]))
		);
 
		
	}, {
		batch: 500,
	});
}

phenomlab

@baris that seems to work.

phenomlab

@baris I've installed the latest version of this plugin, and have new settings as below

These seem to work fine, but when using /top the votes are not in any specific order?

<baris>

@phenomlab what is the url on the page it doesn't work? Is it just /top or does it have any query params?

phenomlab

@baris Just /top. For example, https://sudonix.org/top

EDIT - having thought about it, /top doesn't display in vote order by default, but it doesn't display in view order either?

crazycells

@phenomlab I thought /top puts the topics in order according their vote number (number of votes of the first post)...

@baris is this plugin affecting how /top behaves? or just how /popular behaves?

<baris>

Yeah it should display in vote order on /top, it doesn't affect /popular, I have a fix for it in https://github.com/oplik0/nodebb-plugin-total-vote-count/pull/24 but it will require 3.7.2 which will come tomorrow.

phenomlab

@baris Many thanks

phenomlab

@baris updated to 3.7.2 and now just waiting for the plugin to be updated.