Issue since upgrading to v1.13.1 from v1.12.1

PitaJ

What's the output of git status?

Brophy

I have sent you the link to pastebin via PM

PitaJ

Why not just share it here? Then people can see it in the future and tell if their issue is the same as yours.

Anyways, as I suspected, you have many modified files in your nodebb directory. I suggest you run git reset --hard HEAD to reset those files to normal. Also, it shows at least one extra untracked file, src/controllers/accounts/session.js which may be causing problems as well, so I suggest deleting that.

Brophy

I was concerned about the size of it, however, if you still wish to share it, feel free.

I've done the above and still getting the same issue after rebuilding.

I'll attempt to do a clean install, point the DB to the new one and get back to you.

Brophy

Nope, still getting the issue.

Is there a possibility that a broken group could have caused this? Someone tried to update their group yesterday and managed to break it, I am unable to recover the group/edit or delete it.

I just see this in the admin panel (the blank one above Five-0):

<baris>

Looks like there is a group with invalid/missing data. Maybe you can inspect the groups page to see the name of the missing group on the first row.

In the meantime this commit should prevent the crash you are getting on the widgets page.

<baris>

@Brophy said in Issue since upgrading to v1.13.1 from v1.12.1:

Someone tried to update their group yesterday and managed to break it,

This sounds like a serious issue, let us know if you can reproduce this.

Brophy

@baris said in Issue since upgrading to v1.13.1 from v1.12.1:

Looks like there is a group with invalid/missing data. Maybe you can inspect the groups page to see the name of the missing group on the first row.

In the meantime this commit should prevent the crash you are getting on the widgets page.

That's great, that's fixed the widgets page, thank you very much.

@baris said in Issue since upgrading to v1.13.1 from v1.12.1:

@Brophy said in Issue since upgrading to v1.13.1 from v1.12.1:

Someone tried to update their group yesterday and managed to break it,

This sounds like a serious issue, let us know if you can reproduce this.

I've asked the guy and he said that he was only editing the group banner, he also stated he only used normal letters, no special characters were involved either.
In the meantime, do you know of a way that I can either recover or purge this group?

oplik0

@baris said in Issue since upgrading to v1.13.1 from v1.12.1:

@Brophy said in Issue since upgrading to v1.13.1 from v1.12.1:

Someone tried to update their group yesterday and managed to break it,

This sounds like a serious issue, let us know if you can reproduce this.

There are some issues with group functions that lead to more serious vulnerabilities than just invalid names. I'm in the process of describing at least some of them and should send it to [email protected] today. I haven't tested the lack of name altogether, although I think I know how one might go around doing this.

<baris>

@Brophy When you right click in the browser and inspect the empty row do you see a group name?

Brophy

@baris said in Issue since upgrading to v1.13.1 from v1.12.1:

@Brophy When you right click in the browser and inspect the empty row do you see a group name?

Unfortunately not.

Here is the element:

<tr data-groupname="">
					<td>
						
					</td>
					<td>
						<span class="label label-default" style="color:; background-color: ;"></span>
					</td>
					<td>
						
						
						
					</td>
					<td class="hidden-xs">
						<p class="description"></p>
					</td>
					<td class="hidden-xs text-right">
						
					</td>
					<td>
						<div class="btn-group ">
							<a href="/admin/manage/groups/" class="btn btn-default btn-xs">
								<i class="fa fa-edit"></i> Edit
							</a>
							
							<button class="btn btn-danger btn-xs" data-action="delete"><i class="fa fa-times"></i></button>
							
						</div>
					</td>
				</tr>

<baris>

Seems like the groupName is empty string. Do you get any results when you run this db.objects.findOne({_key: "group:"});

Also what is the output of db.objects.find({_key: "groups:visible:createtime"});

Brophy

Any particular place I need run these commands?

<baris>

They are mongodb commands so you need to run them in the mongodb cli.

Brophy

@baris said in Issue since upgrading to v1.13.1 from v1.12.1:

They are mongodb commands so you need to run them in the mongodb cli.

Cheers.

I get null when trying the first command, however the second command, I can see it:

{ "_id" : ObjectId("5e1325a7537d3e019983f145"), "_key" : "groups:visible:createtime", "value" : "Secret Service Civilian Support", "score" : 156698449111 }

<baris>

db.objects.find({_key: "groups:visible:createtime"}) This command should more than one group. Did you run it with findOne?

Brophy

@baris apologies.

{ "_id" : ObjectId("5ce138cbc1da64d7facecb4a"), "_key" : "groups:visible:createtime", "value" : "raceTECH", "score" : 1524588500140 }
{ "_id" : ObjectId("5ae768e33d599553d893c40b"), "_key" : "groups:visible:createtime", "value" : "ZIP - Planning and Construction", "score" : 1525115107374 }
{ "_id" : ObjectId("5cab2408c1da64d7faed93ea"), "_key" : "groups:visible:createtime", "value" : "Vice President of the United States", "score" : 1554719752190 }
{ "_id" : ObjectId("5df6a1b5537d3e019936632f"), "_key" : "groups:visible:createtime", "value" : "Undisputed Command", "score" : 1572714730874 }
{ "_id" : ObjectId("5ae77e803d599553d8949bfa"), "_key" : "groups:visible:createtime", "value" : "Underground Empire", "score" : 1525120640777 }
{ "_id" : ObjectId("5c5cdd18e8b6f11c5dea94fe"), "_key" : "groups:visible:createtime", "value" : "Tuga Thugs", "score" : 1524578793375 }
{ "_id" : ObjectId("5adf6ab274ce3af1875b617d"), "_key" : "groups:visible:createtime", "value" : "The Strike Team", "score" : 1524591282624 }
{ "_id" : ObjectId("5adf48f174ce3af18754ef29"), "_key" : "groups:visible:createtime", "value" : "The Outfit", "score" : 1524582641942 }
{ "_id" : ObjectId("5b0966c1bed7de4afa2c7c0f"), "_key" : "groups:visible:createtime", "value" : "The Motor Heads - TMH", "score" : 1527342785842 }
{ "_id" : ObjectId("5b11438fbed7de4afa9134f4"), "_key" : "groups:visible:createtime", "value" : "The Company™", "score" : 1524574028968 }
{ "_id" : ObjectId("5cab243cc1da64d7faeda237"), "_key" : "groups:visible:createtime", "value" : "Senator", "score" : 1554719804302 }
{ "_id" : ObjectId("5cf4dfdfc1da64d7fafc690e"), "_key" : "groups:visible:createtime", "value" : "San Andreas Studios", "score" : 1559551967405 }
{ "_id" : ObjectId("5b566dc772369ed61a0e844f"), "_key" : "groups:visible:createtime", "value" : "San Andreas Pirates", "score" : 1532390855580 }
{ "_id" : ObjectId("5adf4ab574ce3af18755625f"), "_key" : "groups:visible:createtime", "value" : "San Andreas Medics", "score" : 1524583093204 }
{ "_id" : ObjectId("5adf4af174ce3af1875571c5"), "_key" : "groups:visible:createtime", "value" : "San Andreas Interceptors", "score" : 1524583153432 }
{ "_id" : ObjectId("5d3ecdbdc1da64d7faafaed1"), "_key" : "groups:visible:createtime", "value" : "San Andreas Housing Agency", "score" : 1524581956949 }
{ "_id" : ObjectId("5b1c02b7bed7de4afa8ddf0f"), "_key" : "groups:visible:createtime", "value" : "San Andreas Fire Department", "score" : 1526316657237 }
{ "_id" : ObjectId("5adf02f1490cc291313f17fa"), "_key" : "groups:visible:createtime", "value" : "San Andreas Federal Police", "score" : 1524564721648 }
{ "_id" : ObjectId("5dd839db537d3e01990b1866"), "_key" : "groups:visible:createtime", "value" : "SAPD Staff", "score" : 1524588652787 }
{ "_id" : ObjectId("5adf40d974ce3af1875388b7"), "_key" : "groups:visible:createtime", "value" : "SAPD PC Qualified Officers", "score" : 1524580569742 }
{ "_id" : ObjectId("5dd83a65537d3e01990b4789"), "_key" : "groups:visible:createtime", "value" : "SAPD HQ", "score" : 1524580435974 }
{ "_id" : ObjectId("5c60ceb4e8b6f11c5d8d8432"), "_key" : "groups:visible:createtime", "value" : "SAPA Instructors", "score" : 1549848244753 }
{ "_id" : ObjectId("5ade36f9490cc291313b9dd7"), "_key" : "groups:visible:createtime", "value" : "SAPA", "score" : 1524512404265 }
{ "_id" : ObjectId("5adf12fe74ce3af1874f20c9"), "_key" : "groups:visible:createtime", "value" : "SAES Probationary", "score" : 1524568830350 }
{ "_id" : ObjectId("5adf129c74ce3af1874f043b"), "_key" : "groups:visible:createtime", "value" : "SAES Member", "score" : 1524568732912 }
{ "_id" : ObjectId("5b3b279a72369ed61ae11ee7"), "_key" : "groups:visible:createtime", "value" : "SAES Inactive & Retired", "score" : 1530603418795 }
{ "_id" : ObjectId("5d56942dc1da64d7fa87a89a"), "_key" : "groups:visible:createtime", "value" : "SAES HQ Leader", "score" : 1565954960575 }
{ "_id" : ObjectId("5ad8896b490cc2913126b546"), "_key" : "groups:visible:createtime", "value" : "SAES HQ", "score" : 1524140395459 }
{ "_id" : ObjectId("5d473c62c1da64d7fab414f3"), "_key" : "groups:visible:createtime", "value" : "SAES Group Manager", "score" : 1564949480428 }
{ "_id" : ObjectId("5d473dd8c1da64d7fab46575"), "_key" : "groups:visible:createtime", "value" : "SAES Gang Managers", "score" : 1524568843789 }
{ "_id" : ObjectId("5c878e42e8b6f11c5d0d8550"), "_key" : "groups:visible:createtime", "value" : "SAES Developer", "score" : 1528062391713 }
{ "_id" : ObjectId("5adf132e74ce3af1874f2bb4"), "_key" : "groups:visible:createtime", "value" : "SAES Community Staff", "score" : 1524568878956 }
{ "_id" : ObjectId("5adf5a3174ce3af18758baf9"), "_key" : "groups:visible:createtime", "value" : "S.W.A.T.", "score" : 1524587057067 }
{ "_id" : ObjectId("5c555c7055e78db8904a2981"), "_key" : "groups:visible:createtime", "value" : "Rebels MC", "score" : 1549069277599 }
{ "_id" : ObjectId("5ba2898472369ed61ac2a534"), "_key" : "groups:visible:createtime", "value" : "Radio SA", "score" : 1537378692836 }
{ "_id" : ObjectId("5cab23fec1da64d7faed9368"), "_key" : "groups:visible:createtime", "value" : "President of the United States", "score" : 1554719742901 }
{ "_id" : ObjectId("5ced211ac1da64d7fa2057c4"), "_key" : "groups:visible:createtime", "value" : "PENSource", "score" : 1559044378247 }
{ "_id" : ObjectId("5b688d9772369ed61a0216f9"), "_key" : "groups:visible:createtime", "value" : "OverdoseCrime", "score" : 1533578647558 }
{ "_id" : ObjectId("5d6c74bec1da64d7fa522bcc"), "_key" : "groups:visible:createtime", "value" : "Outbreak Organization", "score" : 1554280076237 }
{ "_id" : ObjectId("5adf075a490cc291313f61a4"), "_key" : "groups:visible:createtime", "value" : "Organization Zero", "score" : 1524565850308 }
{ "_id" : ObjectId("5d42e53ac1da64d7fa2e148b"), "_key" : "groups:visible:createtime", "value" : "Mongols MC", "score" : 1564665146822 }
{ "_id" : ObjectId("5c3bc3bd55e78db890903f45"), "_key" : "groups:visible:createtime", "value" : "Military Academy", "score" : 1524569770061 }
{ "_id" : ObjectId("5dbc132771ce78c2acb4e4e3"), "_key" : "groups:visible:createtime", "value" : "Lounge Venture Capital", "score" : 1525114630332 }
{ "_id" : ObjectId("5dbdb89871ce78c2acebadfc"), "_key" : "groups:visible:createtime", "value" : "Los Escondidos", "score" : 1572714648446 }
{ "_id" : ObjectId("5adf3c4e74ce3af18752afa9"), "_key" : "groups:visible:createtime", "value" : "Lightning World Sports", "score" : 1524579406230 }
{ "_id" : ObjectId("5e14765f537d3e0199e72851"), "_key" : "groups:visible:createtime", "value" : "La Confrérie Des Lions", "score" : 1578399327824 }
{ "_id" : ObjectId("5e0f1207537d3e0199ab8cec"), "_key" : "groups:visible:createtime", "value" : "Izanagi Clan", "score" : 1578045959973 }
{ "_id" : ObjectId("5adf5ec474ce3af18759524a"), "_key" : "groups:visible:createtime", "value" : "InvestArms Corporation", "score" : 1524588228679 }
{ "_id" : ObjectId("5ae829a13d599553d8998712"), "_key" : "groups:visible:createtime", "value" : "ICE-Immigration & Customs Enforcements", "score" : 1525164449847 }
{ "_id" : ObjectId("5be04a4929b9cb7f9916f4de"), "_key" : "groups:visible:createtime", "value" : "Honorary Members", "score" : 1541425737586 }
{ "_id" : ObjectId("5df92031537d3e019994058a"), "_key" : "groups:visible:createtime", "value" : "Global Express Trucking Company", "score" : 1576607012266 }
{ "_id" : ObjectId("5d94808371ce78c2ac441d53"), "_key" : "groups:visible:createtime", "value" : "Five-0", "score" : 1570013314995 }
{ "_id" : ObjectId("5adf2f0674ce3af187513e3e"), "_key" : "groups:visible:createtime", "value" : "Federal Bureau of Investigation", "score" : 1524576006273 }
{ "_id" : ObjectId("5e1325a7537d3e019983f145"), "_key" : "groups:visible:createtime", "value" : "Secret Service Civilian Support", "score" : 1566984491111 }
{ "_id" : ObjectId("5b168e12bed7de4afa79e48e"), "_key" : "groups:visible:createtime", "value" : "FOX Operations X", "score" : 1524591677579 }
{ "_id" : ObjectId("5d42be30c1da64d7fa281d14"), "_key" : "groups:visible:createtime", "value" : "Emergency Task Force", "score" : 1564655152802 }
{ "_id" : ObjectId("5ae54a953d599553d88b3ec0"), "_key" : "groups:visible:createtime", "value" : "Donator", "score" : 1524976277754 }
{ "_id" : ObjectId("5adf1dca74ce3af1875010ea"), "_key" : "groups:visible:createtime", "value" : "Desert Eagles", "score" : 1524571594113 }
{ "_id" : ObjectId("5af9de54bed7de4afaecc6c9"), "_key" : "groups:visible:createtime", "value" : "Cunning Stunts", "score" : 1526324820946 }
{ "_id" : ObjectId("5addffa1490cc291313aae1f"), "_key" : "groups:visible:createtime", "value" : "Cuban Liberation Organisation", "score" : 1524498337488 }
{ "_id" : ObjectId("5b1018a5bed7de4afa65ba34"), "_key" : "groups:visible:createtime", "value" : "Cuban Cars", "score" : 1527781541973 }
{ "_id" : ObjectId("5b8d3f6472369ed61a6da503"), "_key" : "groups:visible:createtime", "value" : "CripZ~", "score" : 1526137993174 }
{ "_id" : ObjectId("5adf4a7674ce3af1875553ec"), "_key" : "groups:visible:createtime", "value" : "Comando da Capital", "score" : 1524583030994 }
{ "_id" : ObjectId("5c2df93f55e78db8902e957a"), "_key" : "groups:visible:createtime", "value" : "Cluckin' Bell", "score" : 1545065592387 }
{ "_id" : ObjectId("5d42e5e1c1da64d7fa2e2f58"), "_key" : "groups:visible:createtime", "value" : "Clandestine Mob", "score" : 1564665313523 }
{ "_id" : ObjectId("5d48d190c1da64d7fae84398"), "_key" : "groups:visible:createtime", "value" : "Centrino Transportation", "score" : 1524586184374 }
{ "_id" : ObjectId("5dbdfa6271ce78c2acf6705c"), "_key" : "groups:visible:createtime", "value" : "BloodZ ", "score" : 1572714552973 }
{ "_id" : ObjectId("5cf76822c1da64d7fa4c0552"), "_key" : "groups:visible:createtime", "value" : "Black Eagle Security", "score" : 1524565304440 }
{ "_id" : ObjectId("5b1339bcbed7de4afa400a9d"), "_key" : "groups:visible:createtime", "value" : "Black Bullets", "score" : 1527966050461 }
{ "_id" : ObjectId("5de14570537d3e01994e09b6"), "_key" : "groups:visible:createtime", "value" : "Bandidos MC", "score" : 1564654823386 }
{ "_id" : ObjectId("5ade263d490cc291313b5593"), "_key" : "groups:visible:createtime", "value" : "Arms Assassins", "score" : 1524508221507 }
{ "_id" : ObjectId("5ae1248c74ce3af1876fe5ab"), "_key" : "groups:visible:createtime", "value" : "All Load Trucking", "score" : 1524571511438 }
{ "_id" : ObjectId("5dbb216971ce78c2ac9985bf"), "_key" : "groups:visible:createtime", "value" : "Al-Munazama", "score" : 1562497227850 }

<baris>

Are those all the groups you have? You can compare that list to the ones you see on the /groups page and find the missing one. Then it is a matter of recreating that groups object.

Brophy

Hi @baris thanks for the help.

Do you mean I need to re-create it on the admin panel? I've tried to re-add it but it won't allow me.

The group in question is Secret Service Civilian Support

I get

Uh-Oh

There was a problem creating your group. Please try again later!

<baris>

@Brophy said in Issue since upgrading to v1.13.1 from v1.12.1:

Secret Service Civilian Support

Try creating this group in the mongodb cli. To see what fields you need you can load one of the other groups with

db.objects.findOne({_key: "group:raceTECH"});