Private git clone installs for plugins.

Joykiller

I was installing in node_modules, works fine. I also did npm install --production on each git clone for each plugin ive done.

But when I go to install a new plugin from ACP backend it always deletes / removes all the folders in node_modules that i had git cloned previously thus resetting entire plugins.

What am I doing wrong?

Joykiller

I setup a private repo on npm, still having same issue this is strange.. Anyone had this issue before?

When you install a plugin and some reason others get removed? Mind you im using Dev atm to make sure everything works maybe theres something wrong with that?

Seems the private NPM installs by cli are still installed, but the ACP installs get removed.

Joykiller

@staff So yeah, It seems my bug has to do with ONLY installs by ACP, If i install any plugin by the back end it automaticllay removes all of them EXCEPT for the ones done by cli. Anyone know why this is the case? Uninstalling from ACP is pretty much the same as installing fyi. Unless its from ssh/cli

teh_g

@joykiller What version of node/npm are you using? I think node v8 does this, I'd recommend going back to the LTS version.

PitaJ

@teh_g the reason it happens with node 8 is that npm@5 comes with node 8. This issue is caused by npm@5

Joykiller

@teh_g said in Private git clone installs for plugins.:

@joykiller What version of node/npm are you using? I think node v8 does this, I'd recommend going back to the LTS version.

@pitaj said in Private git clone installs for plugins.:

@teh_g the reason it happens with node 8 is that npm@5 comes with node 8. This issue is caused by npm@5

Ah thought might have something to do with that.

What node should I use n with for Nodebb? I run it as a service so ill just update the startup link. Currently using the following:
$ npm --version
5.3.0
$ node --version
v8.4.0

julian

6 is recommended at this time.

PitaJ

Node 8 and npm@5 can work with custom plugins, but you should be using [email protected] minimum and npm link.

Let's say you have a directory called web with the nodebb directory within it. Clone your custom plugin repositories into web (so there's, for instance web/nodebb-plugin-customized-by-you), and then run npm link inside the plugin repository directory, and then npm link nodeb-plugin-customized-by-you in the nodebb directory.

julian

@pitaj npm@5 has lockfiles no? Perhaps we should use that... Or yarn.lock...

Joykiller

@julian said in Private git clone installs for plugins.:

@pitaj npm@5 has lockfiles no? Perhaps we should use that... Or yarn.lock...

Yeah theres lock files.

Joykiller

Ok using 6.11.0 LTS and works again no problems. Thx.