@baris said in Proper way to return res.redirect('')?:

@Joykiller said in Proper way to return res.redirect('')?:

Cannot set headers after they are sent to the client

This usually means res.send or res.redirect was already called and you are calling it again. What is the rest of the code?

Probably would help huh, sorry about that.

So I'm editing the Stripe Plugin for subs, which was based on the paypal system.
Trying to add a new field to check before it goes to the onsubscription function.

// get value
stripe.isValueID = async function(uid, callback) {
  user.getUserField(uid, 'valueId', callback);
};

stripe.subscribe = async function(req, res, next) {
var uid = req.user.uid;


// this part breaks because of header shit.
stripe.isValueID(uid, function(err, isValueID) {
  //console.log(isValueID);
  // if(!isValueID) {
    //return helpers.redirect('/?subscribe=fail');
    //return notAllowed(req, res);
    //return res.redirect('/?subscribe=fail');
  //}
});

https://github.com/edthefifth/nodebb-plugin-stripe-subscriptions/blob/master/lib/stripe.js
around line 62. but each time i check the if conditional it triggers the sent headers issue.

Community

Joykiller