Skip to content
  • 1 Votes
    3 Posts
    1k Views
    PitaJP

    @girish there may be something wrong with your dns. I can access that link just fine.

  • 2 Votes
    9 Posts
    2k Views
    barisB

    Tags allow % character now, themes will need to be updated to use tags.valueEncoded instead of tags.valueEscaped
    https://github.com/NodeBB/NodeBB/issues/10135

    See changes in persona to update your custom theme https://github.com/NodeBB/nodebb-theme-persona/commit/6aada9127865ddc1cbaf8cd5f548ebc78f7bf90a

  • 4 Votes
    7 Posts
    1k Views
    barisB

    plugins.registerHook removed, use plugins.hooks.register
    plugins.unregisterHook removed, use plugins.hooks.unregister
    plugins.fireHook removed, use plugins.hooks.fire
    plugins.hasListeners removed, used plugins.hooks.hasListeners

    Link Preview Image fix: push back some deprecations, remove deprecated stuff scheduled f… · NodeBB/NodeBB@dd4e66e

    Node.js based forum software built for the modern web - fix: push back some deprecations, remove deprecated stuff scheduled f… · NodeBB/NodeBB@dd4e66e

    favicon

    GitHub (github.com)

  • 2 Votes
    10 Posts
    3k Views
    barisB

    Link Preview Image account/edit.tpl form is still coded in older bootstrap style · Issue #9364 · NodeBB/NodeBB

    The template and client-side parsing logic has not been changed in about 6 years. It looks to be BS2 code. It is also not flexible enough and makes themes adding profile fields harder than necessary. A theme would need to edit the templa...

    favicon

    GitHub (github.com)

  • 2 Votes
    5 Posts
    1k Views
    julianJ

    We have received reports that after upgrading to v1.16.0, the amount of websocket connections is very high relative to pre-upgrade

    This is due to older socket.io clients (running on version 2) attempting to connect to the new socket.io 3. These protocols are incompatible, and so the connection is rejected, and NodeBB was configured to try indefinitely.

    This is ok. Over time, as your users close their browser windows (or refresh), they will automatically start using the latest version, and socket usage will return to normal levels.

    If you are worried about the excessive traffic, you can configure a nginx condition to drop requests with the query string ?EIO=3. Please see the issue linked above for more information.

  • 3 Votes
    23 Posts
    3k Views
    A

    @baris Thanks, that was this ! This problem is solved now. 🙂

  • 2 Votes
    3 Posts
    558 Views
    barisB

    Link Preview Image get rid of category.image/category.backgroundImage · Issue #8386 · NodeBB/NodeBB

    For reasons unknown there are two fields for this image.

    favicon

    GitHub (github.com)

  • 6 Votes
    5 Posts
    1k Views
    D

    Apparently the Calendar Plugin:

    nodebb-plugin-calendar
    Calendar and events for NodeBB

    Installed 1.0.0-alpha.50 | Latest 1.0.0-alpha.50

    Does not work with 1.13.0

    Can someone please update it?

  • 2 Votes
    2 Posts
    2k Views
    barisB

    Theme Breaking Change
    https://github.com/NodeBB/NodeBB/pull/7109

  • 0 Votes
    15 Posts
    3k Views
    PitaJP

    @faizanzahid the current version of NodeBB still has compatibility with those plugins. Future version will not.

  • 1 Votes
    3 Posts
    3k Views
    attisA

    Hi,
    I think I have discovered another breaking change that you didn't mention, though it is probably super-niche.

    This commit: https://github.com/NodeBB/NodeBB/commit/ec91ef1c644044bba44198b031913655e784b4bb
    broke our custom SSO plugin. The result was that after successfully logging in our external identity provider and being redirected to our Forum's callback endpoint, I was ending up not logged in (the button in the header still said "Log in") and stuck on /register/complete roadblock. It looked like our Passport strategy verify callback, that parses output from the identity provider and fetches user data via OAuth2 was not invoked at all.

    It turns out that the changes in this commit don't play well together with passport-oauth2 (https://github.com/jaredhanson/passport-oauth2) internal ability to protect against CSRF (which we were using). This strategy was already using state parameter to pass its own CSRF token. I don't have more time to investigate but I suspect things shipwrecked when NodeBB overwrote the state parameter with its own CSRF token.

    Turning off passport-oauth2 internal CSRF protection (by removing state: true from its options) fixed the issue.

  • 0 Votes
    1 Posts
    1k Views
    barisB

    Please see the following issues for breaking changes to plugins and themes.

    https://github.com/NodeBB/NodeBB/issues?utf8=✓&q=is%3Aissue+milestone%3A1.9.0+label%3A"breaking+change+(themes)"+
    https://github.com/NodeBB/NodeBB/issues?q=is%3Aissue+milestone%3A1.9.0+label%3A"breaking+change+(plugins)"

    If you have plugins that are affected, please update your plugin and add the below to your package.json

    "nbbpm": { "compatibility": "^1.9.0" }

    to your package.json.

  • 2 Votes
    7 Posts
    4k Views
    barisB

    @jw-sbat Always make sure the plugins you are using are working fine before deploying to production. Even if the plugin doesn't specify compatibility directly it could still work. That property specifies a minimum nodebb version.

  • 2 Votes
    3 Posts
    4k Views
    barisB

    Due to changes introduced to loading javascript assets in 1.7.0, using jquery in widgets requires waiting for the page load event.

    Sample widget for 1.7.0+

    if (window.jQuery) { doStuffThatUsesJquery(); } else { window.addEventListener('load', doStuffThatUsesJquery); }
  • 2 Votes
    4 Posts
    4k Views
    julianJ

    Just an update to those following this post, that NodeBB v1.6.0 has entered the feature freeze portion of the launch as of 31st of August 2017

    Code Freeze is schedued for this Thursday (7th of September), with a launch a week later, on the 14th of September.

    🎉

  • 3 Votes
    2 Posts
    4k Views
    julianJ

    As of v1.4.4 nconf.get('upload_path'); is no longer a relative path pointing to the uploas directory, it is now an absolute path to the uploads directory. Change introduced in commit aaacdb8413c9bc3f3d47c249c0d0287eac1cad88

  • 2 Votes
    1 Posts
    1k Views
    barisB

    Please see https://github.com/NodeBB/NodeBB/pull/4662

    If you have a custom theme that has a partials/topic/watch.tpl you will need to update it for 1.1.0.

    You can see the changes you need to make in https://github.com/NodeBB/nodebb-theme-persona/pull/278/files

    Persona, vanilla and lavender themes are already updated.

  • 5 Votes
    1 Posts
    2k Views
    barisB

    Related issue https://github.com/NodeBB/NodeBB/issues/4587

    As discussed in the issue, we had a bunch of hooks to modify a page on some routes like filter:recent.build. These were added as required but most pages didn't have a hook so if you needed one you would have to ask us to add it and wait for the next release. With the above change every route has a hook. The hook name is derived from the template name passed to the res.render(template, data); method. For example if your template is named myAwesomePage, you render it with res.render('myAwesomePage', data); and the hook that will be fired is filter:myAwesomePage.build

    Every hook gets 3 parameters {req: req, res: res, templateData: data}, data is the parameter you pass into the res.render method.

    We had a few inconsistencies in the parameters passed to the hook and the hook name below are the changes that needs to be fixed if you have a plugin that is listening to these hooks.

    filter:groups.build is now called filter:group/details.build as that is the correct name for that template. filter:popular.build used to pass in a extra term parameter, this moved into the templateData parameter. filter:header.build this is removed it was deprecated a while ago. Use filter:navigation.available instead. filter:search.build parameters changed, data is no longer passed in use req.query and req.params instead. results is now the templateData parameter.

    Feel free to ask any questions if anything isn't clear.

  • timestamp change

    NodeBB Development
    3
    0 Votes
    3 Posts
    2k Views
    N

    But... It's a breaking change.
    You should not do such stuff when you have now 1.0

  • 3 Votes
    10 Posts
    8k Views
    S

    0_1457071644710_nbb1.0.0.PNG

    No announcement thread in the announcements section?

    Congratulations, guys! NodeBB has come a long way.