Finally, I made it simpler...

I made a link from /toto/myfiles to public/uploads/myfiles. Then, I wrote this app.get code in my plugin :

app.get('/uploads/myfiles/:file(*?)', function (req, res) {
		// Things TODO with req.params.file for permissions (after work on it)...
		var longfilename = path.resolve('public' + req.url);
		if (fs.existsSync(longfilename)) {
			res.status(200);
			res.sendFile(longfilename);
		} else {
			console.log('Fichier non trouvé');
			res.status(404);
			res.render('404', {path: req.path});
		}
	});

Now, there is no problem with the ajaxify thing... Ouf !

I'm going to open another topic for another question about the 404 error rendering...

@PitaJ Ok ! I do it now.

Thanks ! I had tried this before but something else was wrong.

Now, everything is ok !!! Thanks again !

Hello @yariplus,

Is your plugin compatible with nodebb 1.10.1 ? I can't get widgets working on my site. Thanks in advance for your answer.

Hello !

On this forum (and also mine...), there is no pagination-block visible when we are on /recent or /popular for example.

Is there a simple way to make it working on my forum ?

Thanks in advance.

@PitaJ Thanks ! Success !!!

composer.tpl needed to be in /node_modules/nodebb-theme-oxide-YA/templates/ and not in /node_modules/nodebb-theme-oxide-YA/templates/modules...

Sorry

Must I write a request for nodebb-plugin-composer-default for this :
On small screens, it would be great to be able to replace the write-container with the preview-container on clicking "show preview" and revert to write-container on clicking "show editor" ?

Hello !

I need to change some bootstrap classes in custom-page.tpl (to change sidebar dynamical width for example as I have already done it in my own theme templates files). I can do it directly in nodebb-plugin-custom-pages/templates/custom-page.tpl but it will be replaced on each package upgrade... Not great !

Is there another way to do it without this problem ?

Thanks in advance !

@baris Strange... I don't find timeago_later in nodebb...

Another missing translation :
pages:account/latest-posts

on user profile page.

@baris OK. Is it in the core or in a plugin ? What is the English version ? I can give you a french translation if necessary...

Hello !

I see this thing between some posts on this forum :

Where does it come from ? I think there is a problem with "TOPIC:TIMEAGO_LATER" that is showing...

@baris Thanks !!

Hello !

I'm writing a plugin where I do this :

app.get('/uploads/myfiles/:file(*?)', function (req, res) {
		// Things TODO with req.params.file for permissions (after work on it)...
		var longfilename = path.resolve('public' + req.url);
		if (fs.existsSync(longfilename)) {
			res.status(200);
			res.sendFile(longfilename);
		} else {
			console.log('Fichier non trouvé');
			res.status(404);
			res.render('404', {path: req.path});
		}
	});

When a file is not found, I return a 404 error page with the last "else". It works in a ugly way because of no 404.tpl file... How can I call a standard nodebb error page for this 404 error ? What is the good res.render command (or else) ?

Finally, I made it simpler...

I made a link from /toto/myfiles to public/uploads/myfiles. Then, I wrote this app.get code in my plugin :

app.get('/uploads/myfiles/:file(*?)', function (req, res) {
		// Things TODO with req.params.file for permissions (after work on it)...
		var longfilename = path.resolve('public' + req.url);
		if (fs.existsSync(longfilename)) {
			res.status(200);
			res.sendFile(longfilename);
		} else {
			console.log('Fichier non trouvé');
			res.status(404);
			res.render('404', {path: req.path});
		}
	});

Now, there is no problem with the ajaxify thing... Ouf !

I'm going to open another topic for another question about the 404 error rendering...

@julian said in Download file with app.get problem:

I would look into using express.static to mount a directory and have it accessible as a route.

I will give it a try but will it prevent the ajaxify problem raised by @baris at the begining of its answer ?

Also, files will not be public ? I want to serve files only after tests of permissions...

@baris said in Download file with app.get problem:

NodeBB probably treats that url like a normal page since it doesn't start with /uploads or /assets/uploads and it tries to ajaxify to that page. https://github.com/NodeBB/NodeBB/blob/master/public/src/ajaxify.js#L395

So is there a way to prevent this or another way to do what I want ? I need to make links to files that are not in nodebb folder (I don't want users to be able to directly download them like when they are in public/uploads because I will check some specific permissions before...). Note also that files will change so it must work without restarting nodebb...

You also have to be careful with allowing access to the filesystem and make sure users can only download from the myfiles folder. Ie if someone manages to pass in req.params.file = ../nodebb/config.json they might download your config.json file.

Yes. It will be a part of my plugin.

Hello !

I have a file (among others) in a specific folder outside of nodebb (for example /toto/myfiles/filetoget ; nodebb executable is in /toto/nodebb folder).

I want to be able to download the /toto/myfiles/filetoget file with the route "/myfiles/filetoget". For this, I use the following code (in the static:app.load hook) in a plugin :

app.get('/myfiles/:file(*?)', function (req, res) {
                // absolute path to the file to get
		var absolutefile = path.dirname(process.cwd()) + '/myfiles/' + req.params.file;

		if (fs.existsSync(absolutefile)) {
			res.status(200);
			res.sendFile(absolutefile);
		} else {
			console.log('File not found');
			res.status(404);
			res.render('404', {path: req.path});
		}
});

It works when I full load page http://127.0.0.1:4567/myfiles/filetoget but it doesn't work when I click on a link with 'myfiles/filetoget' (showing also the full address http://127.0.0.1:4567/myfiles/filetoget on a nodebb page). I have a page of nodebb saying the page is not found and there is no particular message in the console.

How can I solve this problem ? (I do this because I will do other things (permissions...) before the download of the file in my plugin).

I will also link these files in admin/manage/categories/** as external link (I hope it's possible)...

If I use a wrong way, how can I make relative links (routes) in nodebb to files outer from nodebb folder ?

Thanks in advance for help !

@JJSagan Thanks for your answer. I tried it but it was making things bad on reloading the page or loading other pages. I will not use datatables (and it will be easier for me on future updates).