NodeBB v1.4.0 Release

[Jenkler]

@phit said in NodeBB v1.4.0 Release:

custom pages

minor issue with custom pages <-- Plz, explain, missing data?

[phit]

@Jenkler https://github.com/psychobunny/nodebb-plugin-custom-pages/pull/42
basically if you don't have a sidebar the main content widget won't fill the whole page due to some changes in 1.3.x

[Jenkler]

But you have a patch for it, @psychobunny needs to merge the pull requests?

[psychobunny]

Merged, thank you @phit

[revir]

wonderful.

[Jenkler]

I have updated to 1.4.2 now and everything seams to work except nodebb-plugin-custom-homepage in 100% width

[Jenkler]

@phit same issue with nodebb-plugin-custom-homepage

Is it possible to use the same patch?

[tedbaker]

Hi,

I have upgraded from v1.3 to 1.4, then 1.4.1, 1.4.2, it all appears to have gone successfully from the front end side. Awesome job, very smooth from a setup side

However admin, seems to have lost a lot of it's language localization strings....

Note this is only a few examples, there are loads.

Anyone else experience this issue? Did I do something wrong? Any way to fix it?

Thanks

Ted

[PitaJ]

@tedbaker what language do you have selected in your user profile?

[tedbaker]

@PitaJ Thanks for your reply, I currently have en-US. I did have en-GB but I changed it earlier to see if it was that but no difference

[PitaJ]

@tedbaker no difference between en-US and en-GB huh? Any errors or warnings when you run in dev mode? Does this occur both on cold load and when switching pages?

[tedbaker]

@PitaJ No, no difference between en-US and en-GB, this is only in admin (ACP) though. The front-end is fine.

In dev mode I receive no errors in the terminal console or in the error log in Advanced in the ACP.

In the Chrome console when running in dev mode I get

Which would explain the issues. I can see these files in the /public/language/en-US/admin and en-GB folder

Thanks

Ted

[PitaJ]

@tedbaker are you accessing NodeBB directly or through a reverse proxy?

[tedbaker]

@PitaJ Thanks again, I use nginx for the URL, however I just checked and if i access through the direct IP and port the problem is not present. I assume that would mean there is some missing configuration but I am unsure of how to fix it, I am still learning node and nginx so any pointers appreciated

[PitaJ]

@tedbaker check out this post:

https://community.nodebb.org/post/57396

It addresses the same issue.

[tedbaker]

@PitaJ sorry I should have looked a little harder first I just noticed other people putting issues in here. That post fixed my issue. Thanks ever so much!