User Icons Testing
-
@julian Nice color selection.
-
@julian Thanks for explaining, that sounds reasonable to me!
Regarding the avatars on the users page https://community.nodebb.org/users
For me, it seems only some are loading. I see a lot of blank white space where an avatar should be. Also if I scroll down the page I see the mystery man instead of the new "letter" icon.
Is this just me? I'm currently using latest Chrome on Chrome OS.
-
@henrywright said:
Yup,
.user-icon
is the offending class andline-height
is the offending property.@pitaj @henrywright So yeah, changing this
line-height
to31px
fixes the issue. Fucking CSS, indeed. -
Thanks everybody for bug testing the user icons The branch was getting a little stale and I had to re-do bits and pieces of it as they conflicted with
master
User Icons have landed in
master
!Best of all, the user icons are all generated via CSS! No image processing required (though that was a possible avenue we considered but decided against).
Guide to implementing this in your own custom themes/plugins
forthcoming.https://community.nodebb.org/topic/6583/0-9-0-breaking-changes/12 -
Looking forward to testing this out!
-
Guys, please... NodeBB already looks amazing can we stop making it more amazing... Since I'm totally in love with the new profile page's
Edit: did you also brighten up the colors for online, away and such? -
@psychobunny should take credit for the user profile revamps
They look a little bit like @pichalite's theme
-
@Kowlin said:
Guys, please... NodeBB already looks amazing can we stop making it more amazing... Since I'm totally in love with the new profile page's
Edit: did you also brighten up the colors for online, away and such?Okay, I'm going on vacation then
and yeah, up to now the status indicators were using the default bootstrap colours which is criminal IMO