[nodebb-plugin-desktop-notifications] Desktop Notifications (like GMail)

cani

I must be doing something wrong, same error just like 24 now
if (data.text) {

psychobunny

oh I get it. you need to update nodebb to this commit at minimum:

https://github.com/designcreateplay/NodeBB/commit/5db27a835f3293ca8b3fd7efc0c63fe11af82b0a

here's what's blocking you:

https://github.com/designcreateplay/NodeBB/commit/dc4aeca4278cbd2b30aff9bb1a3ed12334676149

that's why data is undefined

cani

That did the trick, Thank you!

psychobunny

np, I should have realized. you might have noticed its been activated on the community forum as well

trevor

i see.

quahfamili

@psychobunny I wanna ask something on mobile. Does it work with safari on iOS? also, i just tried on chrome does not seems to work.

julian

@quahfamili you may have to clear your browser cache to see it

trevor

var logo = $('.forum-logo').attr('src');

I don't want to use the forum logo, can I use a custom image for this?

psychobunny

maybe in the future I could add a way to upload a new picture. for now you could just take that line and replace it with any valid url ex.

var logo = 'http://domain.com/image.png';

trevor

Ooo yeah that works.

psychobunny

damn desktop notifications! haha. this is going to get annoying eventually

trevor

Hah, perhaps in the future.

Steve

thanks! will install tonight

bentael

Chris

This is great. Has anyone else noticed they get double notifications? I do, at least on these boards.

Good work thanks very much for this.

julian

@theepiphany Yes, I am seeing those too (and it's a little more annoying on Linux, as they do not auto-fade).

@psychobunny?

psychobunny

hmmmm, I wonder if its because you have two windows open

Chris

@psychobunny nope, that is the first thing i checked.

Chris

@psychobunny Update to this: I've noticed duplicate notifications and old notifications popping up when I have two different nodebb forums open. Ie - this one and mine. I got a reply to a post on my forum and two notifications from this one also popped up - even though they were not new.

psychobunny

Interesting... okay. Thanks for looking into this! @julian and @trevor have been on my back to update this plugin as well so I should take a look at it soon