[nodebb-plugin-ns-spoiler] NS Spoiler

[Nicolas]

NodeBB: Spoiler

Spoiler. Ability to control visibility of the content in posts. Works better with Markdown syntax. Integrates with default composer, so you will have additional button on toolbar.

Compatibility Note: should work with 0.8 and 0.9. Tested on 0.8.

Useful links:

• Plugin
• How to use

Preview:

https://youtu.be/VftunF4xp9o

[Bri]

Niiice!

A small ask: how hard would it be to change the syntax to the same thing in @psychobunny s plugin? Something like

>!

[Nicolas]

My solution is based on CommanMark conversation, about how Markdown Spoiler should look like.
I'm more inclined in direction of colons, than variation of blockquote. So this question is more about vision and not about a complexity

[exodo]

Finally spoiler that nodebb deserved. Much apreciated
Does it work with 0.7?

[Nicolas]

@exodo It should work with 0.7 also. I didn't test, but at a glance I don't see issues why it will not work.

[exodo]

@Nicolas said:

@exodo It should work with 0.7 also. I didn't test, but at a glance I don't see issues why it will not work.

Confirmed to work on 0.7 like a charm

[산도]

I have a problem when URL is in the spoiler.
Is this bug or is there way to fix it?
Thank you

[Nicolas]

I have checked with both types of URLs, seems everything is OK with URLs in spoiler:

[frissdiegurke]

@산도 Looks like you've missed a whitespace between the URL and closing :::.
I guess this is needed in order to work properly, that it's half-way working should be considered a bug.
(everything just concluded of his/her screenshot didn't test anything)

[jdk1811]

I am actually having a similar issue. I am guessing it's messing up with youtube plugin.

:::
--some tex1t--
youtube link
--some text2--
:::

If I do this, spoiler button and some text1 disappears,

and youtube, some_text2 does not get into the spoiler and shows up

[phl]

I really love the plugin, installed it and it works fine for me!

However, when writing an announcment for my forum that spoilers are now supported I realised that I couldn't show the usage by wrapping the spoiler into a code block.
The spoiler was rendered anyway.

[Nicolas]

Feature from Markdown plugin with Auto-links, can treat ::: sequence as part of URL. Of course if you will write them together.
Thus It will create copy of the spoiler tag.

[Nicolas]

Also here is an example with iframe:

If another plugins don't break spoiler tag :::, everything should work fine.

I'm glad that there is a feedback. Maybe we will find, that solutions with colons don't work in real world

[exodo]

Seems to break post with item lists

[Nicolas]

Show code (markdown) and screenshot, will see is any solution for it

[exodo]

@Nicolas

just add some posts with

:::
- 1
- 2
:::

::: 
- ok
- good
:::

and thrad will be broken

seems to affect to profile pages also

[Nicolas]

@exodo thanks.

I think such construction will work well:

:::
Some text goes here

• ok
• good

:::

Code:

::: 
Some text goes here

- ok
- good

:::

You could use for now, until solution will be provided.
I think main problem here, list is relies on empty space around it.

[exodo]

@Nicolas
thank you, i dont use lists much but breaking the thread makes imposible to edit or open editor without console tricks so its important bug

also i noticed this

[Nicolas]

Ye, they are rendered in preview.
They should be excluded in the same way as images, I think.

https://github.com/NodeBB/NodeBB/issues/3896

[Nicolas]

Ok, it works well with lists, but extra space around list is very important...
Actually, if you don't have extra space (blank line) around list items, It also doesn't look good in composer preview. But yes, if you omit blank lines list with dashes (-) break layout. So some safe checks should be added to prevent such cases.