[nodebb-plugin-ns-spoiler] NS Spoiler
-
My solution is based on CommanMark conversation, about how Markdown Spoiler should look like.
I'm more inclined in direction of colons, than variation of blockquote. So this question is more about vision and not about a complexity
-
Finally spoiler that nodebb deserved. Much apreciated
Does it work with 0.7? -
I have a problem when URL is in the spoiler.
Is this bug or is there way to fix it?
Thank you
-
I have checked with both types of URLs, seems everything is OK with URLs in spoiler:
-
@์ฐ๋ Looks like you've missed a whitespace between the URL and closing
:::.
I guess this is needed in order to work properly, that it's half-way working should be considered a bug.
(everything just concluded of his/her screenshot didn't test anything) -
I am actually having a similar issue. I am guessing it's messing up with youtube plugin.
:::
--some tex1t--
youtube link
--some text2--
:::If I do this, spoiler button and some text1 disappears,
and youtube, some_text2 does not get into the spoiler and shows up
-
I really love the plugin, installed it and it works fine for me!
However, when writing an announcment for my forum that spoilers are now supported I realised that I couldn't show the usage by wrapping the spoiler into a code block.
The spoiler was rendered anyway. -
Feature from Markdown plugin with Auto-links, can treat
:::sequence as part of URL. Of course if you will write them together.
Thus It will create copy of the spoiler tag. -
Also here is an example with iframe:
If another plugins don't break spoiler tag
:::, everything should work fine.I'm glad that there is a feedback. Maybe we will find, that solutions with colons don't work in real world
-
Seems to break post with item lists
-
Show code (markdown) and screenshot, will see is any solution for it
-
@exodo thanks.
I think such construction will work well:
:::
Some text goes here- ok
- good
:::
Code:
::: Some text goes here - ok - good :::You could use for now, until solution will be provided.
I think main problem here, list is relies on empty space around it. -
Ye, they are rendered in preview.
They should be excluded in the same way as images, I think.Exclude content from the last post preview ยท Issue #3896 ยท NodeBB/NodeBB
Hi, Is it possible from the plugin to exclude stuff, so it will not show in last post preview? Is it filter:parse.raw? I mean, If I remove content via this filter, everything will be fine, or there is edge cases?
GitHub (github.com)
-
Ok, it works well with lists, but extra space around list is very important...
Actually, if you don't have extra space (blank line) around list items, It also doesn't look good in composer preview. But yes, if you omit blank lines list with dashes (-) break layout. So some safe checks should be added to prevent such cases.
-
Version 1.1.1
Summary: safer to use
- Additional handler for Markdown Plugin: unwrap lists. It's a safe check, so html will still be valid
- Additional paragraph handlers for Markdown Plugin: shift spoiler tag (start or end) around artificial multilines
- Extra paragraph wrapper around spoiler tag now be removed
Performance of the plugin will be much-much higher, if Core devs provide some solution here
-
Working good thank you
