User Icons Testing

[julian]

Hm, that's not right... not sure why they're showing up blank, while two others were working okay.

Also there's a user named @ElonMusk LOL

[henrywright]

@julian said:

Also there's a user named @ElonMusk LOL

Yup, noticed that too. Keep an eye on the Tesla website for a NodeBB-powered forum

[xen]

Tooltip is not displayed on the teaser.

[julian]

@henrywright said:

Yup, .user-icon is the offending class and line-height is the offending property.

@pitaj @henrywright So yeah, changing this line-height to 31px fixes the issue. Fucking CSS, indeed.

[julian]

Thanks everybody for bug testing the user icons The branch was getting a little stale and I had to re-do bits and pieces of it as they conflicted with master

User Icons have landed in master!

Best of all, the user icons are all generated via CSS! No image processing required (though that was a possible avenue we considered but decided against).

Guide to implementing this in your own custom themes/plugins forthcoming. https://community.nodebb.org/topic/6583/0-9-0-breaking-changes/12

[julian]

Oh, also, we changed the way the colours were picked per-user, so I hope you all weren't attached to your colours during the "beta"

[henrywright]

Looking forward to testing this out!

[julian]

Okay, final blocker to 0.9.0 is complete.

gh#3817

and https://github.com/julianlam/nodebb-plugin-gravatar

[xen]

@julian Now can remove gravatar from package?

[julian]

@xen It's already gone, it's a plugin now

[xen]

@julian I mean from package.json

[julian]

Yes, it is gone from package.json already. It may still be installed locally on your deployment, so you can npm unlink it

[Kowlin]

Guys, please... NodeBB already looks amazing can we stop making it more amazing... Since I'm totally in love with the new profile page's
Edit: did you also brighten up the colors for online, away and such?

[henrywright]

@Kowlin agree these profile changes look awesome! Persona just seems to get better and better each time I log on here

[julian]

@psychobunny should take credit for the user profile revamps

They look a little bit like @pichalite's theme

[psychobunny]

@Kowlin said:

Guys, please... NodeBB already looks amazing can we stop making it more amazing... Since I'm totally in love with the new profile page's
Edit: did you also brighten up the colors for online, away and such?

Okay, I'm going on vacation then

and yeah, up to now the status indicators were using the default bootstrap colours which is criminal IMO