Who favorite'd your post? [completed]

[kevin]

I'm thinking this Disqus/Facebook style feature would be nice.

[Schamper]

I might give this a shot today. Looks like there's a users_favorited field in a post database set. Shouldn't be too hard.

[trevor]

Nice @mr_waffle !

[Schamper]

I got this so far:

Will continue this later on, need to get some other things done first

[bentael]

@Mr_Waffle Nice! is that a plugin? I think you should submit a pull request, it sounds a like core NodeBB feature.

[julian]

Agreed -- this can go in core. I know we do want to possibly move the whole "Favourites" concept out of core altogether, but this isn't something that will happen in the near future.

[Schamper]

Damnit guys it took me extra time to create this as a plugin!

[psychobunny]

rofl keep it as a plugin then its no big deal add one more to your plugin count for this week haha

[finid]

While on this subject, it would be nice to be able to remove an entry from my Favorite list right from my profile page. Or is that doable now?

[psychobunny]

not atm and would be nice if you could navigate to the topic as well, I guess that's something we should add (for both recent posts and favourites)

edit woops been mobbed on skype by an angry @baris that it is indeed impossible to navigate to the topic (clicking posted). x button to remove would be nice though

[Schamper]

@psychobunny said:

rofl keep it as a plugin then its no big deal add one more to your plugin count for this week haha

What if I... Release it as a plugin this week and merge it into core next week >:D

[Chris]

Would be awesome.

As much as I am a fan of plugins something like this really should be core.

Great job though, excited to use it.

[psychobunny]

ahaha finding ways around the rules huh

[finid]

@Chris

Agreed. This less plugins we have implementing basic features, the better for the platform in the long term. The last thing you want to see is to have the dev of a plugin that implements a basic but VIP featrue either quit or stop maintaining it, so that it gets to the point where it might not work with the latest releases.

[julian]

@planner said:

Agreed. This less plugins we have implementing basic features, the better for the platform in the long term.

For the most part, yes. Anything that we intend to be in core can still be a plugin, but installed alongside NodeBB. You'll notice that username mentions and the markdown parser are both plugins, but are auto-installed on every NodeBB environment.

For something like the favourites tooltip, I think is small enough to merge directly into core

[Schamper]

Don't worry guys, I'll make it core eventually. Just really busy with exams atm

[julian]

^ Then I'm sorry I monopolized your time yesterday!

(not too sorry though)

[psychobunny]

If you do this much stuff while busy with exams, I'd like to see what you do when you're off haha

[kevin]

@Mr_Waffle you are seriously awesome!