@yosukey https://github.com/NodeBB/NodeBB/issues/5538
pitaj created this issue in NodeBB/NodeBB closed Japanese ACP translations broken #5538YouTube Embedding Broken in 0.5.3
-
After updating to 0.5.3, all videos have stopped working. It's in all threads, including old ones that have worked for months. Here is an example page...
US Just Lost Its Antares Rocket Headed to the International Space Station
Explosion on take off. Only made it six seconds. https://www.youtube.com/watch?v=jHMmMgdcOSU
-
Is YouTube embed a plugin?
-
Yes it is.
-
It is still embedding, just not playing anymore.
-
Hmm it must be plugin problem, since nbb undergoes heavy changes with each iteration, my suggestion is to refrain from using much plugins till nodebb becomes stable eg version 1.0+ .
As for this YouTube plugin, it would be helpful if you can tag the plugin author. My bet is that this is a compatibility issue. -
@scottalanmiller any chance this could be related to the last letter being cut off from each post?
jonschlinkert/remarkable#88
closed last character missing #88
-
@julian is there anyway these basic features like YouTube embed and other one box stuff, like link preview be integrated into core. Because these are required by every communities, so why have them as plugins, when nbb itselfcan have embed capabilities. Please consider this.
-
@vegetagz6 I like the embed plugins, you like them too.
Unfortunately, they're still bloat. Not everybody wants them, and we want video embed to be a choice that admins enable.
If a forum wanted vimeo, it wouldn't be fair to have YouTube forcibly enabled as well.
-
Hmm no, ok I don't like comparing software, but I will try to cite out an example. In case of discourse, they have this one box stuff where it will give preview of all video sites, YouTube, vimeo daily motion etc. and Wikipedia articles, twitter fb etc etc. But if an admin wants to disable it, he or she can deactivate the un needed sites at the back end, or disable onebix completely.
I am talking about such feature, which can suit all kinda of communities, will depend on admin to activate it or deactivate it. Which minimises the use of plugin. @julian
-
@julian said:
@scottalanmiller any chance this could be related to the last letter being cut off from each post?
jonschlinkert/remarkable#88
OMG, duh. Let me check.
-
@vegetagz6 embed.ly plugin does this, AFAIK.
Discourse also builds everything into core, which is a different design decisions. I don't like comparing forum software either
-
@julian said:
@scottalanmiller any chance this could be related to the last letter being cut off from each post?
jonschlinkert/remarkable#88
Okay yes, that's it. What we just learned from this is that the forum isn't cutting off the last letter of NEW posts, but of ALL posts. We just hadn't noticed yet. Once I added an extra character, the video works.
So the issue is really figuring out that last letter thing as that has broken, I am getting thousands of links and embeds.
-
Yup NBB has its own way to grow. But why I suggested this feature as core is because as we all know, NBB is undergoing heavy changes with each updates, right? So chances of plugins breaking are a lot. So if all features like SMTP, embedly which are required the most, are to be outsourced from plugins, a forum admin might go confused, when he updates nbb from, say 0.7 to 0.8 version and majority of plugins go berserk. I was first thinking to suggest that the main NBB team can themselves maintain a couple of plugins which are regularly updated with corresponding core nbb releases. But then, you guys are already busy with nbb, I can see how often you tweak NBB in github, which shows all of you are giving it your best.
So I thought it would be better to adopt the most necessary as core. Once NBB becomes stable, then all these incompatibility issues will subside a lot, also by then more active developers will start releasing and updating their plugins. Hope you take this on a positive note. @julian
-
@vegetagz6 said:
NBB is undergoing heavy changes with each updates, right?
Not intentionally, mind you. Breaking changes should be minimised, and they should always have deprecation warnings.
Between a patch version, there should be no breaking changes, only deprecations. A minor version may contain breaking changes, which would be outlined in a "gotchas" thread.
-
It's a core plugin, not separately maintained, and it didn't break here. I've not seen any issues with the maintained, core plugins and they are just as likely to break as plugins as they are as part of the mainline code when they are maintained by the same people
-
@julian hmm, by the way I just had a thought, in managed NBB hosting that you guys offer, how do you guys allow plugin installation and all? Do the users of managed hosting get to choose any plugin in npm repository from the ACP like normal non managed forum users. If so, how does the plugin get reset without SSH support, in case the plugin or theme is incompatible or broken???
-
@vegetagz6 said:
If so, how does the plugin get reset without SSH support, in case the plugin or theme is incompatible or broken???
They ping us using our support ticket system and we uninstall the plugin.
The package manager is undergoing changes right now, so plugin incompatibilities are hopefully going to be a thing of the past. gh#1342
closed NodeBB Package Manager #1342
-
-
-
https://github.com/a5mith/nodebb-plugin-embedly
But it's not whitelabel. Should still work. (He says)
