3.4.0 Upgrade Support

phenomlab

I see an issue on mobile within the chat view. If modals are enabled, chat messages do not open. If modals are disabled, chats open but you can't close the message or use the back button in the message view because it's partially obscured in the sense that the element position is set too high.

Edit - odd, but seems ok now.

DownPW

@baris

package.json at /home/xxxx/nodebb/node_modules/@nodebb/nodebb-plugin-reaction indicates 2.1.9 version

what is the last version ?

<baris>

2.1.10 is latest but 2.1.19 is fine for 3.4.0 as well.

What about package.json in your nodebb folder? It should only have @nodebb/nodebb-plugin-reactions

DownPW

@baris

<baris>

If there is no "nodebb-plugin-reactions" in that file then everything should work and you should see smiley face instead of + after building and restarting

DownPW

So should I delete the line above?

<baris>

@DownPW no that line is fine, if there is a line "nodebb-plugin-reactions": "x.x.x" you should delete that one.

DownPW

nope, I haven't got other line like this but doesn't work grrr

DownPW

I'm going to try uninstalling again

<baris>

You can also check if something has modified topic.tpl like nodebb-plugin-customize, that might prevent the correct reactions template from showing up.

DownPW

yep I use nodebb-plugin-customize for toping rating plugin in topic.tpl file

DownPW

yep @baris I have delete my customisation on topic.tpl file for toping rating plugin and reaction plugin is good now. Thanks.
--> So I'm thinking of deleting this customization if I have to delete it and redo it every time.

-- I also note that the topic rating plugin announces NaN now on topic_list An idea ?

-- So I'm also going to wait for the typo on the french translation. I imagine that we will have to update nodeBB again ?

<baris>

@DownPW @nodebb/[email protected] should fix the NaN issue

DownPW

@baris said in 3.4.0 Upgrade Support:

@DownPW @nodebb/[email protected] should fix the NaN issue

OK Thank you @baris !
Test this version ASAP

@baris

-- I see that when user type on chat even after a refresh and delete cache :

-- Same thing for the "tooltip" label on pinned messages and the message that appears when no message is pinned :

EDIT:

no frech traduction on tooltip (reaction plugin) :

DownPW

@baris

it's seems to be related to french language.

I just switched my development environment from English to French and I can reproduce all its bugs

chat.pinned-messages : Messages épinglés or Messages de Chat épinglés
chat.no-pinned-messages : Aucun messages épinglés or Aucun messages de Chat épinglés
chat.pin-message : Épingler le message or Épingler le message du Chat
chat.unpin-messages : Désépingler le message or Désépingler le message de Chat
Add reaction : Ajouter une réaction

<baris>

Yeah it happens because of the missing translations for the new keys. They will be fixed once people add the translations on transifex.

DownPW

I have add translation here @baris

Or how to add on Transiflex ?

<baris>

You can do translations at https://explore.transifex.com/nodebb/nodebb/, They are pulled into nodebb regularly and then when we make a release they are included.

DownPW

OK, I will do it now.

And you know if this is relating to translation ?

<baris>

Yes that is caused by a missing translation as well. You can test in en-GB to confirm.