NodeBB 3.4.0

<baris>

Was this a public or private chat? Does it only happen when you create the room with a non-admin user?

DownPW

This happened to me in a public group @baris
I created it with my account which is administrator

<baris>

Can you reproduce it when you try again? I created a few public rooms and didn't notice any issues.

DownPW

I don't know @baris I didn't notice it right away.
Juste today, 3 or 4 day ago after creation.

I suggest that I monitor this if that suits you of course

cagatay

Will there be a new update?
Is there any work on v4?

DownPW

https://github.com/NodeBB/NodeBB/releases

last release is 3.4.3 @cagatay

<baris>

Next release is going to be 3.5.0

brazzerstop

I think we need fix container size for tablets, current we have very big empty place on left and right...

https://github.com/NodeBB/nodebb-theme-harmony/blob/main/templates/header.tpl#L42
https://github.com/NodeBB/nodebb-theme-harmony/blob/main/templates/partials/header/brand.tpl#L2

Replace container to container-lg

Before (topic)

After (topic)

Before (categories)

After (categories)

crazycells

hi @julian , is this plugin compatible with v3?

https://github.com/julianlam/nodebb-plugin-support-forum

brazzerstop

NodeBB began the transition to NodeJS v18? So, we can say bye-bye to resource econony Ubuntu 18.04

Updating NodeBB...

1. Updating package.json file with defaults...  OK

2. Bringing base dependencies up to date...  started
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '>=18.12.0' },
npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
npm WARN EBADENGINE }

changed 2 packages, and audited 1106 packages in 5s

138 packages are looking for funding
  run `npm fund` for details

10 moderate severity vulnerabilities

PitaJ

@brazzerstop lint-staged is a dev-dependency, not sure why it's showing up there but you can safely ignore that warning.

brazzerstop

@PitaJ
Yes, I am using the develop version and regardless of the warning, I successfully updated, and so far everything is working on version NodeJS 16.

But I will still be preparing to move to Ubuntu 20.04 so that I can install the 18th version of the NodeJS, because it seems to me that the NodeBB will gradually increase the requirements to dependencies for security reasons.

<baris>

@brazzerstop https://github.com/NodeBB/NodeBB/issues/12107.

Node 16 is end of life so it's a good idea to start migrating to 18.

sweetp

I’m running on Node 21 without issue

sweetp

although I do have a bunch of warnings:

(node:1542010) [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake.

<baris>

@sweetp If you run nodebb with the --throw-deprecation flag then it should throw an error instead of a warning, that should hopefully show us the stack trace where it is happening.

sweetp

@Baris here's a different error, ill keep trying to generate the other error I also mentioned:

2023-10-22T18:45:39.710Z [4568/2336493] - error: uncaughtException: The `punycode` module is deprecated. Please use a userland alternative instead.
DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:392:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:328:10)
    at loadBuiltinModule (node:internal/modules/helpers:102:7)
    at Module._load (node:internal/modules/cjs/loader:995:17)
    at Module.require (node:internal/modules/cjs/loader:1229:19)
    at require (node:internal/modules/helpers:177:18)
    at Object.<anonymous> (/var/www/vhosts/mysite.com/NodeBB/node_modules/psl/index.js:5:16)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10) {"date":"Sun Oct 22 2023 20:45:39 GMT+0200 (Central European Summer Time)","error":{"code":"DEP0040","name":"DeprecationWarning"},"exception":true,"os":{"loadavg":[0.45,0.28,0.12],"uptime":1000799.34},"process":{"argv":["/opt/plesk/node/21/bin/node","/var/www/vhosts/mysite.com/NodeBB/app.js"],"cwd":"/var/www/vhosts/mysite.com/NodeBB","execPath":"/opt/plesk/node/21/bin/node","gid":1003,"memoryUsage":{"arrayBuffers":533115,"external":4010196,"heapTotal":82853888,"heapUsed":56554376,"rss":145403904},"pid":2336493,"uid":10011,"version":"v21.0.0"},"stack":"DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.\n    at node:punycode:3:9\n    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:392:7)\n    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:328:10)\n    at loadBuiltinModule (node:internal/modules/helpers:102:7)\n    at Module._load (node:internal/modules/cjs/loader:995:17)\n    at Module.require (node:internal/modules/cjs/loader:1229:19)\n    at require (node:internal/modules/helpers:177:18)\n    at Object.<anonymous> (/var/www/vhosts/mysite.com/NodeBB/node_modules/psl/index.js:5:16)\n    at Module._compile (node:internal/modules/cjs/loader:1369:14)\n    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)","trace":[{"column":9,"file":"node:punycode","function":null,"line":3,"method":null,"native":false},{"column":7,"file":"node:internal/bootstrap/realm","function":"BuiltinModule.compileForInternalLoader","line":392,"method":"compileForInternalLoader","native":false},{"column":10,"file":"node:internal/bootstrap/realm","function":"BuiltinModule.compileForPublicLoader","line":328,"method":"compileForPublicLoader","native":false},{"column":7,"file":"node:internal/modules/helpers","function":"loadBuiltinModule","line":102,"method":null,"native":false},{"column":17,"file":"node:internal/modules/cjs/loader","function":"Module._load","line":995,"method":"_load","native":false},{"column":19,"file":"node:internal/modules/cjs/loader","function":"Module.require","line":1229,"method":"require","native":false},{"column":18,"file":"node:internal/modules/helpers","function":"require","line":177,"method":null,"native":false},{"column":16,"file":"/var/www/vhosts/mysite.com/NodeBB/node_modules/psl/index.js","function":null,"line":5,"method":null,"native":false},{"column":14,"file":"node:internal/modules/cjs/loader","function":"Module._compile","line":1369,"method":"_compile","native":false},{"column":10,"file":"node:internal/modules/cjs/loader","function":"Module._extensions..js","line":1427,"method":".js","native":false}]}
2023-10-22T18:45:39.711Z [4568/2336493] - error: DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:392:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:328:10)
    at loadBuiltinModule (node:internal/modules/helpers:102:7)
    at Module._load (node:internal/modules/cjs/loader:995:17)
    at Module.require (node:internal/modules/cjs/loader:1229:19)
    at require (node:internal/modules/helpers:177:18)
    at Object.<anonymous> (/var/www/vhosts/mysite.com/NodeBB/node_modules/psl/index.js:5:16)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
2023-10-22T18:45:39.711Z [4568/2336493] - info: [app] Shutdown (SIGTERM/SIGINT/SIGQUIT) Initialised.
2023-10-22T18:45:39.825Z [4568/2336493] - error: TypeError: ttl must be positive integer or Infinity if set
    at new TTLCache (/var/www/vhosts/mysite.com/NodeBB/node_modules/@isaacs/ttlcache/index.js:35:13)
    at module.exports (/var/www/vhosts/mysite.com/NodeBB/src/cache/ttl.js:7:19)
    at Object.<anonymous> (/var/www/vhosts/mysite.com/NodeBB/src/middleware/uploads.js:8:15)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
    at Module.load (node:internal/modules/cjs/loader:1201:32)
    at Module._load (node:internal/modules/cjs/loader:1017:12)
    at Module.require (node:internal/modules/cjs/loader:1229:19)
    at require (node:internal/modules/helpers:177:18)
    at Object.<anonymous> (/var/www/vhosts/mysite.com/NodeBB/src/middleware/index.js:67:22)

sweetp

@baris here's the original warning:

(node:2339958) [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake.
    at node:internal/util:443:17
    at new Promise (<anonymous>)
    at Object.buildHeaderAsync (node:internal/util:428:12)
    at exports.send404 (/var/www/vhosts/mysite.com/NodeBB/src/controllers/404.js:62:19)
    at handle404 (/var/www/vhosts/mysite.com/NodeBB/src/controllers/404.js:41:11)
    at Layer.handle [as handle_request] (/var/www/vhosts/mysite.com/NodeBB/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/var/www/vhosts/mysite.com/NodeBB/node_modules/express/lib/router/index.js:328:13)
    at /var/www/vhosts/mysite.com/NodeBB/node_modules/express/lib/router/index.js:286:9
    at Function.process_params (/var/www/vhosts/mysite.com/NodeBB/node_modules/express/lib/router/index.js:346:12)
    at next (/var/www/vhosts/mysite.com/NodeBB/node_modules/express/lib/router/index.js:280:10)

<baris>

@sweetp This warning should be fixed in 3.5.0

stationary_code

Hello, I am currently using 3.5.0 and this message is currently spamming the log.

(node:37195) [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake.
(node:37195) [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake.
(node:37195) [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake.