3.0.0 Upgrade Support Thread

phenomlab

sudonix@vps:~/nodebb$ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/nodebb-plugin-emoji
npm ERR!   nodebb-plugin-emoji@"5.0.6" from the root project
npm ERR!   peer nodebb-plugin-emoji@"^5.0.0" from [email protected]
npm ERR!   node_modules/nodebb-plugin-emoji-android
npm ERR!     nodebb-plugin-emoji-android@"4.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer nodebb-plugin-emoji@"^4.0.1" from [email protected]
npm ERR! node_modules/nodebb-plugin-emoji-apple
npm ERR!   nodebb-plugin-emoji-apple@"^3.0.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/nodebb-plugin-emoji
npm ERR!   peer nodebb-plugin-emoji@"^4.0.1" from [email protected]
npm ERR!   node_modules/nodebb-plugin-emoji-apple
npm ERR!     nodebb-plugin-emoji-apple@"^3.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /home/sudonix/.npm/_logs/2023-04-26T17_33_29_315Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/sudonix/.npm/_logs/2023-04-26T17_33_29_315Z-debug-0.log
sudonix@vps:~/nodebb$

phenomlab

npm install --save --legacy-peer-deps looks like it works, but exactly the same

julian

What npm version are you using, and have you tried --force? It looks like the issue is emoji-apple (and maybe emoji-android) are requesting an older version of plugin-emoji, even though the version in package.json is newer.

phenomlab

npm version is 9.5.1. Using --force does not work either.
For clarity, my dev instance runs on the same server and has no issues whatsoever.

julian

npm 9, hm... Definitely haven't tried that.

phenomlab

@julian Upgraded to 9.6.5 same issues

phenomlab

@julian think I have it working by using npm config set legacy-peer-deps true

EDIT: Confirmed - up and running.

DownPW

maybe a little tutorial for us

phenomlab

@DownPW Exactly.

sweetp

This is what I do for updates:

git fetch
git stash
git checkout v3.x
git merge origin/v3.x
./nodebb upgrade
git stash drop

FrankM

I switched my dev forum from v3.0.0-rc.2 to v3.0.0 without any problems.

git fetch
git reset --hard v3.0.0
./nodebb upgrade

Restart NodeBB an i am on v3.0.0

DownPW

maybe a tutorial for 2.x to v3.0.0

julian

@DownPW yeah there's really not that much to change Those commands will do it (although you'll be on Persona still, and not Harmony, but that's a ./nodebb reset -t away.

josef

It seems that the client side methods (console/Tampermonkey etc, not in plugin) app.alert, app.alertSuccess and app.alertError are gone (they are undefined)
What is the substitute for that?
Thanks

<baris>

const  alerts = await app.require('alerts');
alerts.error('message');

Gliding9426

instead, upgrading from docker image: ghcr.io/nodebb/nodebb:2.8 to image: ghcr.io/nodebb/nodebb:3.0 I get this: ENOENT: no such file or directory, open '/usr/src/app/node_modules/csurf/package.json'

edit: switched to normal install and I don't get this error anymore

TaLoche

I made it!

Upgraded from nodebb v1.17 on Ubuntu 18.04 with mongodb 4.0 to nodebb v3.2.1 on Ubuntu 20.04 with mongodb 5.0. Used node v18 to update nodebb.

Had a few minor issues (getting rid of an expired mongodb 4.0 key), thinking of using npm install --global npm@6 to avoid any issue with plugins updates (emoiji, markdown).

And voilà!

Thanks for all the work, the new admin dashboard is sexy as hell.
Keep up the good work and enjoy your summer!

Happy GIF

Sebastián Cisneros

@julian I have a custom theme , started from persona, and custom plugins all working fine until nodebb v2.8.12. Trying to update nodebb to version 3.0.0 first, and then maybe jump to newer nodebb versions after I get all the new stuff from nodebb working with my custom theme and plugins.

So far, I updated all the less files to scss, and the theme nodebb 3.0.0 compiles and finished the ./nodebb upgrade steps correctly. Even when I do a ./nodebb dev , all works fine, server starts without any errors, all goo until this point.

But, when I open the websites in a browser ... errors start comming up.

First this one

TypeError: Cannot set properties of undefined (setting 'scripts')
    at renderFooter (...\nodebb\src\middleware\render.js:332:35)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async renderHeaderFooter (...\nodebb\src\middleware\render.js:371:11)
    at async Promise.all (index 2)
    at async renderMethod (...\nodebb\src\middleware\render.js:88:21)
    at async ServerResponse.renderOverride [as render] (...\nodebb\src\middleware\render.js:111:5)

then, if I keep clicking the reload page (f5 on windows) the errro changes to this one

TypeError: Cannot read properties of undefined (reading '_locals')
    at Function.render (...\nodebb\node_modules\express\lib\application.js:566:12)
    at Function.<anonymous> (...\nodebb\src\webserver.js:13:63)
    at node:internal/util:360:7
    at new Promise (<anonymous>)
    at Function.renderAsync (node:internal/util:346:12)
    at renderHeader (...\nodebb\src\middleware\render.js:318:24)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async renderHeaderFooter (...\nodebb\src\middleware\render.js:369:11)
    at async Promise.all (index 0)
    at async renderMethod (...\nodebb\src\middleware\render.js:88:21)

I've read the https://nodebb.org/blog/migration-guide-for-v3/ , the only update I did to my theme is the less to scss , no other updates have been done to the theme or the custom plugins. I know this is a long shoot, but any idea what I may be missing?

Thanks.

<baris>

What hooks are you using if any? Can you post the code around that line at renderFooter (...\nodebb\src\middleware\render.js:332:35)

It is likely an imcompatible plugin/hook causing the crash.

Sebastián Cisneros

@baris these are the ones I customizedin the theme

"hooks": [
{ "hook": "filter:widgets.getAreas", "method": "defineWidgetAreas" },
{ "hook": "filter:middleware.renderHeader", "method": "allPagesBuild" },
{ "hook": "filter:middleware.renderFooter", "method": "allPagesBuild" },
{ "hook": "filter:middleware.renderFooter", "method": "allPagesBuildOnlyFooter" },
{ "hook": "filter:topic.build", "method": "topicBuild"},
{ "hook": "filter:category.build", "method": "categoryBuild"},
{ "hook": "filter:categories.build", "method": "categoriesBuild"},
{ "hook": "filter:tag.build", "method": "tagBuild"},
{ "hook": "filter:top.build", "method": "topBuild"},
{ "hook": "filter:popular.build", "method": "popularBuild"},
{ "hook": "filter:notifications.build", "method": "notificationsBuild"},
{ "hook": "action:notification.pushed", "method": "notificationsPushed"},
{ "hook": "filter:account/settings.build", "method": "notificationsSettingsBuild"},
{ "hook": "filter:search.build", "method": "searchBuild"},
{ "hook": "filter:topic.post", "method": "topicPost" },
{ "hook": "filter:topic.edit", "method": "topicEdit" },
{ "hook": "filter:topic.delete", "method": "topicDelete" },
{ "hook": "filter:post.getPosts", "method": "postsEdit" },
{ "hook": "action:post.delete", "method": "postsDelete" },
{ "hook": "static:app.load", "method": "init" },
{ "hook": "filter:email.prepare", "method": "emailPrepare" },
{ "hook": "filter:email.modify", "method": "emailContentFilter" },
{ "hook": "filter:email.params", "method": "emailParamsFilter" },
{ "hook": "filter:email.cancel", "method": "emailCancel" },
{ "hook": "filter:user.notificationTypes", "method": "userNotificationTypes"},
{ "hook": "action:topic.follow", "method": "topicFollow" },
{ "hook": "filter:topic.reply", "method": "topicReply" },
{ "hook": "filter:users.build", "method": "usersBuild" },
{ "hook": "filter:users.addFields", "method": "usersAddFields" },
{ "hook": "filter:user.whitelistFields", "method": "userWhitelistFields" },
{ "hook": "filter:user.updateProfile", "method": "userUpdateProfile" },
{ "hook": "action:topic.post", "method": "topicPostAction" },
{ "hook": "action:topic.save", "method": "topicSaveAction" },
{ "hook": "action:topic.purge", "method": "topicPurge" },
{ "hook": "static:api.routes", "method": "addRoutes" },
{ "hook": "filter:userlist.get", "method": "getUserList"},
{ "hook": "filter:topic.getFields", "method": "topicGetTopic" },
{ "hook": "filter:user.getSettings", "method": "userGetSettings" },
{ "hook": "action:topic.move", "method": "topicMove" }
],

but i'm sure I used a couple more on different custom plugins

so you think it can be aournd these?

{ "hook": "filter:middleware.renderHeader", "method": "allPagesBuild" },
{ "hook": "filter:middleware.renderFooter", "method": "allPagesBuild" },
{ "hook": "filter:middleware.renderFooter", "method": "allPagesBuildOnlyFooter" },

Is there any documnetation where I can see what changed? so I know how to update my theme to work again?