NodeBB v3.0.0-rc.2 — the second release candidate

phenomlab

@julian doesn't seem to work

I get the below

sudonix.dev@vps:~/nodebb$ git reset --hard origin/v3.0.0-rc.2
fatal: ambiguous argument 'origin/v3.0.0-rc.2': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

julian

@phenomlab Sorry about that, I think you don't need the origin/ part, so I've removed it from the command.

phenomlab

@julian that works, thanks. Upgrading now

EDIT - successfully upgraded to rc2

exodo

Nice. Seems nodebb 3.0 is near
Sadly I dont see any change on ios devices and ultra big layout from the betas keeps happening

sweetp

.line-clamp-2 needs to be update with:
max-height: 2.5em

actually, they all need to be updated to multiples of 1.25 em, rather than multiples of 1.5em

<baris>

@sweetp https://github.com/NodeBB/NodeBB/commit/2f94b4b8505796224a6ee34f5f2bf50c66388ede

sweetp

@baris said in NodeBB v3.0.0-rc.2 — the second release candidate:

@sweetp https://github.com/NodeBB/NodeBB/commit/2f94b4b8505796224a6ee34f5f2bf50c66388ede

yup that fixes it!

Adam C

Do you have an estimated release date for V3? I'm planning to set up a new community website using NodeBB. Would it be better to install the V3 beta or wait for the official release?

julian

@Adam-C I'd install the v3 RC, but I'm biased

Adam C

Thank you! Will do.

<baris>

@sweetp said in NodeBB v3.0.0-rc.2 — the second release candidate:

.line-clamp-2 needs to be update with:
max-height: 2.5em

actually, they all need to be updated to multiples of 1.25 em, rather than multiples of 1.5em

@sweetp I had to make a change to this since it broke the max-height calculation on chat dropdowns. https://github.com/NodeBB/NodeBB/commit/fa633ec7ca287f4150f14c87209c7cb5cfb78f69

In some places we need 1.5 which is the $line-height-base and in some places we need 1.25 which is line-height-sm. I added a new class line-clamp-sm-[1-6]. So instead of hardcoding the max-height to 1.25em * $lines it will be calculated by using $line-height * $lines.

I pushed this change to this forum so let me know if you notice any issues.

sweetp

@baris said in NodeBB v3.0.0-rc.2 — the second release candidate:

I pushed this change to this forum so let me know if you notice any issues.

It looks fine on my end,
I updated my test forum, and all looks well there too.
Ill push it to my production forum now

<baris>

We haven't released a new RC but there are some small fixes in harmony and core since the last rc. If you want to grab those you can update core and run upgrade. On develop branch.

./nodebb stop
git pull
./nodebb upgrade
./nodebb start